feat(v9): migrate checkbox,input,label,link,select to ship rolluped only dts#22793
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 62278b3:
|
📊 Bundle size report
Unchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 48dbe4cb1f67a38a4c0a4e0d5282c98741ca16c2 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1221 | 1172 | 5000 | |
| Button | mount | 734 | 774 | 5000 | |
| FluentProvider | mount | 2347 | 2278 | 5000 | |
| FluentProviderWithTheme | mount | 382 | 372 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 378 | 313 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 445 | 409 | 10 | |
| MakeStyles | mount | 2005 | 1924 | 50000 |
| export const decorators = [...rootPreview.decorators]; | ||
|
|
||
| /** @type {typeof rootPreview.parameters} */ | ||
| export const parameters = { |
There was a problem hiding this comment.
This is changing only in react-input, is it intentional?
There was a problem hiding this comment.
hmm so I missing the context why there is used such a custom setup needed.
to remind reviewers again, nothing was changed by hand from my side.
If that's configuration has a reasoning I'd suggest to provide that reasoning for future migration runs, so person executing these automations has full context and thus can undo appropriately. Migration generators are not using AST for storybook configs as that's not needed at the moment and to implement it the effort would be non trivial.
hope it makes sense, ty
…nly dts (microsoft#22793) * feat(v9): migrate checkbox,input,label,link,select to ship rolluped only dts * generate change files
Applied
yarn workspace-generator migrate-converged-pkgto ship only rolluped type definitions for:Related Issue(s)
Fixes partially #22429