fix(react-card): add react-components to vr-tests asset path#22785
Merged
theerebuss merged 1 commit intomicrosoft:masterfrom May 3, 2022
theerebuss:fix-card-vr-tests
Merged
fix(react-card): add react-components to vr-tests asset path#22785theerebuss merged 1 commit intomicrosoft:masterfrom theerebuss:fix-card-vr-tests
react-components to vr-tests asset path#22785theerebuss merged 1 commit intomicrosoft:masterfrom
theerebuss:fix-card-vr-tests
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0960d8b:
|
Collaborator
📊 Bundle size report🤖 This report was generated against 3e0ff753cbb3375f28477b2249ecd8b012e2e946 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 3e0ff753cbb3375f28477b2249ecd8b012e2e946 (build) |
Contributor
Author
|
Screener fail is expected, will approve the changes after I get PR approval. |
ling1726
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Due to the moving of the package, the usage of hardcoded absolute URLs to access GitHub raw assets in our stories is using the wrong path.
New Behavior
Path now accounts for the
react-components/move.Related Issue(s)
#22692