Link: Adding hrefs to all non-button stories#22774
Merged
khmakoto merged 3 commits intomicrosoft:masterfrom May 2, 2022
Merged
Link: Adding hrefs to all non-button stories#22774khmakoto merged 3 commits intomicrosoft:masterfrom
khmakoto merged 3 commits intomicrosoft:masterfrom
Conversation
micahgodbolt
reviewed
May 2, 2022
packages/react-components/react-link/src/stories/LinkInline.stories.tsx
Outdated
Show resolved
Hide resolved
micahgodbolt
reviewed
May 2, 2022
packages/react-components/react-link/src/stories/LinkInline.stories.tsx
Outdated
Show resolved
Hide resolved
…ories.tsx Co-authored-by: Micah Godbolt <micahgodbolt@gmail.com>
…ories.tsx Co-authored-by: Micah Godbolt <micahgodbolt@gmail.com>
smhigley
approved these changes
May 2, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 55d6176:
|
Collaborator
📊 Bundle size report🤖 This report was generated against ace1c2193cbff237cb4cda006dad4ed7f8eb1e74 |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 912 | 880 | 5000 | |
| Button | mount | 571 | 565 | 5000 | |
| FluentProvider | mount | 1841 | 1823 | 5000 | |
| FluentProviderWithTheme | mount | 285 | 299 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 236 | 223 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 318 | 309 | 10 | |
| MakeStyles | mount | 1592 | 1488 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: d029c9cf0f0f5fc92d01208a93131ec7b170172c (build) |
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* Link: Adding hrefs to all non-button stories. * Update packages/react-components/react-link/src/stories/LinkInline.stories.tsx Co-authored-by: Micah Godbolt <micahgodbolt@gmail.com> * Update packages/react-components/react-link/src/stories/LinkInline.stories.tsx Co-authored-by: Micah Godbolt <micahgodbolt@gmail.com> Co-authored-by: KHMakoto <humberto_makoto@hotmail.com> Co-authored-by: Micah Godbolt <micahgodbolt@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Linkstories didn't havehrefswhich made them render asbuttons.New Behavior
Linkstories now havehrefs(except for the render as button one) which makes them render asatags and more correctly reflect their usage.Related Issue(s)
Fixes 13993