docs: Removing deprecated attribute from ContextualMenu's example#22771
Merged
sopranopillow merged 1 commit intomicrosoft:masterfrom May 3, 2022
Merged
docs: Removing deprecated attribute from ContextualMenu's example#22771sopranopillow merged 1 commit intomicrosoft:masterfrom
sopranopillow merged 1 commit intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f1275a5:
|
Collaborator
📊 Bundle size report🤖 This report was generated against ace1c2193cbff237cb4cda006dad4ed7f8eb1e74 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: ace1c2193cbff237cb4cda006dad4ed7f8eb1e74 (build) |
khmakoto
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the example
CustomMenuListfrom ContextualMenu where filtering the menu list removes the link item. This is due to the menu item using the propertynameinstead oftext.Current Behavior
Link disappears out of the list after filtering the list due to using the deprecated
nameinstead oftext.New Behavior
Link will not disappear after being filtered.
Related Issue(s)
Fixes #21256