fix(react-radio): Allow data argument on onChange#22753
Merged
miroslavstastny merged 2 commits intomicrosoft:masterfrom May 3, 2022
Merged
fix(react-radio): Allow data argument on onChange#22753miroslavstastny merged 2 commits intomicrosoft:masterfrom
miroslavstastny merged 2 commits intomicrosoft:masterfrom
Conversation
miroslavstastny
commented
May 2, 2022
| * Radio Props | ||
| */ | ||
| export type RadioProps = Omit<ComponentProps<Partial<RadioSlots>, 'input'>, 'size'> & { | ||
| export type RadioProps = Omit<ComponentProps<Partial<RadioSlots>, 'input'>, 'onChange' | 'size'> & { |
Member
Author
There was a problem hiding this comment.
This approach is supposed to be consistent with InputProps in react-input.
GeoffCoxMSFT
approved these changes
May 2, 2022
Member
|
@micahgodbolt - you are helping out with radio and checkbox right? If so, you should review too :) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6f7edfc:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
spmonahan
approved these changes
May 2, 2022
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1115 | 1121 | 5000 | |
| Button | mount | 679 | 676 | 5000 | |
| FluentProvider | mount | 2267 | 2259 | 5000 | |
| FluentProviderWithTheme | mount | 331 | 340 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 293 | 295 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 369 | 343 | 10 | |
| MakeStyles | mount | 1848 | 1848 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 55e2b1b53e81efa510a5bc15c6ab0398b52ace7f (build) |
khmakoto
approved these changes
May 2, 2022
micahgodbolt
approved these changes
May 2, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* fix(react-radio): Allow data argument on onChange * changefile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
Radio.onChange(event, data)results in typescript error,dataargument is not allowed:New Behavior
Radio.onChangenow has two arguments -eventanddata.Related Issue(s)
Fixes #22752