feat(v9): migrate react-components suite to ship rolluped only dts#22746
Merged
Hotell merged 3 commits intomicrosoft:masterfrom May 3, 2022
Merged
Conversation
50 tasks
Hotell
commented
May 2, 2022
| { | ||
| "$schema": "https://developer.microsoft.com/json-schemas/api-extractor/v7/api-extractor.schema.json", | ||
| "extends": "@fluentui/scripts/api-extractor/api-extractor.common.v-next.json", | ||
| "mainEntryPointFilePath": "<projectFolder>/dist/types/unstable/index.d.ts", |
Contributor
Author
There was a problem hiding this comment.
this is needed to process unstable api. thank to this we now have a common approach for unstable apis introduction to any package
Hotell
commented
May 2, 2022
| @@ -0,0 +1,454 @@ | |||
| ## API Report File for "@fluentui/react-components" | |||
|
|
|||
| > Do not edit this file. It is a report generated by [API Extractor](https://api-extractor.com/). | |||
Contributor
Author
There was a problem hiding this comment.
new api reported - generated content
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a6cd2f7:
|
Collaborator
📊 Bundle size report🤖 This report was generated against 2af90d0c5b7c95724a01b71ab9b24d1bd5da2f6d |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1134 | 1082 | 5000 | |
| Button | mount | 690 | 674 | 5000 | |
| FluentProvider | mount | 2247 | 2289 | 5000 | |
| FluentProviderWithTheme | mount | 348 | 357 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 303 | 291 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 376 | 365 | 10 | |
| MakeStyles | mount | 1963 | 1926 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 2af90d0c5b7c95724a01b71ab9b24d1bd5da2f6d (build) |
GeoffCoxMSFT
approved these changes
May 2, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…icrosoft#22746) * feat(v9): migrate react-components suite to ship rolluped only dts * generate changefile * fixup! feat(v9): migrate react-components suite to ship rolluped only dts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applied yarn workspace-generator migrate-converged-pkg to ship only rolluped type definitions for:
From now on,
unstableapi is processed in same fashion like stable - we generate api.md file on any change 🚀Related Issue(s)
Fixes partially #22429