Input: Update Content Before and After Stories, Labels on Stories#22731
Merged
spmonahan merged 3 commits intomicrosoft:masterfrom May 2, 2022
Merged
Input: Update Content Before and After Stories, Labels on Stories#22731spmonahan merged 3 commits intomicrosoft:masterfrom
spmonahan merged 3 commits intomicrosoft:masterfrom
Conversation
spmonahan
commented
Apr 29, 2022
| borderBottomColor: tokens.colorNeutralStrokeAccessibleHover, | ||
| }, | ||
| // DO NOT add a space between the selectors! It changes the behavior of make-styles. | ||
| ':active,:focus-within': { |
Contributor
Author
There was a problem hiding this comment.
Note: there is a bug in the version of Griffel currently used in this package that will apply this :focus-within style to buttons used in the contentBefore and contentAfter slots. The PR that fixes is already merged, just need to have a new version published and the dependency updated here.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2a4009d:
|
Updates the contentBefore and contentAfter stories to demonstrate these slots in an accessible way. These types of scenarios quickly become quite nuanced so the examples were chosen to be as simple as possible from an accessibility lens while still being correct and while demonstrating the feature.
217305f to
1b3726e
Compare
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 55e2b1b53e81efa510a5bc15c6ab0398b52ace7f (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 909 | 929 | 5000 | |
| Button | mount | 563 | 549 | 5000 | |
| FluentProvider | mount | 1852 | 1884 | 5000 | |
| FluentProviderWithTheme | mount | 299 | 299 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 240 | 247 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 296 | 318 | 10 | |
| MakeStyles | mount | 1567 | 1586 | 50000 |
GeoffCoxMSFT
reviewed
May 1, 2022
|
|
||
| export const Placeholder = () => { | ||
| return <Input placeholder="input with placeholder" aria-label="input with placeholder" />; | ||
| const placeholderId = useId('input-placeholder'); |
Member
There was a problem hiding this comment.
Nit: Calling this the placeholderId makes it seem like placeholders need IDs. Consider inputId?
GeoffCoxMSFT
reviewed
May 1, 2022
| ...shorthands.borderColor(tokens.colorNeutralStroke1Hover), | ||
| borderBottomColor: tokens.colorNeutralStrokeAccessibleHover, | ||
| }, | ||
| // DO NOT add a space between the selectors! It changes the behavior of make-styles. |
Contributor
Author
There was a problem hiding this comment.
Oops! Fix incoming.
GeoffCoxMSFT
approved these changes
May 1, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…crosoft#22731) * react-input: update content before/after stories Updates the contentBefore and contentAfter stories to demonstrate these slots in an accessible way. These types of scenarios quickly become quite nuanced so the examples were chosen to be as simple as possible from an accessibility lens while still being correct and while demonstrating the feature. * react-input: update story labels * react-input: minor change from PR feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
contentBeforeandcontentAfterstories did not show how to use these slots in an accessible manner.aria-labelset.New Behavior
contentBeforeandcontentAfterdemonstrate simple examples of how to use these slots accessibly.Related Issue(s)
Fixes #21450