feat(v9): migrate card,dialog,image,text to ship rolluped only dts by Hotell · Pull Request #22708 · microsoft/fluentui

Hotell · 2022-04-29T08:50:32Z

Applied yarn workspace-generator migrate-converged-pkg to ship only rolluped type definitions for:

react-card
react-dialog
react-image
react-text

Additional features:

fixes formatting violation caused by manual rename of packages
enables running api-extractor even if --min is used ( codesandbox CI was failing and exposed this issue https://ci.codesandbox.io/status/microsoft/fluentui/pr/22708/builds/245673 )

Related Issue(s)

Fixes partially #22429

ghost · 2022-04-29T08:50:44Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

❌ Hotell sign now
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

fabricteam · 2022-04-29T09:03:03Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1096	1070	5000
Button	mount	654	660	5000
FluentProvider	mount	2234	2221	5000
FluentProviderWithTheme	mount	338	319	10
FluentProviderWithTheme	virtual-rerender	299	281	10
FluentProviderWithTheme	virtual-rerender-with-unmount	417	378	10
MakeStyles	mount	1891	1887	50000

size-auditor · 2022-04-29T09:03:50Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2af90d0c5b7c95724a01b71ab9b24d1bd5da2f6d (build)

fabricteam · 2022-04-29T09:09:26Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`priority-overflow` createOverflowManager	`2.936 kB` `1.212 kB`
`react-accordion` Accordion (including children components)	`73.754 kB` `22.494 kB`
`react-badge` Badge	`20.965 kB` `6.605 kB`
`react-badge` CounterBadge	`21.918 kB` `6.919 kB`
`react-badge` PresenceBadge	`22.005 kB` `6.582 kB`
`react-combobox` Combobox	`60.564 kB` `20.751 kB`
`react-divider` Divider	`15.455 kB` `5.57 kB`
`react-overflow` hooks only	`10.792 kB` `4.125 kB`
`react-positioning` usePopper	`23.21 kB` `8.084 kB`
`react-radio` Radio	`23.556 kB` `7.898 kB`
`react-radio` RadioGroup	`8.205 kB` `3.516 kB`
`react-spinbutton` SpinButton	`41.955 kB` `11.856 kB`
`react-spinner` Spinner	`17.292 kB` `5.865 kB`
`react-switch` Switch	`24.401 kB` `8.024 kB`
`react-textarea` Textarea	`20.672 kB` `7.07 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`31.347 kB` `7.04 kB`
`react-theme` Teams: Light theme	`19.792 kB` `5.694 kB`
`react-tooltip` Tooltip	`42.907 kB` `14.761 kB`
`react-utilities` SSRProvider	`189 B` `161 B`

_{🤖 This report was generated against 2af90d0c5b7c95724a01b71ab9b24d1bd5da2f6d}

fabricteam · 2022-04-29T09:10:40Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AvatarMinimalPerf.default	168	139	1.21:1
AccordionMinimalPerf.default	115	101	1.14:1
CarouselMinimalPerf.default	397	350	1.13:1
RadioGroupMinimalPerf.default	369	333	1.11:1
CardMinimalPerf.default	461	418	1.1:1
ListNestedPerf.default	472	429	1.1:1
ItemLayoutMinimalPerf.default	1013	932	1.09:1
TreeWith60ListItems.default	143	131	1.09:1
SkeletonMinimalPerf.default	291	270	1.08:1
HeaderSlotsPerf.default	643	602	1.07:1
MenuMinimalPerf.default	710	662	1.07:1
PortalMinimalPerf.default	147	137	1.07:1
AttachmentSlotsPerf.default	874	822	1.06:1
DropdownManyItemsPerf.default	563	531	1.06:1
ListMinimalPerf.default	423	398	1.06:1
RefMinimalPerf.default	206	195	1.06:1
PopupMinimalPerf.default	525	502	1.05:1
ButtonOverridesMissPerf.default	1160	1112	1.04:1
FlexMinimalPerf.default	247	237	1.04:1
InputMinimalPerf.default	1096	1054	1.04:1
LabelMinimalPerf.default	283	271	1.04:1
StatusMinimalPerf.default	526	505	1.04:1
IconMinimalPerf.default	475	457	1.04:1
TableMinimalPerf.default	344	330	1.04:1
LayoutMinimalPerf.default	298	289	1.03:1
ReactionMinimalPerf.default	309	301	1.03:1
SegmentMinimalPerf.default	293	285	1.03:1
SplitButtonMinimalPerf.default	3578	3478	1.03:1
TextAreaMinimalPerf.default	367	358	1.03:1
AnimationMinimalPerf.default	413	403	1.02:1
ButtonMinimalPerf.default	118	116	1.02:1
MenuButtonMinimalPerf.default	1274	1254	1.02:1
BoxMinimalPerf.default	245	243	1.01:1
LoaderMinimalPerf.default	513	509	1.01:1
DatepickerMinimalPerf.default	4657	4658	1:1
HeaderMinimalPerf.default	288	287	1:1
RosterPerf.default	873	874	1:1
ProviderMergeThemesPerf.default	1058	1061	1:1
CustomToolbarPrototype.default	2145	2145	1:1
SliderMinimalPerf.default	1390	1411	0.99:1
ProviderMinimalPerf.default	317	325	0.98:1
ChatWithPopoverPerf.default	297	305	0.97:1
DialogMinimalPerf.default	614	631	0.97:1
TreeMinimalPerf.default	598	616	0.97:1
DropdownMinimalPerf.default	2390	2496	0.96:1
EmbedMinimalPerf.default	3124	3255	0.96:1
FormMinimalPerf.default	303	315	0.96:1
VideoMinimalPerf.default	501	523	0.96:1
AlertMinimalPerf.default	195	206	0.95:1
CheckboxMinimalPerf.default	2106	2216	0.95:1
ListWith60ListItems.default	509	533	0.95:1
AttachmentMinimalPerf.default	112	121	0.93:1
DividerMinimalPerf.default	263	282	0.93:1
TableManyItemsPerf.default	1425	1538	0.93:1
TextMinimalPerf.default	255	275	0.93:1
ToolbarMinimalPerf.default	731	789	0.93:1
TooltipMinimalPerf.default	803	867	0.93:1
GridMinimalPerf.default	242	266	0.91:1
ButtonSlotsPerf.default	415	467	0.89:1
ListCommonPerf.default	475	542	0.88:1
ImageMinimalPerf.default	279	320	0.87:1
ChatDuplicateMessagesPerf.default	221	256	0.86:1
ChatMinimalPerf.default	537	628	0.86:1

fabricteam · 2022-04-29T09:17:51Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	772	778	5000
Breadcrumb	mount	2131	2318	1000
Checkbox	mount	1181	1182	5000
CheckboxBase	mount	1006	1058	5000
ChoiceGroup	mount	3750	3717	5000
ComboBox	mount	788	778	1000
CommandBar	mount	8999	8730	1000
ContextualMenu	mount	11136	10705	1000
DefaultButton	mount	957	942	5000
DetailsRow	mount	3053	3101	5000
DetailsRowFast	mount	3117	3129	5000
DetailsRowNoStyles	mount	3158	3183	5000
Dialog	mount	1876	1925	1000
DocumentCardTitle	mount	122	158	1000
Dropdown	mount	2860	2765	5000
FocusTrapZone	mount	1409	1476	5000
FocusZone	mount	1491	1495	5000
IconButton	mount	1577	1346	5000
Label	mount	316	306	5000
Layer	mount	2478	2575	5000
Link	mount	345	378	5000
MenuButton	mount	1163	1285	5000
MessageBar	mount	1808	1754	5000
Nav	mount	2924	2735	1000
OverflowSet	mount	886	958	5000
Panel	mount	1777	1860	1000
Persona	mount	820	835	1000
Pivot	mount	1367	1174	1000
PrimaryButton	mount	1193	1054	5000
Rating	mount	6215	6120	5000
SearchBox	mount	1221	1129	5000
Shimmer	mount	2017	1883	5000
Slider	mount	1714	1603	5000
SpinButton	mount	4234	4055	5000
Spinner	mount	377	386	5000
SplitButton	mount	2608	2535	5000
Stack	mount	482	421	5000
StackWithIntrinsicChildren	mount	1903	1790	5000
StackWithTextChildren	mount	4290	4337	5000
SwatchColorPicker	mount	9922	9626	5000
TagPicker	mount	2283	2389	5000
TeachingBubble	mount	98566	95886	5000
Text	mount	366	363	5000
TextField	mount	1152	1180	5000
ThemeProvider	mount	940	942	5000
ThemeProvider	virtual-rerender	496	497	5000
ThemeProvider	virtual-rerender-with-unmount	1533	1514	5000
Toggle	mount	618	698	5000
buttonNative	mount	123	101	5000

Hotell · 2022-05-02T11:43:22Z

added text (which was migrated already to react-components folder) so we have it in one go , pls check again @andrefcdias 🙏

… --min flag was used

codesandbox-ci · 2022-05-02T12:06:59Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8b9b784:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

…icrosoft#22708) * style: fix formatting issues introduced by manually renaming package * feat(v9): migrate card,dialog,image to ship rolluped only dts * generate change files * fixup! feat(v9): migrate card,dialog,image to ship rolluped only dts * fixup! generate change files * fix(scripts): make sure api-extractor always runs for v9 no matter if --min flag was used

msft-fluent-ui-bot assigned miroslavstastny Apr 29, 2022

Hotell changed the title ~~Hotell/build/migrate v9 to rolluped dts p1~~ feat(v9): migrate card,dialog,image to ship rolluped only dts Apr 29, 2022

Hotell mentioned this pull request Apr 29, 2022

ship rolluped declaration files only #22429

Closed

50 tasks

Hotell marked this pull request as ready for review April 29, 2022 11:09

Hotell requested review from a team as code owners April 29, 2022 11:09

theerebuss approved these changes Apr 29, 2022

View reviewed changes

Hotell added 5 commits May 2, 2022 13:30

style: fix formatting issues introduced by manually renaming package

dd7846f

feat(v9): migrate card,dialog,image to ship rolluped only dts

8ae7d17

generate change files

2493490

fixup! feat(v9): migrate card,dialog,image to ship rolluped only dts

3b9d29d

fixup! generate change files

c4da42f

Hotell force-pushed the hotell/build/migrate-v9-to-rolluped-dts-p1 branch from 7a689d8 to c4da42f Compare May 2, 2022 11:36

Hotell changed the title ~~feat(v9): migrate card,dialog,image to ship rolluped only dts~~ feat(v9): migrate card,dialog,image,text to ship rolluped only dts May 2, 2022

Hotell requested a review from theerebuss May 2, 2022 11:42

fix(scripts): make sure api-extractor always runs for v9 no matter if…

8b9b784

… --min flag was used

theerebuss approved these changes May 2, 2022

View reviewed changes

Hotell merged commit fd41e5b into microsoft:master May 3, 2022

Hotell deleted the hotell/build/migrate-v9-to-rolluped-dts-p1 branch May 3, 2022 13:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(v9): migrate card,dialog,image,text to ship rolluped only dts#22708

feat(v9): migrate card,dialog,image,text to ship rolluped only dts#22708
Hotell merged 6 commits intomicrosoft:masterfrom
Hotell:hotell/build/migrate-v9-to-rolluped-dts-p1

Hotell commented Apr 29, 2022 •

edited

Loading

Uh oh!

ghost commented Apr 29, 2022

Uh oh!

fabricteam commented Apr 29, 2022 •

edited

Loading

Uh oh!

size-auditor bot commented Apr 29, 2022 •

edited

Loading

Uh oh!

fabricteam commented Apr 29, 2022 •

edited

Loading

Uh oh!

fabricteam commented Apr 29, 2022 •

edited

Loading

Uh oh!

fabricteam commented Apr 29, 2022 •

edited

Loading

Uh oh!

Hotell commented May 2, 2022

Uh oh!

codesandbox-ci bot commented May 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Hotell commented Apr 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Additional features:

Related Issue(s)

Uh oh!

ghost commented Apr 29, 2022

Uh oh!

fabricteam commented Apr 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-components)

Uh oh!

size-auditor bot commented Apr 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Apr 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Apr 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react-northstar)

Uh oh!

fabricteam commented Apr 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Uh oh!

Hotell commented May 2, 2022

Uh oh!

codesandbox-ci bot commented May 2, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Hotell commented Apr 29, 2022 •

edited

Loading

fabricteam commented Apr 29, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

size-auditor bot commented Apr 29, 2022 •

edited

Loading

fabricteam commented Apr 29, 2022 •

edited

Loading

fabricteam commented Apr 29, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Apr 29, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)