chore(react-utilities): add Slot mapped type tests#22638
Merged
Hotell merged 1 commit intomicrosoft:masterfrom May 3, 2022
Merged
chore(react-utilities): add Slot mapped type tests#22638Hotell merged 1 commit intomicrosoft:masterfrom
Hotell merged 1 commit intomicrosoft:masterfrom
Conversation
Hotell
commented
Apr 26, 2022
| const noChildrenEl: ChildrenLessIntrinsicElement = { children: React.createElement('div', 'hello') }; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-ignore - FIX THE API / this doesn't work ATM and should be fixed |
Contributor
Author
|
one issue I exposed is that basically slot props cannot be required. is that expected behaviour ? |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7397104:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 350 | 286 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 907 | 919 | 5000 | |
| Button | mount | 545 | 552 | 5000 | |
| FluentProvider | mount | 1968 | 2002 | 5000 | |
| FluentProviderWithTheme | mount | 303 | 262 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 234 | 235 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 350 | 286 | 10 | Possible regression |
| MakeStyles | mount | 1572 | 1550 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e45629a0978492d5a8a44934f5263e47862ac8b3 (build) |
ling1726
approved these changes
May 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Current Behavior
Slotis non trivial mapped type without any testing coverageNew Behavior
Slothas some type check tests coverageRelated Issue(s)
This also exposes issue found in #22633