react-components: add SpinButton to /unstable#22568
Merged
spmonahan merged 3 commits intomicrosoft:masterfrom Apr 20, 2022
Merged
react-components: add SpinButton to /unstable#22568spmonahan merged 3 commits intomicrosoft:masterfrom
spmonahan merged 3 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c85bc9d:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 344 | 300 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 943 | 946 | 5000 | |
| Button | mount | 535 | 557 | 5000 | |
| FluentProvider | mount | 1843 | 1816 | 5000 | |
| FluentProviderWithTheme | mount | 344 | 300 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 235 | 242 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 350 | 323 | 10 | |
| MakeStyles | mount | 1577 | 1569 | 50000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4ed2b741e41cd71f83b0a13a8748a8154de98aee (build) |
khmakoto
approved these changes
Apr 20, 2022
Member
khmakoto
left a comment
There was a problem hiding this comment.
You should double-check in SpinButton.stories.tsx if the title in Meta is Preview Components/SpinButton and not Components/SpinButton so it is put in its correct place in storybook.
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
* react-components: add SpinButton to /unstable * react-spinbutton: remove private from package.json * react-spinbutton: move stories to Preview Components from Components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
SpinButtonis not accessible via@fluentui/react-components/unstableNew Behavior
SpinButtonis accessible via@fluentui/react-components/unstableRelated Issue(s)
Fixes #22307