Re-exporting commonly used things from @fluentui/react-tabster and @fluentui/react-utilities in @fluentui/react-components#22367
Merged
khmakoto merged 8 commits intomicrosoft:masterfrom Apr 19, 2022
Conversation
…act-utilities in @fluentui/react-components.
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 79561e901ae4ca1ab9d647b823fe4c78d2d67354 (build) |
GeoffCoxMSFT
approved these changes
Apr 6, 2022
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f2151ef:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 929 | 919 | 5000 | |
| Button | mount | 577 | 566 | 5000 | |
| FluentProvider | mount | 1928 | 1864 | 5000 | |
| FluentProviderWithTheme | mount | 300 | 306 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 227 | 253 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 318 | 297 | 10 | |
| MakeStyles | mount | 1583 | 1562 | 50000 |
73 tasks
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
reviewed
Apr 19, 2022
ling1726
approved these changes
Apr 19, 2022
marwan38
pushed a commit
to marwan38/fluentui
that referenced
this pull request
Jun 13, 2022
…luentui/react-utilities in @fluentui/react-components (microsoft#22367) * Re-exporting everything from @fluentui/react-tabster and @fluentui/react-utilities in @fluentui/react-components. * Adding change files. * Adding missing dependency. * Cutting back on the things exported by react-components. * Cutting back on more things exported by react-components. * Cutting back on more things exported by react-components. * Cutting back on more things exported by react-components.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
This PR re-exports commonly used things from
@fluentui/react-tabsterand@fluentui/react-utilitiesfrom@fluentui/react-components. We can export more things later on a need-by-need basis.We are also removing the star exports from these two packages in favor of explicit ones.