Skip to content

Add slider package to react-components#21506

Merged
micahgodbolt merged 18 commits intomicrosoft:masterfrom
micahgodbolt:release-slider
Feb 2, 2022
Merged

Add slider package to react-components#21506
micahgodbolt merged 18 commits intomicrosoft:masterfrom
micahgodbolt:release-slider

Conversation

@micahgodbolt
Copy link
Member

@micahgodbolt micahgodbolt commented Jan 31, 2022 •
edited
Loading

Slider package has passed reviews and is ready to enter the release process.

fixes #20562
fixes #18886

@micahgodbolt micahgodbolt requested review from a team as code owners January 31, 2022 18:12
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 31, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 340c635:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration
DiscreteSliderValues Material Demo Issue #18886

@micahgodbolt micahgodbolt removed this from the January Project Cycle Q1 2022 milestone Jan 31, 2022
@fabricteam
Copy link
Collaborator

fabricteam commented Jan 31, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 165.697 kB
46.873 kB
react-components
react-components: FluentProvider & webLightTheme		 32.489 kB
10.636 kB
react-slider
Slider		 22.936 kB
7.751 kB
🤖 This report was generated against f30e7585a8d2abd9db06c4076f39a779008b0eca

@size-auditor
Copy link

size-auditor bot commented Jan 31, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f30e7585a8d2abd9db06c4076f39a779008b0eca (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 31, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 953 928 5000
BaseButton mount 970 982 5000
Breadcrumb mount 2779 2809 1000
ButtonNext mount 536 559 5000
Checkbox mount 1730 1644 5000
CheckboxBase mount 1388 1368 5000
ChoiceGroup mount 5175 5129 5000
ComboBox mount 1054 1039 1000
CommandBar mount 10734 10859 1000
ContextualMenu mount 8874 8815 1000
DefaultButton mount 1215 1254 5000
DetailsRow mount 3991 3949 5000
DetailsRowFast mount 3966 3936 5000
DetailsRowNoStyles mount 3848 3697 5000
Dialog mount 2739 2718 1000
DocumentCardTitle mount 209 192 1000
Dropdown mount 3417 3438 5000
FluentProviderNext mount 2025 2054 5000
FluentProviderWithTheme mount 177 167 10
FluentProviderWithTheme virtual-rerender 122 119 10
FluentProviderWithTheme virtual-rerender-with-unmount 219 213 10
FocusTrapZone mount 1919 1941 5000
FocusZone mount 1904 1930 5000
IconButton mount 1837 1867 5000
Label mount 387 395 5000
Layer mount 3188 3141 5000
Link mount 535 540 5000
MakeStyles mount 1793 1805 50000
MenuButton mount 1584 1562 5000
MessageBar mount 2136 2119 5000
Nav mount 3487 3499 1000
OverflowSet mount 1208 1179 5000
Panel mount 2664 2666 1000
Persona mount 945 935 1000
Pivot mount 1532 1569 1000
PrimaryButton mount 1393 1392 5000
Rating mount 8027 8043 5000
SearchBox mount 1437 1411 5000
Shimmer mount 2679 2680 5000
Slider mount 2087 2063 5000
SpinButton mount 5242 5659 5000
Spinner mount 484 481 5000
SplitButton mount 3340 3383 5000
Stack mount 616 561 5000
StackWithIntrinsicChildren mount 2411 2374 5000
StackWithTextChildren mount 5531 5512 5000
SwatchColorPicker mount 11911 11876 5000
TagPicker mount 2751 2775 5000
TeachingBubble mount 13917 13909 5000
Text mount 481 491 5000
TextField mount 1511 1529 5000
ThemeProvider mount 1286 1261 5000
ThemeProvider virtual-rerender 681 722 5000
ThemeProvider virtual-rerender-with-unmount 2009 2021 5000
Toggle mount 885 924 5000
buttonNative mount 160 172 5000

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

ecraig12345
ecraig12345 reviewed Jan 31, 2022
View reviewed changes
tringakrasniqi
tringakrasniqi approved these changes Feb 1, 2022
View reviewed changes
ecraig12345
ecraig12345 reviewed Feb 2, 2022
View reviewed changes
@micahgodbolt micahgodbolt enabled auto-merge (squash) February 2, 2022 23:25
@micahgodbolt micahgodbolt requested a review from ling1726 February 2, 2022 23:26
@micahgodbolt micahgodbolt merged commit 0a22089 into microsoft:master Feb 2, 2022
@micahgodbolt micahgodbolt deleted the release-slider branch February 2, 2022 23:46
@layershifter layershifter mentioned this pull request Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@layershifter layershifter layershifter approved these changes

@GeoffCoxMSFT GeoffCoxMSFT GeoffCoxMSFT approved these changes

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345

@ling1726 ling1726 Awaiting requested review from ling1726

+1 more reviewer

@tringakrasniqi tringakrasniqi tringakrasniqi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TristanWatanabe TristanWatanabe

Labels

Component: Slider

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Project: Review and update slider control Slider Convergence

9 participants

@micahgodbolt @fabricteam @ecraig12345 @tringakrasniqi @layershifter @ling1726 @GeoffCoxMSFT @TristanWatanabe @msft-fluent-ui-bot