-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Closed
Labels
Area: ComponentsComponent: SliderFluent UI react-components (v9)Phase: 4Convergence Iterations phase 4Convergence Iterations phase 4Status: FixedFixed in some PRFixed in some PRType: Epic
Milestone
Description
Preparation:
- Started prep
- Open UI Research complete
- Comparison on v8 and v0 complete
- Gather open GitHub issues related to component
- react-slider package scaffolded
- Slider Spec authored and reviewed
- Deliverable: Reviewed component spec
Implementation
- Started impl
- Implement component
- Add storybook stories
- Using hooks
- Using makeStyles
- Respects Figma tokens (and using provider)
- Respects API principles, shorthands and slots handling
- No dependency on v0/v7
- Add tests - Conformance, Unit, and VR
- Conformance tests
- Unit tests
- VR tests
- Accessibility behavior tests
- Write README.md covering basic usage
- Write initial MIGRATION.md guide (include v8 and v0)
- Move utils to
react-utilitiespackage - Set component ownership in CODEOWNERS
- Add
RangedSlider - Add
useEventanduseCaptureand replaceon - Set the hidden input element to the primary slot
- Deliverable: Experimental component ready for partner use, component re-exported in
react-components
Future Investigation
- Investigate
restrictedValues/customStepsExample from Material - Investigate adding
tooltipVisible: booleanwithout bloating the bundle size. An implementation with the prop (with a large bundle size) can be found here (react-slider) - Adding a Tooltip to the thumb #19572 - Replace enzyme dragging tests with testing library (react-slider) - Investigate replacing Enzyme with RTL for testing dragging behavior #19977
- Add
consistent-callback-argsconformance test back to RangedSlider.test consistent-callback-args throws an error when given a value with a tuple type #19978
Validation
- Started validating
- Add and validate in UI Builder
- Add and validate in docs site
- Validate with token pipeline
- Validate in product
- Finalize migration guide
- Author codemods
- Deliverable: Preview component ready for broader/3rd party use
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area: ComponentsComponent: SliderFluent UI react-components (v9)Phase: 4Convergence Iterations phase 4Convergence Iterations phase 4Status: FixedFixed in some PRFixed in some PRType: Epic