adding an optional control property to the Persona control#215
Merged
abenems merged 16 commits intomicrosoft:masterfrom Sep 1, 2016
Merged
adding an optional control property to the Persona control#215abenems merged 16 commits intomicrosoft:masterfrom
abenems merged 16 commits intomicrosoft:masterfrom
Conversation
…t edit spuser site permissions
…t edit spuser site permissions
|
Hi @abenems, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
…t edit spuser site permissions
…t edit spuser site permissions
…t edit spuser site permissions
src/components/Persona/Persona.scss
Outdated
| .ms-Persona-tertiaryText, | ||
| .ms-Persona-optionalText { | ||
| .ms-Persona-optionalText, | ||
| .ms-PersonaAll-details { |
Member
There was a problem hiding this comment.
Please follow naming conventions. .ms-ComponentName-elementName
…t edit spuser site permissions
…t edit spuser site permissions
…t edit spuser site permissions
…t edit spuser site permissions
Member
|
Approved |
src/components/Persona/Persona.tsx
Outdated
| </div>) } | ||
| </div> | ||
| { innerControl ? ( | ||
| <div className='ms-Persona-detailsWithInnerControl'>{ innerControl }</div> |
Contributor
There was a problem hiding this comment.
We need a different className here than what you use on the root div. We cannot assume they will always use the same styles. For example, right now you mark 'ms-Persona-detailsWithInnerControl' as display:none for some scenarios, you definitely do not want the root div to be display: none in those cases...
|
|
||
| /** | ||
| * Optional control to display/update, usually the role of the user. | ||
| */ |
atneik
added a commit
that referenced
this pull request
Sep 3, 2016
* Persona: now renders children within the details, and overflow on details removed (#215) * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * adding an optional control property to the Persona control, to support edit spuser site permissions * resolve comments * resolve comments * Minor changes. * Adding @autoBind usage to a number of the components. (#233) * Updating GroupedList, Link, MarqueeSelection, Breadcrumb, Toggle, Callout * Updating autobinds for Checkbox, ColorPicker, CommandBar, ContextualMenu. * Updating SelectionZone autobinds. * Adding autobind to Utilities export. * Adding best practice notes. * Updating autobind for FocusZone. * Removing dead code. * DatePicker: Change text input validation to only call onSelectDate when text input is allowed (#230) * Fixed validation when allowTextInput is false * Fixed formatting * Update package.json * Dropdown: isDisabled is respected when the value changes. (#237) * v0.47.2 * Using react events * Fixing a minor bug in selection where isAllSelected is returning true when all items are unselectable. Added test, validated the fix works. (#240) * BaseComponent: Adding a _resolveRef helper to create memoized helpers to resolve refs. (#238) * Adding a _resolveRef helper to create memoized helpers to resolve refs. * Cleaning up tslint. * v0.47.3 * ContextualMenu: added tooltip and arialabel to menu and menu items. (#241) * v0.48.0 * Using css utility map * Use @autoBind and _resolveRef * Adding focus state * Adding isChecked state * Removing unneeded variables * ChoiceGroup using react events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.