Skip to content

react-avatar: Fix stories after #19449#20065

Merged
bsunderhus merged 2 commits intomicrosoft:masterfrom
bsunderhus:fix-avatar-stories-after-19449
Oct 4, 2021
Merged

react-avatar: Fix stories after #19449#20065
bsunderhus merged 2 commits intomicrosoft:masterfrom
bsunderhus:fix-avatar-stories-after-19449

Conversation

@bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Oct 1, 2021

Pull request checklist

Description of changes

Fix a regression after #19449.

From:

image

To:

image

@bsunderhus bsunderhus requested review from a team, behowell and khmakoto as code owners October 1, 2021 10:24
@bsunderhus bsunderhus self-assigned this Oct 1, 2021
@bsunderhus bsunderhus requested review from a team October 1, 2021 10:24
@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 1, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4301cab:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 1, 2021

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-avatar
Avatar		 56.703 kB
15.742 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 165.934 kB
47.092 kB
react-components
react-components: FluentProvider & webLightTheme		 34.361 kB
11.35 kB
🤖 This report was generated against 5e5ec29ce404c3aa1bcc76759dd86ec4b95fda5a

@size-auditor
Copy link

size-auditor bot commented Oct 1, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5e5ec29ce404c3aa1bcc76759dd86ec4b95fda5a (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 1, 2021

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
FluentProviderWithTheme virtual-rerender 98 105 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1025 1058 5000
BaseButton mount 1029 1010 5000
Breadcrumb mount 2788 2745 1000
ButtonNext mount 479 492 5000
Checkbox mount 1666 1670 5000
CheckboxBase mount 1445 1484 5000
ChoiceGroup mount 5200 5212 5000
ComboBox mount 1017 1043 1000
CommandBar mount 10719 10717 1000
ContextualMenu mount 6882 6934 1000
DefaultButton mount 1271 1253 5000
DetailsRow mount 4089 4074 5000
DetailsRowFast mount 4083 4084 5000
DetailsRowNoStyles mount 3786 3872 5000
Dialog mount 2475 2548 1000
DocumentCardTitle mount 159 168 1000
Dropdown mount 3457 3478 5000
FluentProviderNext mount 7033 7132 5000
FluentProviderWithTheme mount 346 352 10
FluentProviderWithTheme virtual-rerender 98 105 10 Possible regression
FluentProviderWithTheme virtual-rerender-with-unmount 401 410 10
FocusTrapZone mount 1875 1949 5000
FocusZone mount 1821 1851 5000
IconButton mount 1980 1926 5000
Label mount 355 360 5000
Layer mount 3243 3229 5000
Link mount 523 504 5000
MakeStyles mount 1901 1851 50000
MenuButton mount 1656 1643 5000
MessageBar mount 2113 2159 5000
Nav mount 3692 3628 1000
OverflowSet mount 1153 1183 5000
Panel mount 1445 2527 1000
Persona mount 907 900 1000
Pivot mount 1540 1538 1000
PrimaryButton mount 1456 1411 5000
Rating mount 8852 8568 5000
SearchBox mount 1534 1459 5000
Shimmer mount 2836 2853 5000
Slider mount 2122 2109 5000
SpinButton mount 5435 5499 5000
Spinner mount 463 444 5000
SplitButton mount 3431 3429 5000
Stack mount 579 541 5000
StackWithIntrinsicChildren mount 1934 1884 5000
StackWithTextChildren mount 5259 5378 5000
SwatchColorPicker mount 11365 11378 5000
Tabs mount 1560 1540 1000
TagPicker mount 2927 2888 5000
TeachingBubble mount 13414 13421 5000
Text mount 467 455 5000
TextField mount 1481 1560 5000
ThemeProvider mount 1362 1246 5000
ThemeProvider virtual-rerender 619 598 5000
ThemeProvider virtual-rerender-with-unmount 2164 2093 5000
Toggle mount 866 889 5000
buttonNative mount 119 117 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 274 239 1.15:1
RadioGroupMinimalPerf.default 547 484 1.13:1
FlexMinimalPerf.default 329 298 1.1:1
AvatarMinimalPerf.default 234 214 1.09:1
ImageMinimalPerf.default 456 422 1.08:1
BoxMinimalPerf.default 406 380 1.07:1
ListWith60ListItems.default 739 697 1.06:1
PortalMinimalPerf.default 195 184 1.06:1
IconMinimalPerf.default 736 697 1.06:1
DividerMinimalPerf.default 415 395 1.05:1
LoaderMinimalPerf.default 771 732 1.05:1
AccordionMinimalPerf.default 188 180 1.04:1
AttachmentSlotsPerf.default 1221 1170 1.04:1
ChatMinimalPerf.default 755 727 1.04:1
LabelMinimalPerf.default 441 426 1.04:1
ListMinimalPerf.default 584 561 1.04:1
PopupMinimalPerf.default 649 623 1.04:1
SegmentMinimalPerf.default 395 378 1.04:1
SkeletonMinimalPerf.default 405 390 1.04:1
ToolbarMinimalPerf.default 1079 1033 1.04:1
AnimationMinimalPerf.default 467 455 1.03:1
ChatWithPopoverPerf.default 426 415 1.03:1
MenuMinimalPerf.default 953 928 1.03:1
ReactionMinimalPerf.default 433 419 1.03:1
TreeMinimalPerf.default 884 859 1.03:1
TreeWith60ListItems.default 207 200 1.03:1
CardMinimalPerf.default 643 630 1.02:1
DropdownMinimalPerf.default 3360 3308 1.02:1
GridMinimalPerf.default 381 372 1.02:1
ButtonOverridesMissPerf.default 1948 1931 1.01:1
ButtonSlotsPerf.default 634 629 1.01:1
DatepickerMinimalPerf.default 5941 5885 1.01:1
DialogMinimalPerf.default 828 816 1.01:1
ItemLayoutMinimalPerf.default 1370 1358 1.01:1
MenuButtonMinimalPerf.default 1814 1790 1.01:1
TextAreaMinimalPerf.default 578 575 1.01:1
CustomToolbarPrototype.default 4407 4371 1.01:1
TooltipMinimalPerf.default 1138 1129 1.01:1
AttachmentMinimalPerf.default 180 180 1:1
ButtonMinimalPerf.default 202 201 1:1
ChatDuplicateMessagesPerf.default 331 332 1:1
CheckboxMinimalPerf.default 2887 2892 1:1
SliderMinimalPerf.default 1802 1804 1:1
SplitButtonMinimalPerf.default 4641 4621 1:1
TableManyItemsPerf.default 2123 2115 1:1
CarouselMinimalPerf.default 534 537 0.99:1
EmbedMinimalPerf.default 4614 4641 0.99:1
HeaderSlotsPerf.default 860 873 0.99:1
InputMinimalPerf.default 1386 1403 0.99:1
ProviderMergeThemesPerf.default 1808 1824 0.99:1
StatusMinimalPerf.default 747 758 0.99:1
AlertMinimalPerf.default 317 325 0.98:1
HeaderMinimalPerf.default 412 419 0.98:1
RosterPerf.default 1305 1335 0.98:1
TextMinimalPerf.default 391 398 0.98:1
VideoMinimalPerf.default 710 721 0.98:1
ProviderMinimalPerf.default 1232 1269 0.97:1
TableMinimalPerf.default 446 462 0.97:1
ListCommonPerf.default 699 729 0.96:1
DropdownManyItemsPerf.default 750 792 0.95:1
ListNestedPerf.default 622 655 0.95:1
FormMinimalPerf.default 470 502 0.94:1
LayoutMinimalPerf.default 404 429 0.94:1

@bsunderhus bsunderhus merged commit bb930b1 into microsoft:master Oct 4, 2021
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@bsunderhus
react-avatar: Fix stories after microsoft#19449 (microsoft#20065)
aa760fa 
* Fix Avatar stories after  microsoft#19449

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khmakoto khmakoto khmakoto approved these changes

@layershifter layershifter layershifter approved these changes

@behowell behowell Awaiting requested review from behowell

+2 more reviewers

@ling1726 ling1726 ling1726 approved these changes

@theerebuss theerebuss theerebuss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bsunderhus bsunderhus

@GeoffCoxMSFT GeoffCoxMSFT

Labels

Area: Documentation Component: Avatar

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs(Avatar): stories have wrong look

8 participants

@bsunderhus @fabricteam @khmakoto @layershifter @ling1726 @theerebuss @GeoffCoxMSFT @msft-fluent-ui-bot