fix(Popover): Remove leftover defaultProps and fix trigger props merge#19934
Merged
ling1726 merged 2 commits intomicrosoft:masterfrom Sep 23, 2021
Merged
fix(Popover): Remove leftover defaultProps and fix trigger props merge#19934ling1726 merged 2 commits intomicrosoft:masterfrom
ling1726 merged 2 commits intomicrosoft:masterfrom
Conversation
Removes lefover `defaultProps` usages from microsoft#19767 Also fixes an issue where user props can never override trigger props
layershifter
approved these changes
Sep 23, 2021
Collaborator
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ede5939:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9eaa5a108ce72f6350b572ca71e496d573cd400c (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 927 | 905 | 5000 | |
| BaseButton | mount | 922 | 897 | 5000 | |
| Breadcrumb | mount | 2681 | 2681 | 1000 | |
| ButtonNext | mount | 456 | 448 | 5000 | |
| Checkbox | mount | 1568 | 1518 | 5000 | |
| CheckboxBase | mount | 1290 | 1310 | 5000 | |
| ChoiceGroup | mount | 4827 | 4768 | 5000 | |
| ComboBox | mount | 1011 | 1003 | 1000 | |
| CommandBar | mount | 10296 | 10402 | 1000 | |
| ContextualMenu | mount | 6584 | 6714 | 1000 | |
| DefaultButton | mount | 1160 | 1136 | 5000 | |
| DetailsRow | mount | 3735 | 3702 | 5000 | |
| DetailsRowFast | mount | 3807 | 3743 | 5000 | |
| DetailsRowNoStyles | mount | 3539 | 3596 | 5000 | |
| Dialog | mount | 2485 | 2428 | 1000 | |
| DocumentCardTitle | mount | 143 | 147 | 1000 | |
| Dropdown | mount | 3231 | 3327 | 5000 | |
| FluentProviderNext | mount | 7721 | 7819 | 5000 | |
| FluentProviderWithTheme | mount | 352 | 386 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 93 | 101 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 508 | 499 | 10 | |
| FocusTrapZone | mount | 1832 | 1770 | 5000 | |
| FocusZone | mount | 1780 | 1801 | 5000 | |
| IconButton | mount | 1774 | 1765 | 5000 | |
| Label | mount | 345 | 343 | 5000 | |
| Layer | mount | 2947 | 2981 | 5000 | |
| Link | mount | 488 | 476 | 5000 | |
| MakeStyles | mount | 1853 | 1833 | 50000 | |
| MenuButton | mount | 1487 | 1458 | 5000 | |
| MessageBar | mount | 2023 | 2013 | 5000 | |
| Nav | mount | 3288 | 3298 | 1000 | |
| OverflowSet | mount | 1128 | 1127 | 5000 | |
| Panel | mount | 2434 | 2394 | 1000 | |
| Persona | mount | 858 | 839 | 1000 | |
| Pivot | mount | 1455 | 1428 | 1000 | |
| PrimaryButton | mount | 1270 | 1308 | 5000 | |
| Rating | mount | 7872 | 7719 | 5000 | |
| SearchBox | mount | 1333 | 1338 | 5000 | |
| Shimmer | mount | 2575 | 2515 | 5000 | |
| Slider | mount | 1965 | 1986 | 5000 | |
| SpinButton | mount | 5066 | 5049 | 5000 | |
| Spinner | mount | 418 | 411 | 5000 | |
| SplitButton | mount | 3239 | 3185 | 5000 | |
| Stack | mount | 497 | 500 | 5000 | |
| StackWithIntrinsicChildren | mount | 1708 | 1755 | 5000 | |
| StackWithTextChildren | mount | 4710 | 4789 | 5000 | |
| SwatchColorPicker | mount | 10531 | 10585 | 5000 | |
| Tabs | mount | 1444 | 1432 | 1000 | |
| TagPicker | mount | 2698 | 2620 | 5000 | |
| TeachingBubble | mount | 13735 | 13672 | 5000 | |
| Text | mount | 419 | 415 | 5000 | |
| TextField | mount | 1419 | 1426 | 5000 | |
| ThemeProvider | mount | 1195 | 1183 | 5000 | |
| ThemeProvider | virtual-rerender | 638 | 595 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1912 | 1980 | 5000 | |
| Toggle | mount | 803 | 840 | 5000 | |
| buttonNative | mount | 123 | 116 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 167 | 151 | 1.11:1 |
| AvatarMinimalPerf.default | 210 | 192 | 1.09:1 |
| LabelMinimalPerf.default | 409 | 383 | 1.07:1 |
| SegmentMinimalPerf.default | 359 | 336 | 1.07:1 |
| AttachmentMinimalPerf.default | 172 | 164 | 1.05:1 |
| AttachmentSlotsPerf.default | 1134 | 1080 | 1.05:1 |
| ChatWithPopoverPerf.default | 386 | 369 | 1.05:1 |
| GridMinimalPerf.default | 354 | 336 | 1.05:1 |
| ImageMinimalPerf.default | 390 | 371 | 1.05:1 |
| AlertMinimalPerf.default | 286 | 276 | 1.04:1 |
| CarouselMinimalPerf.default | 473 | 456 | 1.04:1 |
| LayoutMinimalPerf.default | 376 | 361 | 1.04:1 |
| ListWith60ListItems.default | 670 | 644 | 1.04:1 |
| RefMinimalPerf.default | 247 | 238 | 1.04:1 |
| TextMinimalPerf.default | 361 | 347 | 1.04:1 |
| TreeWith60ListItems.default | 180 | 173 | 1.04:1 |
| HeaderMinimalPerf.default | 374 | 362 | 1.03:1 |
| TableManyItemsPerf.default | 1984 | 1924 | 1.03:1 |
| ButtonMinimalPerf.default | 170 | 166 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1233 | 1204 | 1.02:1 |
| ListCommonPerf.default | 621 | 609 | 1.02:1 |
| MenuMinimalPerf.default | 872 | 851 | 1.02:1 |
| MenuButtonMinimalPerf.default | 1668 | 1639 | 1.02:1 |
| SliderMinimalPerf.default | 1762 | 1726 | 1.02:1 |
| TableMinimalPerf.default | 403 | 394 | 1.02:1 |
| CheckboxMinimalPerf.default | 2773 | 2743 | 1.01:1 |
| DatepickerMinimalPerf.default | 5594 | 5547 | 1.01:1 |
| DropdownManyItemsPerf.default | 688 | 680 | 1.01:1 |
| EmbedMinimalPerf.default | 4385 | 4336 | 1.01:1 |
| FormMinimalPerf.default | 417 | 414 | 1.01:1 |
| ListMinimalPerf.default | 521 | 517 | 1.01:1 |
| SkeletonMinimalPerf.default | 364 | 361 | 1.01:1 |
| CustomToolbarPrototype.default | 4162 | 4127 | 1.01:1 |
| VideoMinimalPerf.default | 639 | 633 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1773 | 1777 | 1:1 |
| InputMinimalPerf.default | 1331 | 1336 | 1:1 |
| ListNestedPerf.default | 559 | 557 | 1:1 |
| ProviderMinimalPerf.default | 1131 | 1128 | 1:1 |
| ReactionMinimalPerf.default | 379 | 378 | 1:1 |
| StatusMinimalPerf.default | 663 | 663 | 1:1 |
| TooltipMinimalPerf.default | 1033 | 1035 | 1:1 |
| ButtonSlotsPerf.default | 568 | 572 | 0.99:1 |
| CardMinimalPerf.default | 542 | 545 | 0.99:1 |
| DividerMinimalPerf.default | 354 | 357 | 0.99:1 |
| DropdownMinimalPerf.default | 3200 | 3234 | 0.99:1 |
| LoaderMinimalPerf.default | 702 | 709 | 0.99:1 |
| PopupMinimalPerf.default | 604 | 608 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1746 | 1756 | 0.99:1 |
| SplitButtonMinimalPerf.default | 4350 | 4372 | 0.99:1 |
| AnimationMinimalPerf.default | 422 | 432 | 0.98:1 |
| ChatMinimalPerf.default | 638 | 649 | 0.98:1 |
| DialogMinimalPerf.default | 744 | 763 | 0.98:1 |
| HeaderSlotsPerf.default | 760 | 775 | 0.98:1 |
| RosterPerf.default | 1191 | 1219 | 0.98:1 |
| RadioGroupMinimalPerf.default | 444 | 452 | 0.98:1 |
| ToolbarMinimalPerf.default | 927 | 946 | 0.98:1 |
| TreeMinimalPerf.default | 784 | 804 | 0.98:1 |
| IconMinimalPerf.default | 599 | 620 | 0.97:1 |
| TextAreaMinimalPerf.default | 498 | 515 | 0.97:1 |
| BoxMinimalPerf.default | 348 | 363 | 0.96:1 |
| FlexMinimalPerf.default | 287 | 300 | 0.96:1 |
| ChatDuplicateMessagesPerf.default | 290 | 306 | 0.95:1 |
| PortalMinimalPerf.default | 167 | 181 | 0.92:1 |
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
microsoft#19934) * fix(Popover): Remove leftover defaultProps and fix trigger props merge Removes lefover `defaultProps` usages from microsoft#19767 Also fixes an issue where user props can never override trigger props * Change files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Removes lefover
defaultPropsusages from #19767Also fixes an issue where user props can never override trigger props
Focus areas to test
(optional)