Link: Fixing issues found in a11y review#19926
Merged
khmakoto merged 3 commits intomicrosoft:masterfrom Sep 24, 2021
Merged
Conversation
10 tasks
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e94f991:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: dc356cba1b091612cb26b0527cc38665c4e95c46 (build) |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
ling1726
reviewed
Sep 23, 2021
| it('cannot be focused when rendered as an anchor and disabled has been passed to the component', () => { | ||
| const rootRef = React.createRef<HTMLAnchorElement>(); | ||
|
|
||
| wrapper = mount( |
Contributor
There was a problem hiding this comment.
please convert these test to use @testing-library/react
Member
Author
There was a problem hiding this comment.
Made a new issue to address separately here #19940
ling1726
reviewed
Sep 23, 2021
|
|
||
| // Add role="link" for disabled and disabledFocusable links. | ||
| if (disabled || disabledFocusable) { | ||
| state.root.role = role || 'link'; |
Contributor
There was a problem hiding this comment.
when the DOM element is rendered as an anchor why do we need to add the same role to the element ?
Member
Author
There was a problem hiding this comment.
In talking with @smhigley she was telling me that a Link without an href (which we drop when the Link is disabled) is semantically treated as a span, which makes setting aria-disabled: true moot when disabled or disabledFocusable are passed in. One way to give it the correct semantic meaning of a disabled Link to accessibility tools is to add role="link" when this happens.
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 948 | 952 | 5000 | |
| BaseButton | mount | 929 | 904 | 5000 | |
| Breadcrumb | mount | 2659 | 2624 | 1000 | |
| ButtonNext | mount | 494 | 429 | 5000 | |
| Checkbox | mount | 1539 | 1576 | 5000 | |
| CheckboxBase | mount | 1273 | 1313 | 5000 | |
| ChoiceGroup | mount | 4825 | 4765 | 5000 | |
| ComboBox | mount | 1067 | 954 | 1000 | |
| CommandBar | mount | 10393 | 10520 | 1000 | |
| ContextualMenu | mount | 6625 | 6654 | 1000 | |
| DefaultButton | mount | 1154 | 1158 | 5000 | |
| DetailsRow | mount | 3879 | 3843 | 5000 | |
| DetailsRowFast | mount | 3827 | 3801 | 5000 | |
| DetailsRowNoStyles | mount | 3598 | 3595 | 5000 | |
| Dialog | mount | 2476 | 2596 | 1000 | |
| DocumentCardTitle | mount | 150 | 143 | 1000 | |
| Dropdown | mount | 3253 | 3263 | 5000 | |
| FluentProviderNext | mount | 7394 | 7472 | 5000 | |
| FluentProviderWithTheme | mount | 341 | 367 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 99 | 104 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 460 | 475 | 10 | |
| FocusTrapZone | mount | 2033 | 1887 | 5000 | |
| FocusZone | mount | 1899 | 1812 | 5000 | |
| IconButton | mount | 1853 | 1763 | 5000 | |
| Label | mount | 354 | 330 | 5000 | |
| Layer | mount | 3027 | 3039 | 5000 | |
| Link | mount | 459 | 494 | 5000 | |
| MakeStyles | mount | 1842 | 1908 | 50000 | |
| MenuButton | mount | 1509 | 1498 | 5000 | |
| MessageBar | mount | 2067 | 2103 | 5000 | |
| Nav | mount | 3344 | 3311 | 1000 | |
| OverflowSet | mount | 1104 | 1110 | 5000 | |
| Panel | mount | 2395 | 2399 | 1000 | |
| Persona | mount | 876 | 830 | 1000 | |
| Pivot | mount | 1447 | 1487 | 1000 | |
| PrimaryButton | mount | 1255 | 1273 | 5000 | |
| Rating | mount | 7985 | 7897 | 5000 | |
| SearchBox | mount | 1320 | 1403 | 5000 | |
| Shimmer | mount | 2588 | 2656 | 5000 | |
| Slider | mount | 1968 | 2061 | 5000 | |
| SpinButton | mount | 5015 | 5330 | 5000 | |
| Spinner | mount | 422 | 424 | 5000 | |
| SplitButton | mount | 3224 | 3204 | 5000 | |
| Stack | mount | 501 | 510 | 5000 | |
| StackWithIntrinsicChildren | mount | 1813 | 1693 | 5000 | |
| StackWithTextChildren | mount | 4745 | 4626 | 5000 | |
| SwatchColorPicker | mount | 10716 | 10742 | 5000 | |
| Tabs | mount | 1423 | 1407 | 1000 | |
| TagPicker | mount | 2692 | 2713 | 5000 | |
| TeachingBubble | mount | 13427 | 13577 | 5000 | |
| Text | mount | 416 | 430 | 5000 | |
| TextField | mount | 1400 | 1388 | 5000 | |
| ThemeProvider | mount | 1186 | 1197 | 5000 | |
| ThemeProvider | virtual-rerender | 601 | 608 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1919 | 1967 | 5000 | |
| Toggle | mount | 848 | 828 | 5000 | |
| buttonNative | mount | 127 | 115 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 216 | 185 | 1.17:1 |
| AttachmentMinimalPerf.default | 178 | 154 | 1.16:1 |
| BoxMinimalPerf.default | 379 | 332 | 1.14:1 |
| AlertMinimalPerf.default | 302 | 267 | 1.13:1 |
| AccordionMinimalPerf.default | 168 | 152 | 1.11:1 |
| TextMinimalPerf.default | 353 | 322 | 1.1:1 |
| CarouselMinimalPerf.default | 500 | 459 | 1.09:1 |
| ListNestedPerf.default | 589 | 548 | 1.07:1 |
| VideoMinimalPerf.default | 671 | 630 | 1.07:1 |
| DropdownManyItemsPerf.default | 715 | 672 | 1.06:1 |
| LabelMinimalPerf.default | 408 | 386 | 1.06:1 |
| ChatMinimalPerf.default | 672 | 637 | 1.05:1 |
| RefMinimalPerf.default | 253 | 241 | 1.05:1 |
| CardMinimalPerf.default | 574 | 553 | 1.04:1 |
| FlexMinimalPerf.default | 296 | 284 | 1.04:1 |
| SegmentMinimalPerf.default | 353 | 340 | 1.04:1 |
| TooltipMinimalPerf.default | 1065 | 1022 | 1.04:1 |
| ButtonMinimalPerf.default | 184 | 179 | 1.03:1 |
| ButtonOverridesMissPerf.default | 1894 | 1847 | 1.03:1 |
| LoaderMinimalPerf.default | 723 | 705 | 1.03:1 |
| MenuMinimalPerf.default | 867 | 840 | 1.03:1 |
| PortalMinimalPerf.default | 184 | 179 | 1.03:1 |
| TreeMinimalPerf.default | 804 | 779 | 1.03:1 |
| DividerMinimalPerf.default | 370 | 363 | 1.02:1 |
| HeaderSlotsPerf.default | 779 | 767 | 1.02:1 |
| ImageMinimalPerf.default | 377 | 371 | 1.02:1 |
| ListMinimalPerf.default | 528 | 516 | 1.02:1 |
| PopupMinimalPerf.default | 621 | 606 | 1.02:1 |
| ButtonSlotsPerf.default | 576 | 568 | 1.01:1 |
| ChatWithPopoverPerf.default | 379 | 377 | 1.01:1 |
| InputMinimalPerf.default | 1336 | 1317 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 1253 | 1239 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1670 | 1646 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1780 | 1769 | 1.01:1 |
| ProviderMinimalPerf.default | 1160 | 1146 | 1.01:1 |
| ReactionMinimalPerf.default | 376 | 373 | 1.01:1 |
| StatusMinimalPerf.default | 686 | 678 | 1.01:1 |
| ToolbarMinimalPerf.default | 962 | 957 | 1.01:1 |
| AnimationMinimalPerf.default | 422 | 420 | 1:1 |
| ChatDuplicateMessagesPerf.default | 312 | 313 | 1:1 |
| DatepickerMinimalPerf.default | 5536 | 5549 | 1:1 |
| ListWith60ListItems.default | 657 | 660 | 1:1 |
| RadioGroupMinimalPerf.default | 454 | 454 | 1:1 |
| TextAreaMinimalPerf.default | 503 | 505 | 1:1 |
| AttachmentSlotsPerf.default | 1110 | 1119 | 0.99:1 |
| DropdownMinimalPerf.default | 3314 | 3340 | 0.99:1 |
| EmbedMinimalPerf.default | 4378 | 4431 | 0.99:1 |
| GridMinimalPerf.default | 340 | 345 | 0.99:1 |
| RosterPerf.default | 1199 | 1208 | 0.99:1 |
| SplitButtonMinimalPerf.default | 4254 | 4279 | 0.99:1 |
| TableManyItemsPerf.default | 1916 | 1938 | 0.99:1 |
| CustomToolbarPrototype.default | 4198 | 4235 | 0.99:1 |
| CheckboxMinimalPerf.default | 2737 | 2798 | 0.98:1 |
| FormMinimalPerf.default | 390 | 399 | 0.98:1 |
| SliderMinimalPerf.default | 1752 | 1788 | 0.98:1 |
| IconMinimalPerf.default | 604 | 617 | 0.98:1 |
| TreeWith60ListItems.default | 190 | 194 | 0.98:1 |
| LayoutMinimalPerf.default | 370 | 380 | 0.97:1 |
| SkeletonMinimalPerf.default | 343 | 357 | 0.96:1 |
| DialogMinimalPerf.default | 763 | 806 | 0.95:1 |
| HeaderMinimalPerf.default | 353 | 372 | 0.95:1 |
| ListCommonPerf.default | 623 | 659 | 0.95:1 |
| TableMinimalPerf.default | 386 | 408 | 0.95:1 |
ling1726
approved these changes
Sep 23, 2021
layershifter
approved these changes
Sep 24, 2021
smhigley
approved these changes
Sep 24, 2021
Contributor
smhigley
left a comment
There was a problem hiding this comment.
Just the one testing typo, otherwise looks good!
10 tasks
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
* Link: Fixing issues found in a11y review. * Change files * Fixing typo in tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR fixes a bunch of issues found as part of a manual accessibility review of the
Linkcomponent and adds/updates tests to reflect these and other behaviors.