feat(tools): add snapshot serializers and config/tests only when needed#19108
Merged
Hotell merged 1 commit intomicrosoft:masterfrom Jul 26, 2021
Merged
feat(tools): add snapshot serializers and config/tests only when needed#19108Hotell merged 1 commit intomicrosoft:masterfrom
Hotell merged 1 commit intomicrosoft:masterfrom
Conversation
8 tasks
Collaborator
📊 Bundle size report🤖 This report was generated against 17c38c14b8b57d0150341cb914fb78c8e295443c |
Hotell
commented
Jul 23, 2021
|
|
||
| it(`should add 'snapshotSerializers' to jest.config.js only when needed`, async () => { | ||
| const projectConfig = readProjectConfiguration(tree, options.name); | ||
| function removePkgDependenciesThatTriggerSnapshotSerializersAddition() { |
Contributor
Author
There was a problem hiding this comment.
default template used in setup has setup react-make-styles thus we need to remove it for this special case scenario
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a3f1267:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 17c38c14b8b57d0150341cb914fb78c8e295443c (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 877 | 881 | 5000 | |
| BaseButton | mount | 1005 | 991 | 5000 | |
| Breadcrumb | mount | 2636 | 2723 | 1000 | |
| ButtonNext | mount | 455 | 457 | 5000 | |
| Checkbox | mount | 1654 | 1668 | 5000 | |
| CheckboxBase | mount | 1385 | 1392 | 5000 | |
| ChoiceGroup | mount | 5270 | 5071 | 5000 | |
| ComboBox | mount | 1068 | 1073 | 1000 | |
| CommandBar | mount | 10379 | 10291 | 1000 | |
| ContextualMenu | mount | 6511 | 6670 | 1000 | |
| DefaultButton | mount | 1258 | 1180 | 5000 | |
| DetailsRow | mount | 4050 | 4053 | 5000 | |
| DetailsRowFast | mount | 4021 | 4144 | 5000 | |
| DetailsRowNoStyles | mount | 3902 | 3749 | 5000 | |
| Dialog | mount | 2391 | 2201 | 1000 | |
| DocumentCardTitle | mount | 160 | 152 | 1000 | |
| Dropdown | mount | 3522 | 3643 | 5000 | |
| FluentProviderNext | mount | 7139 | 7059 | 5000 | |
| FocusTrapZone | mount | 1843 | 1884 | 5000 | |
| FocusZone | mount | 1929 | 1854 | 5000 | |
| IconButton | mount | 1849 | 1867 | 5000 | |
| Label | mount | 355 | 360 | 5000 | |
| Layer | mount | 1845 | 1887 | 5000 | |
| Link | mount | 486 | 480 | 5000 | |
| MakeStyles | mount | 1833 | 1794 | 50000 | |
| MenuButton | mount | 1608 | 1555 | 5000 | |
| MessageBar | mount | 2140 | 2114 | 5000 | |
| Nav | mount | 3539 | 3610 | 1000 | |
| OverflowSet | mount | 1045 | 1115 | 5000 | |
| Panel | mount | 2176 | 2163 | 1000 | |
| Persona | mount | 896 | 874 | 1000 | |
| Pivot | mount | 1476 | 1501 | 1000 | |
| PrimaryButton | mount | 1387 | 1382 | 5000 | |
| Rating | mount | 8229 | 8570 | 5000 | |
| SearchBox | mount | 1417 | 1406 | 5000 | |
| Shimmer | mount | 2762 | 2775 | 5000 | |
| Slider | mount | 2121 | 2131 | 5000 | |
| SpinButton | mount | 5266 | 5332 | 5000 | |
| Spinner | mount | 437 | 425 | 5000 | |
| SplitButton | mount | 3419 | 3372 | 5000 | |
| Stack | mount | 534 | 542 | 5000 | |
| StackWithIntrinsicChildren | mount | 1701 | 1658 | 5000 | |
| StackWithTextChildren | mount | 5080 | 5090 | 5000 | |
| SwatchColorPicker | mount | 10837 | 10718 | 5000 | |
| Tabs | mount | 1446 | 1488 | 1000 | |
| TagPicker | mount | 2649 | 2685 | 5000 | |
| TeachingBubble | mount | 12416 | 12202 | 5000 | |
| Text | mount | 462 | 459 | 5000 | |
| TextField | mount | 1555 | 1514 | 5000 | |
| ThemeProvider | mount | 1301 | 1294 | 5000 | |
| ThemeProvider | virtual-rerender | 624 | 635 | 5000 | |
| Toggle | mount | 880 | 902 | 5000 | |
| buttonNative | mount | 120 | 134 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| BoxMinimalPerf.default | 397 | 353 | 1.12:1 |
| ChatDuplicateMessagesPerf.default | 319 | 294 | 1.09:1 |
| HeaderMinimalPerf.default | 407 | 377 | 1.08:1 |
| PortalMinimalPerf.default | 193 | 178 | 1.08:1 |
| TableMinimalPerf.default | 439 | 406 | 1.08:1 |
| ChatWithPopoverPerf.default | 413 | 387 | 1.07:1 |
| MenuMinimalPerf.default | 942 | 884 | 1.07:1 |
| DialogMinimalPerf.default | 854 | 812 | 1.05:1 |
| RosterPerf.default | 1362 | 1294 | 1.05:1 |
| VideoMinimalPerf.default | 673 | 638 | 1.05:1 |
| AccordionMinimalPerf.default | 177 | 170 | 1.04:1 |
| AnimationMinimalPerf.default | 437 | 420 | 1.04:1 |
| CarouselMinimalPerf.default | 508 | 487 | 1.04:1 |
| CheckboxMinimalPerf.default | 2954 | 2838 | 1.04:1 |
| ImageMinimalPerf.default | 426 | 408 | 1.04:1 |
| ListCommonPerf.default | 678 | 653 | 1.04:1 |
| ListNestedPerf.default | 594 | 571 | 1.04:1 |
| LoaderMinimalPerf.default | 749 | 718 | 1.04:1 |
| PopupMinimalPerf.default | 632 | 608 | 1.04:1 |
| AlertMinimalPerf.default | 301 | 292 | 1.03:1 |
| RefMinimalPerf.default | 237 | 229 | 1.03:1 |
| SliderMinimalPerf.default | 1660 | 1616 | 1.03:1 |
| TooltipMinimalPerf.default | 1123 | 1090 | 1.03:1 |
| TreeMinimalPerf.default | 879 | 850 | 1.03:1 |
| TreeWith60ListItems.default | 179 | 173 | 1.03:1 |
| AttachmentSlotsPerf.default | 1151 | 1124 | 1.02:1 |
| CardMinimalPerf.default | 612 | 600 | 1.02:1 |
| ChatMinimalPerf.default | 722 | 706 | 1.02:1 |
| InputMinimalPerf.default | 1327 | 1306 | 1.02:1 |
| LayoutMinimalPerf.default | 399 | 392 | 1.02:1 |
| ListMinimalPerf.default | 557 | 544 | 1.02:1 |
| ListWith60ListItems.default | 671 | 656 | 1.02:1 |
| ProviderMinimalPerf.default | 1087 | 1069 | 1.02:1 |
| TextMinimalPerf.default | 382 | 373 | 1.02:1 |
| ButtonMinimalPerf.default | 185 | 183 | 1.01:1 |
| ButtonSlotsPerf.default | 595 | 591 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1737 | 1716 | 1.01:1 |
| ToolbarMinimalPerf.default | 1047 | 1041 | 1.01:1 |
| DatepickerMinimalPerf.default | 5830 | 5809 | 1:1 |
| EmbedMinimalPerf.default | 4418 | 4435 | 1:1 |
| FlexMinimalPerf.default | 301 | 302 | 1:1 |
| GridMinimalPerf.default | 383 | 383 | 1:1 |
| ReactionMinimalPerf.default | 413 | 413 | 1:1 |
| IconMinimalPerf.default | 667 | 664 | 1:1 |
| TextAreaMinimalPerf.default | 556 | 558 | 1:1 |
| CustomToolbarPrototype.default | 4195 | 4205 | 1:1 |
| AvatarMinimalPerf.default | 204 | 206 | 0.99:1 |
| DividerMinimalPerf.default | 400 | 404 | 0.99:1 |
| FormMinimalPerf.default | 449 | 454 | 0.99:1 |
| HeaderSlotsPerf.default | 835 | 842 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 1312 | 1322 | 0.99:1 |
| RadioGroupMinimalPerf.default | 488 | 492 | 0.99:1 |
| SkeletonMinimalPerf.default | 380 | 383 | 0.99:1 |
| SplitButtonMinimalPerf.default | 4114 | 4163 | 0.99:1 |
| StatusMinimalPerf.default | 719 | 727 | 0.99:1 |
| TableManyItemsPerf.default | 2111 | 2129 | 0.99:1 |
| LabelMinimalPerf.default | 394 | 402 | 0.98:1 |
| AttachmentMinimalPerf.default | 170 | 176 | 0.97:1 |
| ButtonOverridesMissPerf.default | 1852 | 1900 | 0.97:1 |
| MenuButtonMinimalPerf.default | 1750 | 1807 | 0.97:1 |
| DropdownManyItemsPerf.default | 734 | 766 | 0.96:1 |
| DropdownMinimalPerf.default | 3199 | 3336 | 0.96:1 |
| SegmentMinimalPerf.default | 363 | 377 | 0.96:1 |
ling1726
approved these changes
Jul 26, 2021
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
[ ] Include a change request file using$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)