feat(tools): update migration generator with new npmIgnoreConfig updates#19097
Merged
Hotell merged 1 commit intomicrosoft:masterfrom Aug 12, 2021
Merged
Conversation
Collaborator
📊 Bundle size report🤖 This report was generated against 1706b9cd5b28d63b015f0a296059456465a1edd6 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d7b65f3:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 1706b9cd5b28d63b015f0a296059456465a1edd6 (build) |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 851 | 818 | 5000 | |
| BaseButton | mount | 852 | 842 | 5000 | |
| Breadcrumb | mount | 2501 | 2508 | 1000 | |
| ButtonNext | mount | 392 | 418 | 5000 | |
| Checkbox | mount | 1416 | 1409 | 5000 | |
| CheckboxBase | mount | 1210 | 1198 | 5000 | |
| ChoiceGroup | mount | 4445 | 4460 | 5000 | |
| ComboBox | mount | 933 | 896 | 1000 | |
| CommandBar | mount | 9744 | 9628 | 1000 | |
| ContextualMenu | mount | 5833 | 5938 | 1000 | |
| DefaultButton | mount | 1047 | 1048 | 5000 | |
| DetailsRow | mount | 3541 | 3535 | 5000 | |
| DetailsRowFast | mount | 3576 | 3480 | 5000 | |
| DetailsRowNoStyles | mount | 3346 | 3295 | 5000 | |
| Dialog | mount | 2057 | 2066 | 1000 | |
| DocumentCardTitle | mount | 138 | 144 | 1000 | |
| Dropdown | mount | 3030 | 2997 | 5000 | |
| FluentProviderNext | mount | 7087 | 7086 | 5000 | |
| FocusTrapZone | mount | 1741 | 1646 | 5000 | |
| FocusZone | mount | 1689 | 1697 | 5000 | |
| IconButton | mount | 1612 | 1608 | 5000 | |
| Label | mount | 311 | 322 | 5000 | |
| Layer | mount | 1676 | 1683 | 5000 | |
| Link | mount | 425 | 437 | 5000 | |
| MakeStyles | mount | 1730 | 1692 | 50000 | |
| MenuButton | mount | 1370 | 1368 | 5000 | |
| MessageBar | mount | 1918 | 1945 | 5000 | |
| Nav | mount | 3060 | 3068 | 1000 | |
| OverflowSet | mount | 1005 | 1007 | 5000 | |
| Panel | mount | 1954 | 1975 | 1000 | |
| Persona | mount | 774 | 783 | 1000 | |
| Pivot | mount | 1323 | 1332 | 1000 | |
| PrimaryButton | mount | 1191 | 1180 | 5000 | |
| Rating | mount | 7168 | 7211 | 5000 | |
| SearchBox | mount | 1214 | 1211 | 5000 | |
| Shimmer | mount | 2343 | 2401 | 5000 | |
| Slider | mount | 1856 | 1865 | 5000 | |
| SpinButton | mount | 4859 | 4767 | 5000 | |
| Spinner | mount | 406 | 400 | 5000 | |
| SplitButton | mount | 3025 | 2999 | 5000 | |
| Stack | mount | 484 | 487 | 5000 | |
| StackWithIntrinsicChildren | mount | 1445 | 1449 | 5000 | |
| StackWithTextChildren | mount | 4214 | 4348 | 5000 | |
| SwatchColorPicker | mount | 9573 | 9622 | 5000 | |
| Tabs | mount | 1329 | 1313 | 1000 | |
| TagPicker | mount | 2474 | 2397 | 5000 | |
| TeachingBubble | mount | 11226 | 11379 | 5000 | |
| Text | mount | 384 | 388 | 5000 | |
| TextField | mount | 1284 | 1291 | 5000 | |
| ThemeProvider | mount | 1105 | 1114 | 5000 | |
| ThemeProvider | virtual-rerender | 563 | 568 | 5000 | |
| Toggle | mount | 742 | 746 | 5000 | |
| buttonNative | mount | 101 | 102 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| RefMinimalPerf.default | 234 | 217 | 1.08:1 |
| TreeWith60ListItems.default | 161 | 149 | 1.08:1 |
| SegmentMinimalPerf.default | 327 | 307 | 1.07:1 |
| FlexMinimalPerf.default | 266 | 251 | 1.06:1 |
| ImageMinimalPerf.default | 355 | 336 | 1.06:1 |
| IconMinimalPerf.default | 595 | 568 | 1.05:1 |
| TextMinimalPerf.default | 330 | 314 | 1.05:1 |
| TextAreaMinimalPerf.default | 466 | 444 | 1.05:1 |
| AvatarMinimalPerf.default | 187 | 180 | 1.04:1 |
| VideoMinimalPerf.default | 565 | 543 | 1.04:1 |
| DatepickerMinimalPerf.default | 5158 | 5016 | 1.03:1 |
| DropdownMinimalPerf.default | 2957 | 2872 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 1128 | 1094 | 1.03:1 |
| LoaderMinimalPerf.default | 654 | 634 | 1.03:1 |
| PortalMinimalPerf.default | 163 | 158 | 1.03:1 |
| ReactionMinimalPerf.default | 348 | 337 | 1.03:1 |
| SkeletonMinimalPerf.default | 330 | 320 | 1.03:1 |
| ButtonMinimalPerf.default | 160 | 157 | 1.02:1 |
| CardMinimalPerf.default | 507 | 499 | 1.02:1 |
| DropdownManyItemsPerf.default | 646 | 631 | 1.02:1 |
| HeaderMinimalPerf.default | 335 | 327 | 1.02:1 |
| LayoutMinimalPerf.default | 338 | 333 | 1.02:1 |
| ListCommonPerf.default | 584 | 571 | 1.02:1 |
| ListMinimalPerf.default | 485 | 477 | 1.02:1 |
| PopupMinimalPerf.default | 563 | 553 | 1.02:1 |
| ProviderMinimalPerf.default | 920 | 906 | 1.02:1 |
| TableManyItemsPerf.default | 1798 | 1763 | 1.02:1 |
| TreeMinimalPerf.default | 751 | 736 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 274 | 270 | 1.01:1 |
| CheckboxMinimalPerf.default | 2592 | 2566 | 1.01:1 |
| DividerMinimalPerf.default | 330 | 327 | 1.01:1 |
| RadioGroupMinimalPerf.default | 408 | 402 | 1.01:1 |
| StatusMinimalPerf.default | 639 | 633 | 1.01:1 |
| TooltipMinimalPerf.default | 943 | 934 | 1.01:1 |
| AnimationMinimalPerf.default | 381 | 380 | 1:1 |
| ButtonOverridesMissPerf.default | 1578 | 1573 | 1:1 |
| CarouselMinimalPerf.default | 433 | 432 | 1:1 |
| EmbedMinimalPerf.default | 3862 | 3845 | 1:1 |
| InputMinimalPerf.default | 1184 | 1179 | 1:1 |
| LabelMinimalPerf.default | 353 | 354 | 1:1 |
| MenuButtonMinimalPerf.default | 1523 | 1528 | 1:1 |
| CustomToolbarPrototype.default | 3620 | 3610 | 1:1 |
| ToolbarMinimalPerf.default | 862 | 861 | 1:1 |
| AccordionMinimalPerf.default | 146 | 148 | 0.99:1 |
| AttachmentMinimalPerf.default | 143 | 144 | 0.99:1 |
| AttachmentSlotsPerf.default | 971 | 981 | 0.99:1 |
| BoxMinimalPerf.default | 312 | 315 | 0.99:1 |
| ChatMinimalPerf.default | 595 | 599 | 0.99:1 |
| ChatWithPopoverPerf.default | 338 | 340 | 0.99:1 |
| DialogMinimalPerf.default | 693 | 699 | 0.99:1 |
| HeaderSlotsPerf.default | 686 | 693 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1564 | 1578 | 0.99:1 |
| SplitButtonMinimalPerf.default | 3541 | 3561 | 0.99:1 |
| TableMinimalPerf.default | 357 | 362 | 0.99:1 |
| AlertMinimalPerf.default | 251 | 255 | 0.98:1 |
| ButtonSlotsPerf.default | 490 | 500 | 0.98:1 |
| GridMinimalPerf.default | 301 | 306 | 0.98:1 |
| ListNestedPerf.default | 506 | 518 | 0.98:1 |
| MenuMinimalPerf.default | 774 | 788 | 0.98:1 |
| SliderMinimalPerf.default | 1466 | 1501 | 0.98:1 |
| ListWith60ListItems.default | 571 | 591 | 0.97:1 |
| RosterPerf.default | 1050 | 1095 | 0.96:1 |
| FormMinimalPerf.default | 347 | 372 | 0.93:1 |
8 tasks
layershifter
reviewed
Aug 3, 2021
| *.test.* | ||
| *.spec.* | ||
| *.stories.* | ||
| *.api.json |
Member
There was a problem hiding this comment.
CHANGELOG.* files will be still shipped, right? Is it expected?
Contributor
Author
There was a problem hiding this comment.
ofc, that's one of few defaults that should be always shipped (Changelog,Licencse,Readme)
- also if
filesare used those afformentioned files are alwyas shipped by npm no matter what (files was not the right way to go with - described in RFC )
layershifter
approved these changes
Aug 3, 2021
theerebuss
approved these changes
Aug 3, 2021
Contributor
theerebuss
left a comment
There was a problem hiding this comment.
Only nit I have is that I would change all references related to .npmignore to npmIgnoreConfig to avoid confusion. Apart from that, LGTM, good work as always 🎉
Contributor
Author
excellent idea. applied. thx! |
d65f7ff to
d7b65f3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
[ ] Include a change request file using$ yarn changeDescription of changes
Focus areas to test
(optional)