Skip to content

docs(rfcs): create packaging for npm registry#19066

Merged
Hotell merged 3 commits intomicrosoft:masterfrom
Hotell:hotell/rfc/shipping-only-implementation-to-npm
Aug 3, 2021
Merged

docs(rfcs): create packaging for npm registry#19066
Hotell merged 3 commits intomicrosoft:masterfrom
Hotell:hotell/rfc/shipping-only-implementation-to-npm

Conversation

@Hotell
Copy link
Contributor

@Hotell Hotell commented Jul 22, 2021 •
edited
Loading

Pull request checklist

  • [ ] Addresses an existing issue
  • [ ] Include a change request file using $ yarn change

Description of changes

Focus areas to test

(optional)

@Hotell Hotell added the Type: RFC Request for Feedback label Jul 22, 2021
@Hotell Hotell added this to the July Project Cycle Q2 2021 milestone Jul 22, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 22, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 96f25ac:

Sandbox Source
Fluent UI React Starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jul 22, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 31f949a20e204a266fc3849b128ea0be083c1dda (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 22, 2021 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)		 78.506 kB
23.21 kB
react-avatar
Avatar		 54.242 kB
14.662 kB
react-badge
Badge		 24.343 kB
7.165 kB
react-badge
CounterBadge		 27.156 kB
7.851 kB
react-badge
PresenseBadge		 237 B
177 B
react-button
Button		 24.934 kB
8.001 kB
react-button
CompoundButton		 30.226 kB
8.878 kB
react-button
MenuButton		 26.521 kB
8.509 kB
react-button
ToggleButton		 34.531 kB
8.637 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 179.799 kB
50.935 kB
react-components
react-components: FluentProvider & webLightTheme		 36.237 kB
11.596 kB
react-divider
Divider		 15.889 kB
5.747 kB
react-image
Image		 10.642 kB
4.264 kB
react-label
Label		 9.397 kB
3.839 kB
react-link
Link		 14.715 kB
6.012 kB
react-make-styles
makeStaticStyles (runtime)		 7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)		 22.135 kB
8.356 kB
react-make-styles
makeStyles + mergeClasses (build time)		 2.557 kB
1.202 kB
react-menu
Menu (including children components)		 114.61 kB
34.554 kB
react-menu
Menu (including selectable components)		 116.71 kB
34.824 kB
react-popover
Popover		 124.181 kB
36.121 kB
react-portal
Portal		 7.78 kB
2.672 kB
react-positioning
usePopper		 23.157 kB
7.942 kB
react-provider
FluentProvider		 16.235 kB
5.972 kB
react-theme
Teams: all themes		 32.941 kB
6.674 kB
react-theme
Teams: Light theme		 20.247 kB
5.662 kB
react-tooltip
Tooltip		 45.281 kB
15.45 kB
react-utilities
SSRProvider		 213 B
170 B
🤖 This report was generated against 31f949a20e204a266fc3849b128ea0be083c1dda

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 22, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 795 842 5000
BaseButton mount 973 1041 5000
Breadcrumb mount 2701 2677 1000
ButtonNext mount 471 477 5000
Checkbox mount 1654 1649 5000
CheckboxBase mount 1449 1492 5000
ChoiceGroup mount 5164 5188 5000
ComboBox mount 1028 1027 1000
CommandBar mount 10439 10448 1000
ContextualMenu mount 6408 6323 1000
DefaultButton mount 1217 1223 5000
DetailsRow mount 3902 3989 5000
DetailsRowFast mount 3970 3930 5000
DetailsRowNoStyles mount 3786 3905 5000
Dialog mount 2229 2237 1000
DocumentCardTitle mount 163 157 1000
Dropdown mount 3398 3449 5000
FluentProviderNext mount 7178 7051 5000
FocusTrapZone mount 1888 1899 5000
FocusZone mount 1889 1913 5000
IconButton mount 1929 1909 5000
Label mount 363 361 5000
Layer mount 1982 1948 5000
Link mount 477 479 5000
MakeStyles mount 1833 1817 50000
MenuButton mount 1559 1573 5000
MessageBar mount 2061 2114 5000
Nav mount 3476 3621 1000
OverflowSet mount 1060 1082 5000
Panel mount 2126 2145 1000
Persona mount 912 869 1000
Pivot mount 1453 1476 1000
PrimaryButton mount 1341 1356 5000
Rating mount 8468 8223 5000
SearchBox mount 1440 1487 5000
Shimmer mount 2804 2894 5000
Slider mount 2081 2089 5000
SpinButton mount 5361 5231 5000
Spinner mount 435 428 5000
SplitButton mount 3421 3383 5000
Stack mount 535 522 5000
StackWithIntrinsicChildren mount 1715 1725 5000
StackWithTextChildren mount 5059 5094 5000
SwatchColorPicker mount 11073 10901 5000
Tabs mount 1486 1481 1000
TagPicker mount 2820 3044 5000
TeachingBubble mount 12515 12460 5000
Text mount 462 433 5000
TextField mount 1474 1497 5000
ThemeProvider mount 1236 1206 5000
ThemeProvider virtual-rerender 625 613 5000
Toggle mount 958 846 5000
buttonNative mount 110 109 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ButtonMinimalPerf.default 197 178 1.11:1
CarouselMinimalPerf.default 549 501 1.1:1
PortalMinimalPerf.default 187 170 1.1:1
FormMinimalPerf.default 521 476 1.09:1
ButtonSlotsPerf.default 622 584 1.07:1
AccordionMinimalPerf.default 172 163 1.06:1
BoxMinimalPerf.default 377 356 1.06:1
DropdownManyItemsPerf.default 771 725 1.06:1
FlexMinimalPerf.default 352 332 1.06:1
ListMinimalPerf.default 566 532 1.06:1
TooltipMinimalPerf.default 1113 1054 1.06:1
AlertMinimalPerf.default 311 296 1.05:1
ListNestedPerf.default 610 581 1.05:1
ChatMinimalPerf.default 717 688 1.04:1
HeaderSlotsPerf.default 868 837 1.04:1
PopupMinimalPerf.default 636 612 1.04:1
SplitButtonMinimalPerf.default 4285 4125 1.04:1
TableManyItemsPerf.default 2174 2098 1.04:1
TableMinimalPerf.default 447 428 1.04:1
TextMinimalPerf.default 381 365 1.04:1
TreeWith60ListItems.default 194 187 1.04:1
AttachmentMinimalPerf.default 180 174 1.03:1
ItemLayoutMinimalPerf.default 1337 1293 1.03:1
ListWith60ListItems.default 703 682 1.03:1
RadioGroupMinimalPerf.default 514 500 1.03:1
ReactionMinimalPerf.default 416 403 1.03:1
ToolbarMinimalPerf.default 1045 1015 1.03:1
TreeMinimalPerf.default 853 832 1.03:1
DatepickerMinimalPerf.default 5818 5679 1.02:1
LayoutMinimalPerf.default 412 402 1.02:1
SegmentMinimalPerf.default 381 374 1.02:1
TextAreaMinimalPerf.default 567 558 1.02:1
CustomToolbarPrototype.default 4094 4001 1.02:1
DialogMinimalPerf.default 802 791 1.01:1
DividerMinimalPerf.default 392 387 1.01:1
InputMinimalPerf.default 1350 1341 1.01:1
MenuButtonMinimalPerf.default 1758 1747 1.01:1
RosterPerf.default 1288 1273 1.01:1
RefMinimalPerf.default 233 230 1.01:1
AttachmentSlotsPerf.default 1144 1146 1:1
ButtonOverridesMissPerf.default 1760 1756 1:1
ChatDuplicateMessagesPerf.default 325 325 1:1
CheckboxMinimalPerf.default 2884 2875 1:1
LabelMinimalPerf.default 420 420 1:1
ListCommonPerf.default 690 687 1:1
ProviderMergeThemesPerf.default 1675 1681 1:1
SliderMinimalPerf.default 1706 1713 1:1
IconMinimalPerf.default 682 684 1:1
AnimationMinimalPerf.default 446 450 0.99:1
AvatarMinimalPerf.default 211 213 0.99:1
DropdownMinimalPerf.default 3138 3179 0.99:1
EmbedMinimalPerf.default 4328 4373 0.99:1
GridMinimalPerf.default 368 371 0.99:1
ImageMinimalPerf.default 420 425 0.99:1
ProviderMinimalPerf.default 1065 1073 0.99:1
CardMinimalPerf.default 654 666 0.98:1
ChatWithPopoverPerf.default 413 421 0.98:1
StatusMinimalPerf.default 751 764 0.98:1
LoaderMinimalPerf.default 710 732 0.97:1
MenuMinimalPerf.default 868 891 0.97:1
SkeletonMinimalPerf.default 376 391 0.96:1
VideoMinimalPerf.default 653 679 0.96:1
HeaderMinimalPerf.default 384 403 0.95:1

@Hotell
Copy link
Contributor Author

Hotell commented Jul 22, 2021 •
edited
Loading

TODO

  • explicitly state this is for vNext

@Hotell Hotell marked this pull request as ready for review July 22, 2021 15:45
ecraig12345
ecraig12345 approved these changes Jul 22, 2021
View reviewed changes
Copy link
Member

@ecraig12345 ecraig12345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once there's the clarification that this is specifically about converged (v8 packages/npmignores could probably use cleanup too, but that has some separate considerations)

@Hotell
Copy link
Contributor Author

Hotell commented Jul 23, 2021

LGTM once there's the clarification that this is specifically about converged (v8 packages/npmignores could probably use cleanup too, but that has some separate considerations)

done 7e5cbf0

@Hotell Hotell requested a review from ling1726 July 23, 2021 08:55
This was referenced Jul 23, 2021
Merged
Closed
layershifter
layershifter approved these changes Aug 3, 2021
View reviewed changes
@Hotell @layershifter
docs: Update rfcs/build-system/03-packaging-for-npm.md
96f25ac 
Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com>
@Hotell Hotell enabled auto-merge (squash) August 3, 2021 14:36
@Hotell Hotell merged commit 5948c4e into microsoft:master Aug 3, 2021
@ecraig12345 ecraig12345 mentioned this pull request Aug 18, 2021
Merged
2 tasks
@theerebuss theerebuss mentioned this pull request Sep 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecraig12345 ecraig12345 ecraig12345 approved these changes

@layershifter layershifter layershifter approved these changes

@ling1726 ling1726 Awaiting requested review from ling1726

Assignees

No one assigned

Labels

Area: Build System Type: RFC Request for Feedback

Projects

None yet

Milestone

August Project Cycle Q3 2021

Development

Successfully merging this pull request may close these issues.

4 participants

@Hotell @fabricteam @ecraig12345 @layershifter