chore(react-shared-contexts): migrate to new DX by layershifter · Pull Request #18998 · microsoft/fluentui

layershifter · 2021-07-19T13:24:14Z

Pull request checklist

Addresses an existing issue: related to migration: migrate converged packages to new DX (1st stage) #18579
Include a change request file using $ yarn change

Description of changes

This PR migrates @fluentui/react-shared-contexts to new DX.

Applied changes:

./jest.config.js remove snapshotSerializers (this package doesn't use makeStyles)
removed ./.storybook and scripts from ./package.json (there are no stories for this package and should not be)
cleaned up ./tsconfig.json#compilerOptions.types (remove inline-style-expand & storybook-addons)

codesandbox-ci · 2021-07-19T13:30:51Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ce210b6:

Sandbox	Source
Fluent UI React Starter	Configuration

size-auditor · 2021-07-19T13:35:44Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 728c68901b887fa908e2f611c20fc1c9f1b90699 (build)

fabricteam · 2021-07-19T13:39:28Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`react-divider` Divider	`15.889 kB` `5.747 kB`
`react-image` Image	`10.642 kB` `4.264 kB`
`react-make-styles` makeStaticStyles (runtime)	`7.59 kB` `3.321 kB`
`react-make-styles` makeStyles + mergeClasses (runtime)	`22.135 kB` `8.356 kB`
`react-make-styles` makeStyles + mergeClasses (build time)	`2.557 kB` `1.202 kB`
`react-menu` Menu - Default	`113.947 kB` `34.389 kB`
`react-menu` Menu - Selectable	`115.959 kB` `34.649 kB`
`react-popover` Popover	`140.938 kB` `41.968 kB`
`react-theme` Teams: all themes	`31.935 kB` `6.49 kB`
`react-theme` Teams: Light theme	`19.527 kB` `5.504 kB`

_{🤖 This report was generated against 728c68901b887fa908e2f611c20fc1c9f1b90699}

fabricteam · 2021-07-19T13:49:21Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	790	799	5000
BaseButton	mount	853	886	5000
Breadcrumb	mount	2571	2559	1000
ButtonNext	mount	512	500	5000
Checkbox	mount	1460	1466	5000
CheckboxBase	mount	1226	1224	5000
ChoiceGroup	mount	4503	4565	5000
ComboBox	mount	940	972	1000
CommandBar	mount	9846	9842	1000
ContextualMenu	mount	6200	6043	1000
DefaultButton	mount	1085	1087	5000
DetailsRow	mount	3657	3626	5000
DetailsRowFast	mount	3598	3644	5000
DetailsRowNoStyles	mount	3364	3567	5000
Dialog	mount	2059	2064	1000
DocumentCardTitle	mount	134	141	1000
Dropdown	mount	3078	3090	5000
FluentProviderNext	mount	7046	7023	5000
FocusTrapZone	mount	1761	1726	5000
FocusZone	mount	1720	1760	5000
IconButton	mount	1657	1685	5000
Label	mount	319	323	5000
Layer	mount	1703	1712	5000
Link	mount	441	444	5000
MakeStyles	mount	1774	1791	50000
MenuButton	mount	1430	1403	5000
MessageBar	mount	1935	2011	5000
Nav	mount	3149	3148	1000
OverflowSet	mount	993	998	5000
Panel	mount	2024	2027	1000
Persona	mount	828	785	1000
Pivot	mount	1400	1372	1000
PrimaryButton	mount	1259	1270	5000
Rating	mount	7389	7461	5000
SearchBox	mount	1252	1286	5000
Shimmer	mount	2463	2455	5000
Slider	mount	1878	1893	5000
SpinButton	mount	4965	5058	5000
Spinner	mount	400	398	5000
SplitButton	mount	3042	3039	5000
Stack	mount	478	487	5000
StackWithIntrinsicChildren	mount	1524	1490	5000
StackWithTextChildren	mount	4386	4318	5000
SwatchColorPicker	mount	9960	9877	5000
Tabs	mount	1341	1330	1000
TagPicker	mount	2345	2335	5000
TeachingBubble	mount	11689	11477	5000
Text	mount	406	397	5000
TextField	mount	1350	1316	5000
ThemeProvider	mount	1139	1172	5000
ThemeProvider	virtual-rerender	584	584	5000
Toggle	mount	780	784	5000
buttonNative	mount	116	103	5000

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AttachmentMinimalPerf.default	151	141	1.07:1
LabelMinimalPerf.default	386	362	1.07:1
ListWith60ListItems.default	637	597	1.07:1
ChatWithPopoverPerf.default	370	351	1.05:1
GridMinimalPerf.default	326	311	1.05:1
AvatarMinimalPerf.default	190	183	1.04:1
ChatDuplicateMessagesPerf.default	290	280	1.04:1
LoaderMinimalPerf.default	684	660	1.04:1
PopupMinimalPerf.default	576	556	1.04:1
SliderMinimalPerf.default	1623	1560	1.04:1
AnimationMinimalPerf.default	400	388	1.03:1
InputMinimalPerf.default	1254	1214	1.03:1
MenuMinimalPerf.default	829	807	1.03:1
AttachmentSlotsPerf.default	1029	1004	1.02:1
CheckboxMinimalPerf.default	2706	2645	1.02:1
ListCommonPerf.default	612	600	1.02:1
ProviderMinimalPerf.default	971	955	1.02:1
ReactionMinimalPerf.default	365	358	1.02:1
SegmentMinimalPerf.default	338	332	1.02:1
IconMinimalPerf.default	597	586	1.02:1
ToolbarMinimalPerf.default	908	893	1.02:1
TooltipMinimalPerf.default	983	961	1.02:1
ButtonOverridesMissPerf.default	1692	1678	1.01:1
ChatMinimalPerf.default	634	626	1.01:1
ImageMinimalPerf.default	345	340	1.01:1
ItemLayoutMinimalPerf.default	1185	1173	1.01:1
ListNestedPerf.default	535	528	1.01:1
MenuButtonMinimalPerf.default	1587	1564	1.01:1
ProviderMergeThemesPerf.default	1660	1644	1.01:1
RadioGroupMinimalPerf.default	433	429	1.01:1
SkeletonMinimalPerf.default	347	345	1.01:1
TreeMinimalPerf.default	758	749	1.01:1
CardMinimalPerf.default	534	534	1:1
DividerMinimalPerf.default	344	343	1:1
HeaderMinimalPerf.default	348	348	1:1
ListMinimalPerf.default	495	495	1:1
TextMinimalPerf.default	332	332	1:1
TextAreaMinimalPerf.default	473	473	1:1
CustomToolbarPrototype.default	3744	3733	1:1
DatepickerMinimalPerf.default	5204	5260	0.99:1
DropdownManyItemsPerf.default	637	644	0.99:1
DropdownMinimalPerf.default	2998	3023	0.99:1
FormMinimalPerf.default	386	389	0.99:1
HeaderSlotsPerf.default	746	752	0.99:1
LayoutMinimalPerf.default	357	361	0.99:1
SplitButtonMinimalPerf.default	3675	3711	0.99:1
TableManyItemsPerf.default	1805	1817	0.99:1
BoxMinimalPerf.default	326	333	0.98:1
ButtonMinimalPerf.default	156	160	0.98:1
DialogMinimalPerf.default	725	737	0.98:1
FlexMinimalPerf.default	280	285	0.98:1
RefMinimalPerf.default	227	232	0.98:1
TableMinimalPerf.default	378	386	0.98:1
AccordionMinimalPerf.default	146	150	0.97:1
StatusMinimalPerf.default	638	656	0.97:1
ButtonSlotsPerf.default	529	549	0.96:1
CarouselMinimalPerf.default	439	459	0.96:1
EmbedMinimalPerf.default	3977	4125	0.96:1
VideoMinimalPerf.default	578	603	0.96:1
PortalMinimalPerf.default	165	173	0.95:1
AlertMinimalPerf.default	246	264	0.93:1
RosterPerf.default	1082	1162	0.93:1
TreeWith60ListItems.default	147	170	0.86:1

…hore/rsc-new-dx

Hotell

🙌

msft-fluent-ui-bot · 2021-07-20T22:25:59Z

🎉@fluentui/react-menu@v9.0.0-alpha.52 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-07-20T22:26:02Z

🎉@fluentui/react-link@v9.0.0-alpha.60 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-07-20T22:26:05Z

🎉@fluentui/react-image@v9.0.0-alpha.57 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-07-20T22:26:17Z

🎉@fluentui/react-divider@v9.0.0-alpha.47 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-07-20T22:26:38Z

🎉@fluentui/react-badge@v9.0.0-alpha.59 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-07-20T22:26:44Z

🎉@fluentui/react-avatar@v9.0.0-alpha.58 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-07-20T22:26:50Z

🎉@fluentui/react-accordion@v9.0.0-alpha.54 has been released which incorporates this pull request.:tada:

Handy links:

* chore(react-shared-contexts): migrate to new DX * Change files

layershifter added 2 commits July 19, 2021 15:19

chore(react-shared-contexts): migrate to new DX

4640724

Change files

40443e9

msft-fluent-ui-bot assigned ling1726 Jul 19, 2021

ling1726 approved these changes Jul 19, 2021

View reviewed changes

layershifter mentioned this pull request Jul 19, 2021

migration: migrate converged packages to new DX (1st stage) #18579

Closed

32 tasks

Merge branch 'master' of https://github.com/microsoft/fluentui into c…

ce210b6

…hore/rsc-new-dx

layershifter requested review from a team as code owners July 19, 2021 14:22

layershifter requested a review from ling1726 July 19, 2021 14:29

Hotell approved these changes Jul 19, 2021

View reviewed changes

layershifter merged commit eb109ce into master Jul 19, 2021

layershifter deleted the chore/rsc-new-dx branch July 19, 2021 15:36

PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021

chore(react-shared-contexts): migrate to new DX (microsoft#18998)

b771790

* chore(react-shared-contexts): migrate to new DX * Change files

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(react-shared-contexts): migrate to new DX#18998

chore(react-shared-contexts): migrate to new DX#18998
layershifter merged 3 commits intomasterfrom
chore/rsc-new-dx

layershifter commented Jul 19, 2021

Uh oh!

codesandbox-ci bot commented Jul 19, 2021 •

edited

Loading

Uh oh!

size-auditor bot commented Jul 19, 2021 •

edited

Loading

Uh oh!

fabricteam commented Jul 19, 2021 •

edited

Loading

Uh oh!

fabricteam commented Jul 19, 2021 •

edited

Loading

Uh oh!

Hotell left a comment

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

layershifter commented Jul 19, 2021

Pull request checklist

Description of changes

Uh oh!

codesandbox-ci bot commented Jul 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor bot commented Jul 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Jul 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Bundle size report

Uh oh!

fabricteam commented Jul 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis (@fluentui/react)

Perf Analysis (@fluentui/react-northstar)

Uh oh!

Hotell left a comment

Choose a reason for hiding this comment

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

msft-fluent-ui-bot commented Jul 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codesandbox-ci bot commented Jul 19, 2021 •

edited

Loading

size-auditor bot commented Jul 19, 2021 •

edited

Loading

fabricteam commented Jul 19, 2021 •

edited

Loading

fabricteam commented Jul 19, 2021 •

edited

Loading

Perf Analysis (`@fluentui/react`)

Perf Analysis (`@fluentui/react-northstar`)