Merged
Conversation
Asset size changes
Baseline commit: 7fc7904f27cf5c679b7c9d53e3293fbaa83ff49e (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3f2ecfe:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 919 | 886 | 5000 | |
| BaseButton | mount | 884 | 905 | 5000 | |
| Breadcrumb | mount | 2717 | 2616 | 1000 | |
| ButtonNext | mount | 539 | 533 | 5000 | |
| Checkbox | mount | 1529 | 1545 | 5000 | |
| CheckboxBase | mount | 1255 | 1277 | 5000 | |
| ChoiceGroup | mount | 4671 | 4643 | 5000 | |
| ComboBox | mount | 984 | 952 | 1000 | |
| CommandBar | mount | 10123 | 9883 | 1000 | |
| ContextualMenu | mount | 6031 | 6098 | 1000 | |
| DefaultButton | mount | 1121 | 1154 | 5000 | |
| DetailsRow | mount | 3743 | 3728 | 5000 | |
| DetailsRowFast | mount | 3584 | 3690 | 5000 | |
| DetailsRowNoStyles | mount | 3393 | 3503 | 5000 | |
| Dialog | mount | 1408 | 1423 | 1000 | |
| DocumentCardTitle | mount | 140 | 135 | 1000 | |
| Dropdown | mount | 3222 | 3176 | 5000 | |
| FocusTrapZone | mount | 1827 | 1795 | 5000 | |
| FocusZone | mount | 1801 | 1808 | 5000 | |
| IconButton | mount | 1669 | 1679 | 5000 | |
| Label | mount | 333 | 325 | 5000 | |
| Layer | mount | 1727 | 1742 | 5000 | |
| Link | mount | 458 | 464 | 5000 | |
| MakeStyles | mount | 1858 | 1866 | 50000 | |
| MenuButton | mount | 1437 | 1423 | 5000 | |
| MessageBar | mount | 1995 | 2043 | 5000 | |
| Nav | mount | 3223 | 3284 | 1000 | |
| OverflowSet | mount | 1068 | 1052 | 5000 | |
| Panel | mount | 1399 | 1396 | 1000 | |
| Persona | mount | 822 | 789 | 1000 | |
| Pivot | mount | 1416 | 1387 | 1000 | |
| PrimaryButton | mount | 1265 | 1252 | 5000 | |
| Rating | mount | 7362 | 7404 | 5000 | |
| SearchBox | mount | 1272 | 1313 | 5000 | |
| Shimmer | mount | 2509 | 2474 | 5000 | |
| Slider | mount | 1909 | 2084 | 5000 | |
| SpinButton | mount | 4977 | 5029 | 5000 | |
| Spinner | mount | 424 | 418 | 5000 | |
| SplitButton | mount | 3141 | 3197 | 5000 | |
| Stack | mount | 492 | 479 | 5000 | |
| StackWithIntrinsicChildren | mount | 1474 | 1547 | 5000 | |
| StackWithTextChildren | mount | 4473 | 4498 | 5000 | |
| SwatchColorPicker | mount | 10033 | 10136 | 5000 | |
| Tabs | mount | 1360 | 1385 | 1000 | |
| TagPicker | mount | 2383 | 2399 | 5000 | |
| TeachingBubble | mount | 11806 | 11752 | 5000 | |
| Text | mount | 421 | 410 | 5000 | |
| TextField | mount | 1352 | 1360 | 5000 | |
| ThemeProvider | mount | 1162 | 1195 | 5000 | |
| ThemeProvider | virtual-rerender | 610 | 576 | 5000 | |
| ThemeProviderNext | mount | 9102 | 9094 | 5000 | |
| Toggle | mount | 798 | 771 | 5000 | |
| buttonNative | mount | 113 | 110 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Potential regressions comparing to master
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AlertMinimalPerf.default | 266 | 253 | 1.05:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| VideoMinimalPerf.default | 656 | 582 | 1.13:1 |
| TreeWith60ListItems.default | 178 | 159 | 1.12:1 |
| ChatWithPopoverPerf.default | 363 | 339 | 1.07:1 |
| SegmentMinimalPerf.default | 343 | 322 | 1.07:1 |
| HeaderSlotsPerf.default | 765 | 721 | 1.06:1 |
| AttachmentMinimalPerf.default | 156 | 149 | 1.05:1 |
| CardMinimalPerf.default | 558 | 532 | 1.05:1 |
| ListCommonPerf.default | 627 | 600 | 1.05:1 |
| AnimationMinimalPerf.default | 410 | 396 | 1.04:1 |
| RadioGroupMinimalPerf.default | 429 | 413 | 1.04:1 |
| ReactionMinimalPerf.default | 378 | 364 | 1.04:1 |
| IconMinimalPerf.default | 607 | 583 | 1.04:1 |
| TableMinimalPerf.default | 394 | 380 | 1.04:1 |
| TextAreaMinimalPerf.default | 492 | 471 | 1.04:1 |
| AvatarMinimalPerf.default | 190 | 185 | 1.03:1 |
| LabelMinimalPerf.default | 391 | 380 | 1.03:1 |
| LoaderMinimalPerf.default | 693 | 676 | 1.03:1 |
| MenuMinimalPerf.default | 825 | 800 | 1.03:1 |
| MenuButtonMinimalPerf.default | 1561 | 1519 | 1.03:1 |
| StatusMinimalPerf.default | 673 | 655 | 1.03:1 |
| TooltipMinimalPerf.default | 955 | 928 | 1.03:1 |
| ButtonOverridesMissPerf.default | 1662 | 1637 | 1.02:1 |
| DropdownManyItemsPerf.default | 691 | 675 | 1.02:1 |
| FlexMinimalPerf.default | 282 | 276 | 1.02:1 |
| ItemLayoutMinimalPerf.default | 1236 | 1211 | 1.02:1 |
| ListMinimalPerf.default | 490 | 481 | 1.02:1 |
| CustomToolbarPrototype.default | 3791 | 3732 | 1.02:1 |
| AccordionMinimalPerf.default | 147 | 146 | 1.01:1 |
| BoxMinimalPerf.default | 335 | 333 | 1.01:1 |
| ButtonMinimalPerf.default | 164 | 163 | 1.01:1 |
| ChatMinimalPerf.default | 611 | 606 | 1.01:1 |
| DividerMinimalPerf.default | 355 | 350 | 1.01:1 |
| DropdownMinimalPerf.default | 3007 | 2982 | 1.01:1 |
| ImageMinimalPerf.default | 371 | 368 | 1.01:1 |
| InputMinimalPerf.default | 1231 | 1222 | 1.01:1 |
| ListWith60ListItems.default | 623 | 618 | 1.01:1 |
| SkeletonMinimalPerf.default | 345 | 342 | 1.01:1 |
| SliderMinimalPerf.default | 1516 | 1506 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3635 | 3593 | 1.01:1 |
| TableManyItemsPerf.default | 1871 | 1850 | 1.01:1 |
| ButtonUseCssNestingPerf.default | 1036 | 1035 | 1:1 |
| EmbedMinimalPerf.default | 4081 | 4101 | 1:1 |
| HeaderMinimalPerf.default | 363 | 363 | 1:1 |
| LayoutMinimalPerf.default | 367 | 367 | 1:1 |
| PopupMinimalPerf.default | 688 | 689 | 1:1 |
| AttachmentSlotsPerf.default | 1120 | 1128 | 0.99:1 |
| ButtonSlotsPerf.default | 536 | 542 | 0.99:1 |
| ButtonUseCssPerf.default | 778 | 785 | 0.99:1 |
| CheckboxMinimalPerf.default | 2671 | 2710 | 0.99:1 |
| DialogMinimalPerf.default | 721 | 725 | 0.99:1 |
| GridMinimalPerf.default | 328 | 330 | 0.99:1 |
| PortalMinimalPerf.default | 157 | 159 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1654 | 1679 | 0.99:1 |
| TextMinimalPerf.default | 332 | 335 | 0.99:1 |
| ToolbarMinimalPerf.default | 909 | 920 | 0.99:1 |
| TreeMinimalPerf.default | 793 | 800 | 0.99:1 |
| CarouselMinimalPerf.default | 450 | 458 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 288 | 295 | 0.98:1 |
| ListNestedPerf.default | 527 | 538 | 0.98:1 |
| ProviderMinimalPerf.default | 950 | 981 | 0.97:1 |
| DatepickerMinimalPerf.default | 5072 | 5315 | 0.95:1 |
| FormMinimalPerf.default | 396 | 417 | 0.95:1 |
| RosterPerf.default | 1118 | 1172 | 0.95:1 |
| RefMinimalPerf.default | 222 | 237 | 0.94:1 |
- Update change files for consistency - Fix some pr comments - fix merge - Change files - Add change files - update api - fix api-extractor warnings
6958690 to
a875d11
Compare
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
This was referenced May 4, 2021
Closed
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
* Upgrade to ts 4.0 - Update change files for consistency - Fix some pr comments - fix merge - Change files - Add change files - update api - fix api-extractor warnings * Update packages/react-portal/src/components/Portal/renderPortal.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/react-conformance/package.json Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> * Update packages/react-badge/src/components/Badge/useBadgeStyles.ts Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> * Update packages/fluentui/react-northstar/src/components/Datepicker/DatepickerCalendarHeaderAction.tsx Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update packages/react-badge/src/components/CounterBadge/useCounterBadgeStyles.ts Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> * Update prop types for ComponentBestPractices * Temporarily add anys to fix merge conflict. * fix DatepickerCalendarHeader.tsx to avoid "any" * fluentui/styles/src/types.ts: fix types * packages/fluentui/local-sandbox/tsconfig.json: rollback to esnext * react-menu/src/components/MenuGroupHeader/useMenuGroupHeader.ts: simplify signature * react-menu/src/components/MenuGroup/useMenuGroup.ts: simplify signature * @fluentui/babel-make-styles: fix versions after merge * @fluentui/make-styles: update API file * @fluentui/react-menu: use function to simplify definitions * @fluentui/react-menu: update API * react-badge/src/components/PresenceBadge/usePresenceBadgeStyles.ts: simplify signature * useTabsterAttributes.ts: fix signature * useMenuList.ts: remove cast to any * Change files * useTriggerElement.tsx: fix types * getBoundary.ts: remove useless typecast * useAccordionItem.ts: simplify typings * useTriggerElement-test.tsx: fix types in test * Update packages/react/src/components/List/List.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Revert change, update api docs * Revert changes to web-components/package.json * PR feedback * Reconcile tslib versions * Formatting * Update change/@fluentui-web-components-057bb4b4-9195-499c-a1c4-4fdb458f1302.json Co-authored-by: Chris Holt <chhol@microsoft.com> * Re-resolve merge conflicts * Update packages/react/src/components/List/List.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Update packages/eslint-plugin/package.json Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> * Update packages/react/src/components/List/List.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Update packages/react/src/components/MarqueeSelection/MarqueeSelection.base.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * Update packages/react/src/components/MarqueeSelection/MarqueeSelection.base.tsx Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> * PR feedback * update API * Formatting * fix regression on render callback * Update packages/fluentui/local-sandbox/webpack.config.js Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> * Update nohoist Co-authored-by: Jon S <joschect@microsoft.com> Co-authored-by: Oleksandr Fediashov <alexander.mcgarret@gmail.com> Co-authored-by: Elizabeth Craig <ecraig12345@gmail.com> Co-authored-by: Oleksandr Fediashov <olfedias@microsoft.com> Co-authored-by: Makoto Morimoto <Humberto.Morimoto@microsoft.com> Co-authored-by: Chris Holt <chhol@microsoft.com>
This was referenced Oct 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
(give an overview)
Focus areas to test
(optional)