feat(react-storybook): init new package for convergence storybooks co…#17921
Merged
Hotell merged 2 commits intomicrosoft:masterfrom Apr 26, 2021
Merged
Conversation
13 tasks
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: fdb1af09ba60238bb1c3913af6a6a6fe98f49034 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9f9d7ff:
|
Collaborator
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
3 tasks
layershifter
approved these changes
Apr 22, 2021
ling1726
reviewed
Apr 22, 2021
| "just": "just-scripts", | ||
| "lint": "just-scripts lint", | ||
| "start": "just-scripts dev:storybook", | ||
| "start-test": "echo \"This is DEPRECATED instead use 'test --watch'\" && just-scripts jest-watch", |
Contributor
There was a problem hiding this comment.
I guess you can just get rid of it for new packages
Suggested change
| "start-test": "echo \"This is DEPRECATED instead use 'test --watch'\" && just-scripts jest-watch", |
Contributor
Author
There was a problem hiding this comment.
this is gonna be handled in batch/automation scripts per package when new Dx is ready
ling1726
reviewed
Apr 22, 2021
| "start": "just-scripts dev:storybook", | ||
| "start-test": "echo \"This is DEPRECATED instead use 'test --watch'\" && just-scripts jest-watch", | ||
| "test": "jest", | ||
| "update-snapshots": "echo \"This is DEPRECATED instead use 'test -u'\" && just-scripts jest -u" |
Contributor
There was a problem hiding this comment.
No snapshots here I think... also we should just stop using snapshot tests IMO
Suggested change
| "update-snapshots": "echo \"This is DEPRECATED instead use 'test -u'\" && just-scripts jest -u" |
ling1726
approved these changes
Apr 22, 2021
miroslavstastny
approved these changes
Apr 22, 2021
JustSlone
approved these changes
Apr 22, 2021
ecraig12345
approved these changes
Apr 22, 2021
Comment on lines
+103
to
+104
| packages/react-storybook/ @cxe-prg @ling1726 @layershifter | ||
| packages/storybook/ @cxe-prg @ling1726 @layershifter |
Member
There was a problem hiding this comment.
Should both of these (or at least the old one) also have the build team as an owner?
Contributor
Author
There was a problem hiding this comment.
I don't see such a need ( I'd like to have our team and teams fluent team here for now ).
both are private for now, would be nice to shape up the new one to be a proper addon etc - then we can make it public.
| @@ -0,0 +1,3 @@ | |||
| { | |||
Member
There was a problem hiding this comment.
If you want it's probably okay to get rid of API Extractor for this package
Contributor
Author
There was a problem hiding this comment.
Im gonna keep it for consistency reasons. in general every package should use common tooling in terms of rolluping types and producing docs.
0f87eb4 to
90bc73c
Compare
b58420b to
9f9d7ff
Compare
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
microsoft#17921) * feat(react-storybook): init new package for convergence storybooks configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…nfiguration
Pull request checklist
$ yarn changeDescription of changes
@fluentui/react-storybook(this will be used for convergence and beyond)@fluentui/storybookhas it now as dependency so we don't duplicate code, without any breaking changes. Also this package can be used solely with v8/7.Dep Graph:
Focus areas to test
(optional)