Button: Setting focus visibility to true in scenarios where it should be supported#17820
Merged
khmakoto merged 2 commits intomicrosoft:masterfrom Apr 15, 2021
Merged
Button: Setting focus visibility to true in scenarios where it should be supported#17820khmakoto merged 2 commits intomicrosoft:masterfrom
khmakoto merged 2 commits intomicrosoft:masterfrom
Conversation
Asset size changes
Baseline commit: 9a01ff085821286d7b684cb37a5a83eb195d56a7 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5ad895f:
|
Collaborator
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
2 tasks
tomi-msft
approved these changes
Apr 15, 2021
Collaborator
|
🎉 Handy links: |
This was referenced Apr 16, 2021
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
… be supported (microsoft#17820) * Button: Setting focus visibility to true in scenarios where it should be supported. * Change files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR fixes 2 scenarios where keyboard focus should appear but wasn't when using the
Buttoncomponent in the@fluentui/reactpackage.The first scenario was that when programmatically focusing a
Buttonthe focus styling wouldn't be set.Before:
After:
The second scenario was that when clicking on a
Buttonwith a menu (so that the focus was already on the element), dismissing the menu and then opening it via pressing theEnterorSpacekeys, the focus indicator was not appearing:Before:
After:
