Remove pointer-events: 'none' from BaseButton disabled styles#17737
Merged
msft-fluent-ui-bot merged 2 commits intomicrosoft:masterfrom Apr 7, 2021
Merged
Conversation
Asset size changes
Baseline commit: ae21a051f71e7f7f71621f711a1da8dcb9284826 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e467b6f:
|
khmakoto
approved these changes
Apr 7, 2021
Member
|
@msft-fluent-ui-bot merge in 1 minute. |
Collaborator
|
Hello @khmakoto! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
Collaborator
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
…oft#17737) #### Pull request checklist - [x] Addresses an existing issue: Fixes microsoft#17606 - [x] Include a change request file using `$ yarn change` #### Description of changes Removes the `pointer-events: 'none'` styling that is applied to disabled buttons. This allows disabled buttons to have native `title` tooltips available (which is how native html buttons work in their disabled state). #### Focus areas to test Buttons
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Removes the
pointer-events: 'none'styling that is applied to disabled buttons. This allows disabled buttons to have nativetitletooltips available (which is how native html buttons work in their disabled state).Focus areas to test
Buttons