Skip to content

Update API Extractor config detection, exclude local config#17594

Merged
ecraig12345 merged 1 commit intomicrosoft:masterfrom
ecraig12345:api-extractor-configs
Mar 29, 2021
Merged

Update API Extractor config detection, exclude local config#17594
ecraig12345 merged 1 commit intomicrosoft:masterfrom
ecraig12345:api-extractor-configs

Conversation

@ecraig12345
Copy link
Member

Update the API Extractor task to properly determine the config name assuming a file name format of api-extractor.configName.json, and exclude api-extractor.local.json if it exists.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 971c1d6:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 27, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 71ef5869bd1d351f6ea9399698bf9b70737502a2 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 898 899 5000
BaseButton mount 913 884 5000
Breadcrumb mount 42113 42421 5000
ButtonNext mount 528 540 5000
Checkbox mount 1510 1484 5000
CheckboxBase mount 1253 1251 5000
ChoiceGroup mount 4597 4598 5000
ComboBox mount 928 958 1000
CommandBar mount 9915 9964 1000
ContextualMenu mount 6006 5961 1000
DefaultButton mount 1104 1099 5000
DetailsRow mount 3484 3461 5000
DetailsRowFast mount 3420 3502 5000
DetailsRowNoStyles mount 3283 3267 5000
Dialog mount 1397 1397 1000
DocumentCardTitle mount 1811 1762 1000
Dropdown mount 3258 3290 5000
FocusTrapZone mount 1722 1789 5000
FocusZone mount 1758 1715 5000
IconButton mount 1698 1690 5000
Label mount 357 333 5000
Layer mount 1721 1773 5000
Link mount 472 431 5000
MakeStyles mount 1711 1693 50000
MenuButton mount 1411 1473 5000
MessageBar mount 2016 1996 5000
Nav mount 3233 3219 1000
OverflowSet mount 1003 1009 5000
Panel mount 1371 1342 1000
Persona mount 793 821 1000
Pivot mount 1350 1344 1000
PrimaryButton mount 1257 1239 5000
Rating mount 7566 7556 5000
SearchBox mount 1265 1305 5000
Shimmer mount 2421 2435 5000
Slider mount 1895 1920 5000
SpinButton mount 4915 4933 5000
Spinner mount 395 419 5000
SplitButton mount 3089 3044 5000
Stack mount 477 481 5000
StackWithIntrinsicChildren mount 1487 1483 5000
StackWithTextChildren mount 4377 4314 5000
SwatchColorPicker mount 10153 9981 5000
Tabs mount 1356 1377 1000
TagPicker mount 2857 2837 5000
TeachingBubble mount 11442 11519 5000
Text mount 409 386 5000
TextField mount 1322 1306 5000
ThemeProvider mount 1141 1170 5000
ThemeProvider virtual-rerender 568 584 5000
ThemeProviderNext mount 15560 15735 5000
Toggle mount 780 784 5000
buttonNative mount 110 110 5000

Perf Analysis (Fluent)

Perf comparison
Status Scenario Fluent TPI Fabric TPI Ratio Iterations Ticks
🦄 Avatar.Fluent 0.17 0.46 0.37:1 2000 332
🦄 Button.Fluent 0.12 0.19 0.63:1 5000 579
🔧 Checkbox.Fluent 0.64 0.35 1.83:1 1000 638
🎯 Dialog.Fluent 0.16 0.21 0.76:1 5000 788
🔧 Dropdown.Fluent 3.09 0.39 7.92:1 1000 3090
🔧 Icon.Fluent 0.14 0.06 2.33:1 5000 692
🦄 Image.Fluent 0.08 0.12 0.67:1 5000 393
🔧 Slider.Fluent 1.59 0.45 3.53:1 1000 1586
🔧 Text.Fluent 0.07 0.03 2.33:1 5000 352
🦄 Tooltip.Fluent 0.14 0.85 0.16:1 5000 689

🔧 Needs work     🎯 On target     🦄 Amazing

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ListWith60ListItems.default 632 581 1.09:1
PortalMinimalPerf.default 185 170 1.09:1
ChatDuplicateMessagesPerf.default 310 290 1.07:1
ImageMinimalPerf.default 402 379 1.06:1
TableMinimalPerf.default 431 410 1.05:1
HeaderMinimalPerf.default 385 369 1.04:1
SegmentMinimalPerf.default 385 371 1.04:1
TextMinimalPerf.default 373 358 1.04:1
Avatar.Fluent 332 319 1.04:1
ButtonUseCssPerf.default 827 802 1.03:1
CardMinimalPerf.default 569 550 1.03:1
HeaderSlotsPerf.default 798 776 1.03:1
SkeletonMinimalPerf.default 392 379 1.03:1
StatusMinimalPerf.default 738 717 1.03:1
Icon.Fluent 692 674 1.03:1
Tooltip.Fluent 689 669 1.03:1
ButtonOverridesMissPerf.default 1717 1683 1.02:1
ButtonUseCssNestingPerf.default 1073 1055 1.02:1
ChatMinimalPerf.default 638 624 1.02:1
DropdownManyItemsPerf.default 732 721 1.02:1
ItemLayoutMinimalPerf.default 1207 1185 1.02:1
LayoutMinimalPerf.default 415 406 1.02:1
ListMinimalPerf.default 508 500 1.02:1
MenuMinimalPerf.default 882 868 1.02:1
TextAreaMinimalPerf.default 478 467 1.02:1
CustomToolbarPrototype.default 3790 3703 1.02:1
Button.Fluent 579 567 1.02:1
AlertMinimalPerf.default 306 303 1.01:1
AttachmentSlotsPerf.default 1226 1208 1.01:1
CheckboxMinimalPerf.default 2817 2800 1.01:1
ProviderMergeThemesPerf.default 1624 1613 1.01:1
SliderMinimalPerf.default 1611 1591 1.01:1
SplitButtonMinimalPerf.default 3705 3677 1.01:1
TreeMinimalPerf.default 786 775 1.01:1
VideoMinimalPerf.default 652 648 1.01:1
Checkbox.Fluent 638 632 1.01:1
Dropdown.Fluent 3090 3049 1.01:1
AvatarMinimalPerf.default 216 215 1:1
DatepickerMinimalPerf.default 45112 45100 1:1
ListCommonPerf.default 658 655 1:1
MenuButtonMinimalPerf.default 1554 1554 1:1
ProviderMinimalPerf.default 949 952 1:1
RefMinimalPerf.default 248 247 1:1
TableManyItemsPerf.default 2013 2003 1:1
ToolbarMinimalPerf.default 975 978 1:1
Slider.Fluent 1586 1592 1:1
DropdownMinimalPerf.default 3073 3109 0.99:1
InputMinimalPerf.default 1282 1301 0.99:1
LabelMinimalPerf.default 409 413 0.99:1
LoaderMinimalPerf.default 722 728 0.99:1
RadioGroupMinimalPerf.default 448 451 0.99:1
AnimationMinimalPerf.default 407 415 0.98:1
ButtonSlotsPerf.default 568 579 0.98:1
DialogMinimalPerf.default 776 795 0.98:1
EmbedMinimalPerf.default 4184 4257 0.98:1
FlexMinimalPerf.default 311 317 0.98:1
FormMinimalPerf.default 429 438 0.98:1
GridMinimalPerf.default 353 359 0.98:1
TooltipMinimalPerf.default 951 975 0.98:1
AttachmentMinimalPerf.default 171 176 0.97:1
CarouselMinimalPerf.default 482 498 0.97:1
RosterPerf.default 1125 1155 0.97:1
PopupMinimalPerf.default 701 719 0.97:1
ReactionMinimalPerf.default 412 426 0.97:1
Image.Fluent 393 404 0.97:1
BoxMinimalPerf.default 369 383 0.96:1
ButtonMinimalPerf.default 180 188 0.96:1
ChatWithPopoverPerf.default 381 398 0.96:1
IconMinimalPerf.default 670 695 0.96:1
Dialog.Fluent 788 818 0.96:1
ListNestedPerf.default 553 581 0.95:1
DividerMinimalPerf.default 363 387 0.94:1
Text.Fluent 352 374 0.94:1
AccordionMinimalPerf.default 156 167 0.93:1
TreeWith60ListItems.default 183 201 0.91:1

@ecraig12345 ecraig12345 disabled auto-merge March 29, 2021 20:57
@ecraig12345 ecraig12345 merged commit 624f0d7 into microsoft:master Mar 29, 2021
@ecraig12345 ecraig12345 deleted the api-extractor-configs branch March 29, 2021 20:57
miroslavstastny pushed a commit to miroslavstastny/fluentui that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants