Quick fix for Grouped DetailsList and Groupedlist row index errors#17259
Merged
smhigley merged 3 commits intomicrosoft:masterfrom Mar 9, 2021
Merged
Quick fix for Grouped DetailsList and Groupedlist row index errors#17259smhigley merged 3 commits intomicrosoft:masterfrom
smhigley merged 3 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a7064ec:
|
Asset size changes
Baseline commit: e63e5ecfe44b87bd4936a38187628b49dc92e049 (build) |
Collaborator
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
83f7f71 to
a7064ec
Compare
ThomasMichon
approved these changes
Mar 5, 2021
cschlechty
reviewed
Mar 5, 2021
| > | ||
| <div | ||
| aria-level={2} | ||
| aria-rowindex={1} |
cschlechty
approved these changes
Mar 5, 2021
smhigley
added a commit
to smhigley/fluentui
that referenced
this pull request
Mar 9, 2021
…icrosoft#17259) * remove incorrect grouped rowindex and count, update rowgroup for automated tests
Collaborator
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
…icrosoft#17259) * remove incorrect grouped rowindex and count, update rowgroup for automated tests
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
…icrosoft#17259) * remove incorrect grouped rowindex and count, update rowgroup for automated tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR cleans up a few remaining semantic issues with grouped detailslist and groupedlist, and adds a workaround for incorrect indices with grouped rows. Specifically:
Removes some
role="rowgroup"roles to avoid nested rowgroups, which are technically not allowed (automated issue only, no practical impact)Switches from
role="group"torole="rowgroup"on treegrid -- that was my mistake earlier, I used the tree semantics instead of the correct grid/treegrid roleRemoves
aria-rowindexand-rowcountentirely from any use of grouped rows with detailslist or groupedlist.This allows browser and screen readers to calculate that information correctly in all non-virtualized grids, and even in virtualized grids the linear off-by-x announcements will still be better than the values we provide now, which jump all over the place between detailslist rows and group headers. The biggest win here is now JAWS can navigate the grouped detailslist properly in scan mode, whereas before it missed a number of rows due to incorrect index values.