Button: Adding SPEC.md and MIGRATION.md and updating README.md#17192
Merged
msft-fluent-ui-bot merged 14 commits intomicrosoft:masterfrom Mar 24, 2021
Merged
Button: Adding SPEC.md and MIGRATION.md and updating README.md#17192msft-fluent-ui-bot merged 14 commits intomicrosoft:masterfrom
msft-fluent-ui-bot merged 14 commits intomicrosoft:masterfrom
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 81b0586:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b8e8697d9f3ff285687b7cba27b9ac037a0cb727 (build) |
Collaborator
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
khmakoto
commented
Mar 3, 2021
Comment on lines
+270
to
+271
| | `Enter` | Executes the `Button` action. | | ||
| | `Space` | Executes the `Button` action. | |
Member
Author
There was a problem hiding this comment.
Investigate how Enter and Space work with native browser button and have the Button events follow the native events as close as possible.
Possibly want to check with conformance tests.
Open question: Do we really need to do specific checks for the as prop? We need to be clear if and when we deviate because this starts getting into magic handling of props which has other potential drawbacks such as bundle size increases.
ling1726
approved these changes
Mar 24, 2021
dzearing
approved these changes
Mar 24, 2021
Collaborator
|
Hello @khmakoto! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
Collaborator
|
🎉 Handy links: |
joshualamusga1
pushed a commit
to joshualamusga1/fluentui
that referenced
this pull request
Mar 25, 2021
…soft#17192) #### Pull request checklist - [X] Addresses an existing issue: Part of microsoft#16746, fixes microsoft#16607 - [X] Include a change request file using `$ yarn change` #### Description of changes This PR adds the initial SPEC and MIGRATION guide for the button component and updates the README to correctly refer this. This PR also removes any reference to component tokens in `@fluentui/react-link` until we decide what to do with them and adds the `secondary` prop that was missing into the API.
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
May 5, 2021
…soft#17192) #### Pull request checklist - [X] Addresses an existing issue: Part of microsoft#16746, fixes microsoft#16607 - [X] Include a change request file using `$ yarn change` #### Description of changes This PR adds the initial SPEC and MIGRATION guide for the button component and updates the README to correctly refer this. This PR also removes any reference to component tokens in `@fluentui/react-link` until we decide what to do with them and adds the `secondary` prop that was missing into the API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR adds the initial SPEC and MIGRATION guide for the button component and updates the README to correctly refer this.
This PR also removes any reference to component tokens in
@fluentui/react-linkuntil we decide what to do with them and adds thesecondaryprop that was missing into the API.