Lint: Allow references to devDependencies defined in root package.json by ecraig12345 · Pull Request #16975 · microsoft/fluentui

ecraig12345 · 2021-02-12T18:34:38Z

Pull request checklist

Include a change request file using $ yarn change

Description of changes

Now that we're moving common devDependencies to the root package.json only, update the import/no-implicit-dependencies rule config to allow references to dev deps which are defined either at the root level or the package level.

Also remove the separate types file for configHelpers.js and move the docs inline--not sure why I had that as a separate file before.

codesandbox-ci · 2021-02-12T18:45:57Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b230146:

Sandbox	Source
Fluent UI Button	Configuration
codesandbox-react-template	Configuration
codesandbox-react-northstar-template	Configuration

size-auditor · 2021-02-12T18:51:55Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e0d4772fbaff0afd7ae0a2f85b53c4ca3831a701 (build)

fabricteam · 2021-02-12T19:09:00Z

Perf Analysis

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	817	816	5000
BaseButton	mount	901	870	5000
Breadcrumb	mount	43800	43779	5000
ButtonNext	mount	663	656	5000
Checkbox	mount	1488	1494	5000
CheckboxBase	mount	1248	1216	5000
ChoiceGroup	mount	4659	4671	5000
ComboBox	mount	943	931	1000
CommandBar	mount	10083	10200	1000
ContextualMenu	mount	6164	6057	1000
DefaultButton	mount	1103	1120	5000
DetailsRow	mount	3556	3543	5000
DetailsRowFast	mount	3569	3620	5000
DetailsRowNoStyles	mount	3302	3297	5000
Dialog	mount	1452	1440	1000
DocumentCardTitle	mount	1807	1819	1000
Dropdown	mount	3259	3292	5000
FocusTrapZone	mount	1799	1850	5000
FocusZone	mount	1782	1771	5000
IconButton	mount	1714	1723	5000
Label	mount	330	329	5000
Layer	mount	1749	1755	5000
Link	mount	479	470	5000
MakeStyles	mount	1962	1933	50000
MenuButton	mount	1446	1427	5000
MessageBar	mount	2011	2027	5000
Nav	mount	3209	3252	1000
OverflowSet	mount	1015	1062	5000
Panel	mount	1427	1396	1000
Persona	mount	796	817	1000
Pivot	mount	1378	1394	1000
PrimaryButton	mount	1269	1243	5000
Rating	mount	7437	7367	5000
SearchBox	mount	1272	1298	5000
Shimmer	mount	2519	2537	5000
Slider	mount	1806	1885	5000
SpinButton	mount	4939	4963	5000
Spinner	mount	423	409	5000
SplitButton	mount	3170	3145	5000
Stack	mount	516	492	5000
StackWithIntrinsicChildren	mount	1470	1539	5000
StackWithTextChildren	mount	4364	4408	5000
SwatchColorPicker	mount	10081	9991	5000
Tabs	mount	1364	1397	1000
TagPicker	mount	2718	2795	5000
TeachingBubble	mount	11505	11568	5000
Text	mount	410	405	5000
TextField	mount	1413	1351	5000
ThemeProvider	mount	1169	1145	5000
ThemeProvider	virtual-rerender	586	586	5000
ThemeProviderNext	mount	1956	1990	5000
Toggle	mount	789	789	5000
buttonNative	mount	104	99	5000

Perf Analysis (Fluent)

Perf comparison

Status	Scenario	Fluent TPI	Fabric TPI	Ratio	Iterations	Ticks
🦄	Avatar.Fluent	0.17	0.48	0.35:1	2000	341
🦄	Button.Fluent	0.11	0.2	0.55:1	5000	571
🔧	Checkbox.Fluent	0.64	0.33	1.94:1	1000	642
🎯	Dialog.Fluent	0.16	0.21	0.76:1	5000	804
🔧	Dropdown.Fluent	3.03	0.41	7.39:1	1000	3032
🔧	Icon.Fluent	0.13	0.06	2.17:1	5000	669
🦄	Image.Fluent	0.08	0.13	0.62:1	5000	389
🔧	Slider.Fluent	1.57	0.43	3.65:1	1000	1571
🔧	Text.Fluent	0.08	0.03	2.67:1	5000	380
🦄	Tooltip.Fluent	0.12	0.88	0.14:1	5000	586

🔧 Needs work 🎯 On target 🦄 Amazing

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
ButtonMinimalPerf.default	194	175	1.11:1
AccordionMinimalPerf.default	171	157	1.09:1
AvatarMinimalPerf.default	217	200	1.09:1
Text.Fluent	380	352	1.08:1
SkeletonMinimalPerf.default	400	374	1.07:1
TableMinimalPerf.default	457	426	1.07:1
FlexMinimalPerf.default	326	307	1.06:1
BoxMinimalPerf.default	389	370	1.05:1
RadioGroupMinimalPerf.default	457	435	1.05:1
ChatDuplicateMessagesPerf.default	378	365	1.04:1
ChatMinimalPerf.default	653	627	1.04:1
DividerMinimalPerf.default	387	373	1.04:1
ListMinimalPerf.default	522	504	1.04:1
TreeMinimalPerf.default	818	786	1.04:1
HeaderSlotsPerf.default	803	779	1.03:1
LabelMinimalPerf.default	434	423	1.03:1
MenuButtonMinimalPerf.default	1620	1575	1.03:1
Tooltip.Fluent	586	567	1.03:1
AlertMinimalPerf.default	304	298	1.02:1
CarouselMinimalPerf.default	496	486	1.02:1
DatepickerMinimalPerf.default	47704	46820	1.02:1
DropdownManyItemsPerf.default	737	726	1.02:1
InputMinimalPerf.default	1312	1285	1.02:1
TooltipMinimalPerf.default	836	822	1.02:1
Checkbox.Fluent	642	628	1.02:1
Dialog.Fluent	804	788	1.02:1
ButtonUseCssPerf.default	805	800	1.01:1
FormMinimalPerf.default	441	436	1.01:1
GridMinimalPerf.default	376	374	1.01:1
ListNestedPerf.default	594	588	1.01:1
MenuMinimalPerf.default	894	886	1.01:1
ProviderMergeThemesPerf.default	1647	1636	1.01:1
ProviderMinimalPerf.default	967	953	1.01:1
RefMinimalPerf.default	243	241	1.01:1
TableManyItemsPerf.default	2049	2032	1.01:1
ToolbarMinimalPerf.default	972	967	1.01:1
ButtonOverridesMissPerf.default	1711	1713	1:1
SplitButtonMinimalPerf.default	3726	3736	1:1
TextAreaMinimalPerf.default	507	507	1:1
Avatar.Fluent	341	342	1:1
Button.Fluent	571	572	1:1
Image.Fluent	389	389	1:1
AttachmentMinimalPerf.default	162	164	0.99:1
ButtonSlotsPerf.default	576	583	0.99:1
ButtonUseCssNestingPerf.default	1061	1073	0.99:1
CheckboxMinimalPerf.default	2842	2872	0.99:1
ListCommonPerf.default	663	667	0.99:1
ListWith60ListItems.default	649	653	0.99:1
LoaderMinimalPerf.default	737	748	0.99:1
PopupMinimalPerf.default	697	704	0.99:1
PortalMinimalPerf.default	168	169	0.99:1
ReactionMinimalPerf.default	407	413	0.99:1
SegmentMinimalPerf.default	364	369	0.99:1
TextMinimalPerf.default	374	376	0.99:1
Slider.Fluent	1571	1579	0.99:1
AttachmentSlotsPerf.default	1208	1233	0.98:1
CardMinimalPerf.default	567	579	0.98:1
ChatWithPopoverPerf.default	435	444	0.98:1
DialogMinimalPerf.default	790	806	0.98:1
EmbedMinimalPerf.default	4224	4289	0.98:1
HeaderMinimalPerf.default	375	381	0.98:1
LayoutMinimalPerf.default	416	424	0.98:1
SliderMinimalPerf.default	1571	1597	0.98:1
CustomToolbarPrototype.default	3734	3802	0.98:1
Dropdown.Fluent	3032	3096	0.98:1
AnimationMinimalPerf.default	406	419	0.97:1
DropdownMinimalPerf.default	3076	3183	0.97:1
StatusMinimalPerf.default	718	744	0.97:1
IconMinimalPerf.default	671	693	0.97:1
VideoMinimalPerf.default	634	654	0.97:1
ItemLayoutMinimalPerf.default	1234	1280	0.96:1
RosterPerf.default	1155	1207	0.96:1
Icon.Fluent	669	703	0.95:1
ImageMinimalPerf.default	380	408	0.93:1
TreeWith60ListItems.default	163	176	0.93:1

packages/eslint-plugin/src/utils/configHelpers.d.ts

packages/eslint-plugin/src/utils/configHelpers.js

packages/eslint-plugin/src/configs/react.js

msft-fluent-ui-bot · 2021-02-18T12:28:40Z

🎉@fluentui/webpack-utilities@v8.0.0-beta.4 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:28:43Z

🎉@fluentui/utilities@v8.0.0-beta.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:28:46Z

🎉@fluentui/theme@v2.0.0-beta.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:28:49Z

🎉@fluentui/theme-samples@v8.0.0-beta.55 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:28:52Z

🎉@fluentui/test-utilities@v8.0.0-beta.7 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:28:55Z

🎉@fluentui/style-utilities@v8.0.0-beta.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:28:58Z

🎉@fluentui/set-version@v8.0.0-beta.2 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:29:01Z

🎉@fluentui/scheme-utilities@v8.0.0-beta.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:29:07Z

🎉@fluentui/react-window-provider@v2.0.0-beta.7 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:29:10Z

🎉@fluentui/react-utilities@v0.3.0 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:29:13Z

🎉@fluentui/react-toggle@v1.0.0-beta.46 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:29:19Z

🎉@fluentui/react-text@v0.1.7 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:29:37Z

🎉@fluentui/react-monaco-editor@v1.0.1-2 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:29:40Z

🎉@fluentui/react-menu@v0.4.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:29:43Z

🎉@fluentui/react-make-styles@v0.2.7-0 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:29:52Z

🎉@fluentui/react-image@v0.7.1 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:29:55Z

🎉@fluentui/react-icons-mdl2@v1.0.0-beta.15 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:29:58Z

🎉@fluentui/react-hooks@v8.0.0-beta.13 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:01Z

🎉@fluentui/react-focus@v8.0.0-beta.22 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:04Z

🎉@fluentui/react-file-type-icons@v8.0.0-beta.19 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:10Z

🎉@fluentui/react-experiments@v8.0.0-beta.60 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:16Z

🎉@fluentui/react-docsite-components@v8.0.0-beta.56 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:19Z

🎉@fluentui/react-date-time@v8.0.0-beta.47 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:22Z

🎉@fluentui/react-compose@v1.0.0-beta.14 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:25Z

🎉@fluentui/react-checkbox@v1.0.0-beta.43 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:28Z

🎉@fluentui/react-charting@v5.0.0-beta.56 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:43Z

🎉@fluentui/react-avatar@v0.11.0 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:49Z

🎉@fluentui/public-docsite-resources@v8.0.0-beta.3 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:52Z

🎉@fluentui/monaco-editor@v1.0.0-beta.3 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:30:55Z

🎉@fluentui/merge-styles@v8.0.0-beta.5 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:31:01Z

🎉@fluentui/jest-serializer-merge-styles@v8.0.0-beta.6 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:31:04Z

🎉@fluentui/foundation-legacy@v8.0.0-beta.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:31:07Z

🎉@fluentui/font-icons-mdl2@v8.0.0-beta.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:31:10Z

🎉@fluentui/example-data@v8.0.0-beta.4 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:31:13Z

🎉@fluentui/eslint-plugin@v1.0.0-beta.2 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:31:16Z

🎉@fluentui/dom-utilities@v2.0.0-beta.2 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:31:19Z

🎉@fluentui/date-time-utilities@v8.0.0-beta.4 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:31:22Z

🎉@fluentui/common-styles@v1.0.0-beta.17 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:31:25Z

🎉@fluentui/codemods@v1.0.0-beta.5 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:31:28Z

🎉@fluentui/azure-themes@v8.0.0-beta.55 has been released which incorporates this pull request.:tada:

Handy links:

msft-fluent-ui-bot · 2021-02-18T12:31:31Z

🎉@fluentui/api-docs@v8.0.0-beta.3 has been released which incorporates this pull request.:tada:

Handy links:

microsoft#16975)

msft-fluent-ui-bot added Area: Build System Package: eslint-plugin labels Feb 12, 2021

msft-fluent-ui-bot assigned joschect Feb 12, 2021

ecraig12345 mentioned this pull request Feb 12, 2021

chore: apply single version policy on jest #16950

Merged

2 tasks

ecraig12345 requested review from Hotell and dzearing February 12, 2021 18:40

Allow references to devDependencies defined in root package.json

665bd11

ecraig12345 force-pushed the lint-dev-deps branch from 45d6cea to 665bd11 Compare February 13, 2021 00:57

Hotell reviewed Feb 15, 2021

View reviewed changes

ecraig12345 added 2 commits February 16, 2021 10:36

Move configHelpers types to inline jsdoc

592fd5a

use break

7262ca5

Hotell approved these changes Feb 17, 2021

View reviewed changes

add comment about defineProperty and ts-ignore

b230146

ecraig12345 merged commit 1072765 into microsoft:master Feb 18, 2021

ecraig12345 deleted the lint-dev-deps branch February 18, 2021 06:05

joshualamusga1 pushed a commit to joshualamusga1/fluentui that referenced this pull request Feb 25, 2021

Lint: Allow references to devDependencies defined in root package.json (

59a8d03

microsoft#16975)

Conversation

ecraig12345 commented Feb 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request checklist

Description of changes

Uh oh!

codesandbox-ci bot commented Feb 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

size-auditor bot commented Feb 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Asset size changes

Uh oh!

fabricteam commented Feb 12, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Perf Analysis

Perf Analysis (Fluent)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

msft-fluent-ui-bot commented Feb 18, 2021

Uh oh!

ecraig12345 commented Feb 12, 2021 •

edited

Loading

codesandbox-ci bot commented Feb 12, 2021 •

edited

Loading

size-auditor bot commented Feb 12, 2021 •

edited

Loading

fabricteam commented Feb 12, 2021 •

edited

Loading