chore: add typescript as explicit dev dependency to react-northstar#14362
Merged
dzearing merged 2 commits intomicrosoft:masterfrom Aug 5, 2020
Conversation
Member
|
This looks good by me. @layershifter ? |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 91a4e87:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 67e2615799af15030e8d3d63287173bb03e6bb92 (build) |
Contributor
Perf AnalysisNo significant results to display. All results
Perf Analysis (Fluent)Perf comparison
Perf tests with no regressions
|
Member
|
I suggest to do the same change for other packages under |
Member
Author
@layershifter my only concern with adding everywhere is that we don't quite know why this is happening. I definitely get the goal of uniformity across the fluentui folder, but I feel like it may be safer to fix the immediate problem and not make the change everywhere. In the case that this break pops up elsewhere, I think that would be the immediate next step to see if it fixes the problem there. Thoughts on that? I'm certainly open to making the update elsewhere, but not exactly knowing why this fixed the problem gives me pause on adding the explicit dependency everywhere else. |
dzearing
approved these changes
Aug 5, 2020
tmaster628
pushed a commit
to tmaster628/fluentui
that referenced
this pull request
Aug 12, 2020
…icrosoft#14362) * chore: add typescript as explicit dev dependency to react-northstar * add typescript to all other fluentui folder packages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This PR adds typescript as an explicit dev dependency for react-northstar. For some reason, it was building with TS version of ^3.9.x. My working assumption is that it defaulted to an installed version as one was not explicitly defined in the package.json.
Focus areas to test
The build passes 😄