Skip to content

Tags by resource bug fix#340

Merged
flanakin merged 3 commits into
devfrom
flanakin/dev/tagsbyresource
Sep 27, 2023
Merged

Tags by resource bug fix#340
flanakin merged 3 commits into
devfrom
flanakin/dev/tagsbyresource

Conversation

@flanakin

@flanakin flanakin commented Sep 18, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Fixes #331

🛠️ Description

Fixes a bug where specifying tags in the create form in the portal causes the deployment to fail.

Fixes #331

📋 Checklist

🔬 How did you test this change?

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Yes (required for dev PRs)
  • ➡️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will cover in a future PR (feature branch PRs only)
  • ❎ Not needed (small/internal change)

@flanakin flanakin requested a review from MSBrett as a code owner September 18, 2023 23:05
@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Sep 18, 2023

Copy link
Copy Markdown

@all-contributors please add flanakin for doc

@microsoft-github-policy-service microsoft-github-policy-service Bot added Tool: FinOps hubs Data pipeline solution Needs: Review 👀 PR that is ready to be reviewed labels Sep 18, 2023
@allcontributors

allcontributors Bot commented Sep 18, 2023

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service[bot]

@flanakin already contributed before to doc

@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Sep 19, 2023

Copy link
Copy Markdown

@all-contributors please add flanakin for doc

@allcontributors

allcontributors Bot commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service[bot]

@flanakin already contributed before to doc

@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Sep 19, 2023

Copy link
Copy Markdown

@all-contributors please add flanakin for doc

@allcontributors

allcontributors Bot commented Sep 19, 2023

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service[bot]

@flanakin already contributed before to doc

@microsoft-github-policy-service

microsoft-github-policy-service Bot commented Sep 24, 2023

Copy link
Copy Markdown

@all-contributors please add flanakin for doc

@allcontributors

allcontributors Bot commented Sep 24, 2023

Copy link
Copy Markdown
Contributor

@microsoft-github-policy-service[bot]

@flanakin already contributed before to doc

@flanakin flanakin added this to the 0.1 milestone Sep 25, 2023
@flanakin flanakin merged commit 01074d6 into dev Sep 27, 2023
@flanakin flanakin deleted the flanakin/dev/tagsbyresource branch September 27, 2023 08:15
flanakin added a commit that referenced this pull request Sep 30, 2023
@flanakin
Tags by resource bug fix (#340)
e764cb6
flanakin added a commit that referenced this pull request Oct 1, 2023
@flanakin
Tags by resource bug fix (#340)
05ea625
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MSBrett MSBrett Awaiting requested review from MSBrett MSBrett is a code owner

Assignees

@MSBrett MSBrett

Labels

Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution

Projects

None yet

Milestone

0.1

Development

Successfully merging this pull request may close these issues.

[Hubs] Error in finops-hub template when tags been added

2 participants

@flanakin @MSBrett