Fix version format mismatch in ftkver.txt#1940
Merged
Merged
Conversation
Strip trailing .0 from version (e.g., 12.0 → 12) so URLs constructed with the version match the git tag format (v12 not v12.0). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a version format mismatch that was causing the config_InitializeHub pipeline to fail when loading open data files from GitHub. The version in ftkver.txt (e.g., 12.0) now matches the git tag format (e.g., v12) by stripping the trailing .0 from major-only versions.
Changes:
- Added a regex pattern to
Get-Version.ps1to strip trailing.0from major versions (e.g.,12.0→12) - Updated changelog to document the fix under FinOps hubs v13
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/scripts/Get-Version.ps1 | Added regex pattern to strip trailing .0 from major versions to match git tag format |
| docs-mslearn/toolkit/changelog.md | Documented the version format fix under FinOps hubs v13 with issue reference |
Collaborator
Author
|
@microsoft-github-policy-service agree |
RolandKrummenacher
approved these changes
Jan 13, 2026
flanakin
added a commit
that referenced
this pull request
Jan 31, 2026
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config_InitializeHubpipeline failure when loading open data files from GitHub12.0) now matches the git tag format (e.g.,v12)Root Cause
The
Get-Version.ps1script was producing versions like12.0from package.json's12.0.0, but git tags are created asv12(without the.0). This caused URLs like:https://raw.githubusercontent.com/microsoft/finops-toolkit/refs/tags/v12.0/src/open-data/PricingUnits.csvTo fail because the tag
v12.0doesn't exist - onlyv12exists.Fix
Added a regex pattern to strip trailing
.0from major versions:12.0→1212.1→12.1(unchanged)12.0-dev→12-dev(unchanged, already handled)Test plan
./src/scripts/Get-Version.ps1and verify it returns13(not13.0)config_InitializeHubpipeline succeedsCloses #1885
🤖 Generated with Claude Code