Skip to content

[AOE] Fixes underutilized Premium disk recommendations in customers with Premium SSD V2 disks#1832

Merged
helderpinto merged 2 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/fix1831
Oct 1, 2025
Merged

[AOE] Fixes underutilized Premium disk recommendations in customers with Premium SSD V2 disks#1832
helderpinto merged 2 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/fix1831

Conversation

@helderpinto

Copy link
Copy Markdown
Member

🛠️ Description

The Recommend-DiskOptimizationsToBlobStorage runbook started failing in environments with Premium SSD V2 disks. The runbook was working properly before. The reason for the failure is related with a change that occurred in the Compute Resource Provider, which removed the MaxIOps capability from Premium SSD V2 SKU details. Given the completely different nature of Premium SSD V2 disks usage and billing, they need to be filtered out from the recommendation logic.

Fixes #1831

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@helderpinto helderpinto added Micro PR 🔬 Very small PR that should be especially easy for newcomers Tool: Optimization Engine Azure Optimization Engine Hotfix 🔥 A change that should be deployed immediately labels Oct 1, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Review 👀 PR that is ready to be reviewed label Oct 1, 2025

@MSBrett MSBrett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This fix properly addresses the Premium SSD V2 disk issue by excluding them from the recommendation logic. The changelog has been updated appropriately.

@helderpinto helderpinto merged commit 207c817 into microsoft:dev Oct 1, 2025
1 check passed
@MSBrett MSBrett added this to the 2025-10 - October milestone Oct 12, 2025
flanakin pushed a commit that referenced this pull request Jan 31, 2026
…ith Premium SSD V2 disks (#1832)

Co-authored-by: Hélder Pinto <helder.pinto@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hotfix 🔥 A change that should be deployed immediately Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: Optimization Engine Azure Optimization Engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AOE] Recommend-DiskOptimizationsToBlobStorage runbook is failing when dataset contains Premium SSD V2 disks

4 participants