Skip to content

[AOE] Fixes Reservations-related workbooks link to ISF ratio CSV#1815

Merged
MSBrett merged 3 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/fix1810
Oct 11, 2025
Merged

[AOE] Fixes Reservations-related workbooks link to ISF ratio CSV#1815
MSBrett merged 3 commits into
microsoft:devfrom
helderpinto:helderpinto/dev/fix1810

Conversation

@helderpinto

Copy link
Copy Markdown
Member

🛠️ Description

Reservations-related workbooks fixed by replacing Instance Size Flexibility ratios CSV vanity URL with actual one to work around Log Analytics externaldata operator limitation (recent Log Analytics change).

Fixes #1810

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

Hélder Pinto added 2 commits September 4, 2025 16:19
@helderpinto helderpinto added Micro PR 🔬 Very small PR that should be especially easy for newcomers Tool: Optimization Engine Azure Optimization Engine Hotfix 🔥 A change that should be deployed immediately labels Sep 4, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Review 👀 PR that is ready to be reviewed label Sep 4, 2025
@MSBrett MSBrett requested a review from Copilot September 10, 2025 15:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes reservations-related workbooks by replacing the Instance Size Flexibility ratios CSV vanity URL with the actual URL to work around a Log Analytics externaldata operator limitation.

Key Changes

  • Replaced the vanity URL https://aka.ms/isf with the actual URL https://ccmstorageprod.blob.core.windows.net/instancesizeflexibility-data/isfratioblob.csv across all affected KQL queries
  • Updated the changelog to document the fix

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/optimization-engine/views/workbooks/reservations-usage.json Updated 9 KQL queries to use the actual ISF CSV URL instead of the vanity URL
src/optimization-engine/views/workbooks/reservations-potential.json Updated 4 KQL queries to use the actual ISF CSV URL instead of the vanity URL
src/optimization-engine/views/workbooks/benefits-simulation.json Updated 7 KQL queries to use the actual ISF CSV URL instead of the vanity URL
docs-mslearn/toolkit/changelog.md Added changelog entry documenting the fix for the ISF ratios CSV URL issue

Comment thread docs-mslearn/toolkit/changelog.md

@MSBrett MSBrett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved - Workbooks link fix addresses Log Analytics externaldata limitation. Changelog already in v13 section.

@MSBrett MSBrett enabled auto-merge (squash) October 11, 2025 04:22
@MSBrett MSBrett merged commit ef381d8 into microsoft:dev Oct 11, 2025
1 check passed
@MSBrett MSBrett added this to the 2025-10 - October milestone Oct 12, 2025
flanakin pushed a commit that referenced this pull request Jan 31, 2026
Co-authored-by: Hélder Pinto <helder.pinto@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Hotfix 🔥 A change that should be deployed immediately Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: Optimization Engine Azure Optimization Engine

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[AOE] Reservations workbooks are returning query errors when ISF is enabled

5 participants