Skip to content

[Hubs] Allow flexible VNet CIDR sizes (/8 to /26)#1695

Merged
MSBrett merged 5 commits into
devfrom
MSBrett/issue1668
Jun 17, 2025
Merged

[Hubs] Allow flexible VNet CIDR sizes (/8 to /26)#1695
MSBrett merged 5 commits into
devfrom
MSBrett/issue1668

Conversation

@MSBrett

@MSBrett MSBrett commented Jun 15, 2025

Copy link
Copy Markdown
Contributor

🛠️ Description

Updates the FinOps hub deployment to accept flexible VNet CIDR sizes (/8 -> /26) instead of requiring only /26. This change enables users who deployed with larger CIDR blocks (like /24 for Power BI VNet Data Gateway support) to upgrade to newer versions without being blocked by validation errors.

The fix maintains the existing subnet calculations to ensure backward compatibility - only the validation is changed to be more permissive.

Fixes #1668

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

…ents

- Update createUiDefinition.json validation regex to accept /24, /25, or /26 CIDR blocks
- Update parameter descriptions in main.bicep and hub.bicep
- Maintain existing subnet calculations to preserve compatibility
- Addresses issue #1668: users with /24 deployments can now upgrade
@microsoft-github-policy-service microsoft-github-policy-service Bot added Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed labels Jun 15, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Tool: FinOps hubs Data pipeline solution label Jun 15, 2025
Comment thread docs-mslearn/toolkit/changelog.md Outdated
Comment thread src/templates/finops-hub/createUiDefinition.json Outdated
Comment thread src/templates/finops-hub/createUiDefinition.json Outdated
Comment thread docs-mslearn/toolkit/changelog.md Outdated
Comment thread docs-mslearn/toolkit/hubs/private-networking.md Outdated
Comment thread docs-mslearn/toolkit/hubs/private-networking.md Outdated
Comment thread docs-mslearn/toolkit/hubs/template.md Outdated
Comment thread src/templates/finops-hub/main.bicep Outdated
Comment thread src/templates/finops-hub/modules/hub.bicep Outdated
@flanakin flanakin added this to the 2025-06 - June milestone Jun 16, 2025
@flanakin flanakin changed the title Fix #1668: Allow flexible VNet CIDR sizes (/24, /25, /26) for FinOps hub [Hubs] Allow flexible VNet CIDR sizes (/0 to /26) for FinOps hub Jun 16, 2025
@flanakin flanakin changed the title [Hubs] Allow flexible VNet CIDR sizes (/0 to /26) for FinOps hub [Hubs] Allow flexible VNet CIDR sizes (/0 to /26) Jun 16, 2025
@MSBrett MSBrett changed the title [Hubs] Allow flexible VNet CIDR sizes (/0 to /26) [Hubs] Allow flexible VNet CIDR sizes (/8 to /26) Jun 17, 2025
@MSBrett MSBrett closed this Jun 17, 2025
@MSBrett MSBrett reopened this Jun 17, 2025
@MSBrett MSBrett enabled auto-merge (squash) June 17, 2025 17:25
@MSBrett MSBrett disabled auto-merge June 17, 2025 17:26
@MSBrett MSBrett merged commit de6a5a1 into dev Jun 17, 2025
4 checks passed
@MSBrett MSBrett deleted the MSBrett/issue1668 branch June 17, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Hubs] Unable to Upgrade Due To Explicit /26 CIDR Required

3 participants