Skip to content

Remove ADX trusted external tenants#1405

Merged
flanakin merged 1 commit into
devfrom
flanakin/dev/hubs-remtrust
Mar 20, 2025
Merged

Remove ADX trusted external tenants#1405
flanakin merged 1 commit into
devfrom
flanakin/dev/hubs-remtrust

Conversation

@flanakin

Copy link
Copy Markdown
Collaborator

🛠️ Description

Remove the ADX trusted external tenants setting that is causing failures when re-deploying hubs.

Fixes #1350

📷 Screenshots

Screenshot of an error we get when redeploying 0.8

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin added the Tool: FinOps hubs Data pipeline solution label Mar 16, 2025
@flanakin flanakin added this to the 2025-03 - March milestone Mar 16, 2025
@flanakin flanakin marked this pull request as ready for review March 16, 2025 04:48
@flanakin flanakin requested a review from MSBrett as a code owner March 16, 2025 04:48
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Micro PR 🔬 Very small PR that should be especially easy for newcomers label Mar 16, 2025
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Needs: Review 👀 PR that is ready to be reviewed label Mar 16, 2025
@flanakin flanakin enabled auto-merge (squash) March 16, 2025 06:49
@flanakin flanakin merged commit f47a28f into dev Mar 20, 2025
@flanakin flanakin deleted the flanakin/dev/hubs-remtrust branch March 20, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Micro PR 🔬 Very small PR that should be especially easy for newcomers Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redeployment FinOps Hub with Azure Data Explorer always request to deploy new one instead of referring to existing one

2 participants