Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: microsoft/clrmd
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: fb8c39b99e
Choose a base ref
...
head repository: microsoft/clrmd
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5b1e07095f
Choose a head ref
  • 16 commits
  • 9 files changed
  • 3 contributors

Commits on Oct 16, 2024

  1. Merged PR 43723: Add DAC cert check (internal/main)

    Added a new common code/function called WinTrustVerify.VerifyDacDll that checks the DAC for the special cert. It is used by DacLibrary and externally by SOS.
    
    ----
    #### AI description  (iteration 1)
    #### PR Classification
    New feature
    
    #### PR Summary
    Introduces a new feature to verify DAC (Data Access Component) certificate signing.
    - Added `AuthenticodeUtil.cs` to handle DAC certificate verification.
    - Updated `CustomDataTarget.cs` and `DataTarget.cs` to include `SecureDacLoading` property.
    - Modified `DacLibrary.cs` to enforce DAC certificate verification using `AuthenticodeUtil`.
    - Updated `Microsoft.Diagnostics.Runtime.csproj` to use a newer version of `Azure.Identity`.
    Mike McLaughlin committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    55843d1 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'main' into internal/main

    Mike McLaughlin committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b39240b View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Merged PR 44031: Update DAC signature checking logic

    Update DAC signature checking logic
    
    1) Add DAC file locking until the it is loaded (new out parameter on VerifyDacDll)
    2) Change property from SecureDacLoading to DacSignatureVerificationEnabled
    3) Now VerifyDacDll fails (returns false) if called non-Windows platforms
    4) Clean up CustomDataTarget and DataTarget interaction
    
    ----
    #### AI description  (iteration 1)
    #### PR Classification
    Code enhancement
    
    #### PR Summary
    Refines the DAC signature checking logic to improve security and maintainability.
    - `DacLibrary.cs`: Introduced `fileLock` for better resource management and updated signature verification logic.
    - `AuthenticodeUtil.cs`: Modified `VerifyDacDll` to include `fileLock` and added error tracing for non-Windows platforms.
    - `DataTarget.cs`: Replaced `SecureDacLoading` with `DacSignatureVerificationEnabled` and refactored related logic.
    - `CustomDataTarget.cs`: Updated property name to `DacSignatureVerificationEnabled`.
    Mike McLaughlin committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    7f2065f View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Merge branch 'main' into update_internal_main

    Mike McLaughlin committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    05882dd View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Merged PR 44719: Update internal/main from main

    Mike McLaughlin committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    14704a5 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Merge branch 'main' into update_internal_main

    Mike McLaughlin committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    884882c View commit details
    Browse the repository at this point in the history
  2. Merged PR 45246: Merge main into internal/main

    #### AI description  (iteration 1)
    #### PR Classification
    Merge main branch into internal/main branch to incorporate recent updates.
    
    #### PR Summary
    This pull request merges the main branch into the internal/main branch, incorporating recent updates and configurations.
    - Updated `azure-pipelines-internal.yml` to enable Policheck and TSA with specific configurations.
    - Updated dependencies in `eng/Version.Details.xml` to newer versions of `Microsoft.DotNet.Arcade.Sdk` and `Microsoft.DotNet.CodeAnalysis`.
    - Updated `global.json` to reference the new version of `Microsoft.DotNet.Arcade.Sdk`.
    Mike McLaughlin committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    f08fa40 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2024

  1. Merge branch 'main' into update_internal_main

    Mike McLaughlin committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    66b37ed View commit details
    Browse the repository at this point in the history
  2. Merged PR 45574: Update internal/main from main

    #### AI description  (iteration 1)
    #### PR Classification
    Code cleanup and dependency update.
    
    #### PR Summary
    This pull request updates dependencies and refines code logic to improve maintainability and correctness.
    - Updated `Microsoft.DotNet.Arcade.Sdk` and `Microsoft.DotNet.CodeAnalysis` dependencies in `/eng/Version.Details.xml` and `/global.json`.
    - Refined object alignment and validation logic in `src/Microsoft.Diagnostics.Runtime/ClrHeap.cs`.
    Mike McLaughlin committed Dec 2, 2024
    Configuration menu
    Copy the full SHA
    45bfefc View commit details
    Browse the repository at this point in the history

Commits on Feb 12, 2025

  1. Update dependencies from https://github.com/dotnet/arcade build 20250…

    …205.2 (#1303)
    
    Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis
     From Version 8.0.0-beta.25079.1 -> To Version 8.0.0-beta.25105.2
    
    Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
    dotnet-maestro[bot] and dotnet-maestro[bot] authored Feb 12, 2025
    Configuration menu
    Copy the full SHA
    92db4da View commit details
    Browse the repository at this point in the history
  2. Merge branch 'internal/main' into internal_merge

    Mike McLaughlin committed Feb 12, 2025
    Configuration menu
    Copy the full SHA
    9bc3550 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #1304 from mikem8361/internal_merge

    Merge internal/main changes
    Mike McLaughlin authored Feb 12, 2025
    Configuration menu
    Copy the full SHA
    a78ddee View commit details
    Browse the repository at this point in the history
  4. Update dependencies from https://github.com/dotnet/arcade build 20250…

    …211.4
    
    Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis
     From Version 8.0.0-beta.25105.2 -> To Version 8.0.0-beta.25111.4
    dotnet-maestro[bot] committed Feb 12, 2025
    Configuration menu
    Copy the full SHA
    51608eb View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2025

  1. Merge pull request #1305 from microsoft/darc-main-d99da8c8-85f4-4f6f-…

    …8bc3-d37da31054d1
    
    [main] Update dependencies from dotnet/arcade
    Mike McLaughlin authored Feb 13, 2025
    Configuration menu
    Copy the full SHA
    2b1d282 View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2025

  1. Update dependencies from https://github.com/dotnet/arcade build 20250…

    …214.5
    
    Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.CodeAnalysis
     From Version 8.0.0-beta.25111.4 -> To Version 8.0.0-beta.25114.5
    dotnet-maestro[bot] committed Feb 17, 2025
    Configuration menu
    Copy the full SHA
    55008fa View commit details
    Browse the repository at this point in the history
  2. Merge pull request #1307 from microsoft/darc-main-d5d4fbfd-d4b8-48de-…

    …84b0-6c7a6e65e778
    
    [main] Update dependencies from dotnet/arcade
    Mike McLaughlin authored Feb 17, 2025
    Configuration menu
    Copy the full SHA
    5b1e070 View commit details
    Browse the repository at this point in the history
Loading