Merge internal/main changes#1304
Merged
mikem8361 merged 10 commits intomicrosoft:mainfrom Feb 12, 2025
Merged
Conversation
added 10 commits
October 16, 2024 16:30
Added a new common code/function called WinTrustVerify.VerifyDacDll that checks the DAC for the special cert. It is used by DacLibrary and externally by SOS. ---- #### AI description (iteration 1) #### PR Classification New feature #### PR Summary Introduces a new feature to verify DAC (Data Access Component) certificate signing. - Added `AuthenticodeUtil.cs` to handle DAC certificate verification. - Updated `CustomDataTarget.cs` and `DataTarget.cs` to include `SecureDacLoading` property. - Modified `DacLibrary.cs` to enforce DAC certificate verification using `AuthenticodeUtil`. - Updated `Microsoft.Diagnostics.Runtime.csproj` to use a newer version of `Azure.Identity`.
Update DAC signature checking logic 1) Add DAC file locking until the it is loaded (new out parameter on VerifyDacDll) 2) Change property from SecureDacLoading to DacSignatureVerificationEnabled 3) Now VerifyDacDll fails (returns false) if called non-Windows platforms 4) Clean up CustomDataTarget and DataTarget interaction ---- #### AI description (iteration 1) #### PR Classification Code enhancement #### PR Summary Refines the DAC signature checking logic to improve security and maintainability. - `DacLibrary.cs`: Introduced `fileLock` for better resource management and updated signature verification logic. - `AuthenticodeUtil.cs`: Modified `VerifyDacDll` to include `fileLock` and added error tracing for non-Windows platforms. - `DataTarget.cs`: Replaced `SecureDacLoading` with `DacSignatureVerificationEnabled` and refactored related logic. - `CustomDataTarget.cs`: Updated property name to `DacSignatureVerificationEnabled`.
#### AI description (iteration 1) #### PR Classification Merge main branch into internal/main branch to incorporate recent updates. #### PR Summary This pull request merges the main branch into the internal/main branch, incorporating recent updates and configurations. - Updated `azure-pipelines-internal.yml` to enable Policheck and TSA with specific configurations. - Updated dependencies in `eng/Version.Details.xml` to newer versions of `Microsoft.DotNet.Arcade.Sdk` and `Microsoft.DotNet.CodeAnalysis`. - Updated `global.json` to reference the new version of `Microsoft.DotNet.Arcade.Sdk`.
#### AI description (iteration 1) #### PR Classification Code cleanup and dependency update. #### PR Summary This pull request updates dependencies and refines code logic to improve maintainability and correctness. - Updated `Microsoft.DotNet.Arcade.Sdk` and `Microsoft.DotNet.CodeAnalysis` dependencies in `/eng/Version.Details.xml` and `/global.json`. - Refined object alignment and validation logic in `src/Microsoft.Diagnostics.Runtime/ClrHeap.cs`.
hoyosjs
approved these changes
Feb 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.