Fixes #851 : relevanceThreshold is not utilized preventing additional memory items#920
Merged
glahaye merged 1 commit intomicrosoft:mainfrom Apr 8, 2024
habanoz:main
Merged
Fixes #851 : relevanceThreshold is not utilized preventing additional memory items#920glahaye merged 1 commit intomicrosoft:mainfrom habanoz:main
glahaye merged 1 commit intomicrosoft:mainfrom
habanoz:main
Conversation
fix bug related to issue #851. Unused parameter relevanceThreshold is passed to SearchAsync method to ensure only relevant documents are fetched.
glahaye
approved these changes
Apr 8, 2024
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
…dditional memory items (microsoft#920) fix bug related to issue microsoft#851. Unused parameter relevanceThreshold is passed to SearchAsync method to ensure only relevant documents are fetched. ### Motivation and Context Please help reviewers and future users, providing the following information: 1. The code change is related because current code retrieves all memory items regardless of similarity which prevents adding new memory items. Check SemanticChatMemoryExtractor.ExtractCognitiveMemoryAsync. 2. The issue is only the first memory item is preserved. Additional memory items are lost because they always seem to be similar to the first memory item. 3. With this fix, a memory item is skipped only if there is similar memory item in the memory. As a result distinct memory items will be preserved. 4. It fixes an open issue microsoft#851 . ### Description The chance is simple, it utilizes unutilized relevanceThreshold parameter in ISemanticMemoryClientExtensions.SearchAsync method. SemanticChatMemoryExtractor.ExtractCognitiveMemoryAsync sends an upper threshold to find similar items, but since it is not used all non relevant memory items are returned. ### Contribution Checklist - [X] The code builds clean without any errors or warnings - [X] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [?] All unit tests pass, and I have added new tests where possible. I could not find any unit tests to run or extend. Please point out if there are any tests relevant to memory retrieval. - [X] I didn't break anyone 😄
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
…dditional memory items (microsoft#920) fix bug related to issue microsoft#851. Unused parameter relevanceThreshold is passed to SearchAsync method to ensure only relevant documents are fetched. ### Motivation and Context Please help reviewers and future users, providing the following information: 1. The code change is related because current code retrieves all memory items regardless of similarity which prevents adding new memory items. Check SemanticChatMemoryExtractor.ExtractCognitiveMemoryAsync. 2. The issue is only the first memory item is preserved. Additional memory items are lost because they always seem to be similar to the first memory item. 3. With this fix, a memory item is skipped only if there is similar memory item in the memory. As a result distinct memory items will be preserved. 4. It fixes an open issue microsoft#851 . ### Description The chance is simple, it utilizes unutilized relevanceThreshold parameter in ISemanticMemoryClientExtensions.SearchAsync method. SemanticChatMemoryExtractor.ExtractCognitiveMemoryAsync sends an upper threshold to find similar items, but since it is not used all non relevant memory items are returned. ### Contribution Checklist - [X] The code builds clean without any errors or warnings - [X] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [?] All unit tests pass, and I have added new tests where possible. I could not find any unit tests to run or extend. Please point out if there are any tests relevant to memory retrieval. - [X] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix bug related to issue #851.
Unused parameter relevanceThreshold is passed to SearchAsync method to ensure only relevant documents are fetched.
Motivation and Context
Please help reviewers and future users, providing the following information:
Description
The chance is simple, it utilizes unutilized relevanceThreshold parameter in ISemanticMemoryClientExtensions.SearchAsync method. SemanticChatMemoryExtractor.ExtractCognitiveMemoryAsync sends an upper threshold to find similar items, but since it is not used all non relevant memory items are returned.
Contribution Checklist