Merged
Conversation
glahaye
reviewed
Jul 28, 2023
webapi/CopilotChat/Skills/ChatSkills/SemanticChatMemoryExtractor.cs
Outdated
Show resolved
Hide resolved
4 tasks
dehoward
reviewed
Jul 28, 2023
dehoward
reviewed
Jul 28, 2023
dehoward
previously approved these changes
Jul 28, 2023
…or.cs Co-authored-by: Gil LaHaye <gillahaye@microsoft.com>
Co-authored-by: Desmond Howard <dehoward@microsoft.com>
dehoward
previously approved these changes
Aug 2, 2023
glahaye
reviewed
Aug 2, 2023
webapi/CopilotChat/Skills/ChatSkills/SemanticChatMemoryExtractor.cs
Outdated
Show resolved
Hide resolved
glahaye
reviewed
Aug 2, 2023
webapi/CopilotChat/Skills/ChatSkills/SemanticChatMemoryExtractor.cs
Outdated
Show resolved
Hide resolved
glahaye
reviewed
Aug 2, 2023
glahaye
approved these changes
Aug 2, 2023
dehoward
approved these changes
Aug 2, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This is a continuation of PR microsoft/semantic-kernel#1989 from the previous repo. It accounts for [last comments](microsoft/semantic-kernel#1989 (comment)) from @dmytrostruk. Another PR will be made on SK repo for chroma connector updates. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> This PR adds chroma DB as an alternative memory store available for the copilot chat. Because chroma client raises exceptions with non existing collections, safeguards were added to account for memory search performed before the collections were created. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Gil LaHaye <gillahaye@microsoft.com> Co-authored-by: Desmond Howard <dehoward@microsoft.com>
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
### Motivation and Context <!-- Thank you for your contribution to the copilot-chat repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> This is a continuation of PR microsoft/semantic-kernel#1989 from the previous repo. It accounts for [last comments](microsoft/semantic-kernel#1989 (comment)) from @dmytrostruk. Another PR will be made on SK repo for chroma connector updates. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> This PR adds chroma DB as an alternative memory store available for the copilot chat. Because chroma client raises exceptions with non existing collections, safeguards were added to account for memory search performed before the collections were created. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Gil LaHaye <gillahaye@microsoft.com> Co-authored-by: Desmond Howard <dehoward@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This is a continuation of PR microsoft/semantic-kernel#1989 from the previous repo. It accounts for last comments from @dmytrostruk.
Another PR will be made on SK repo for chroma connector updates.
Description
This PR adds chroma DB as an alternative memory store available for the copilot chat. Because chroma client raises exceptions with non existing collections, safeguards were added to account for memory search performed before the collections were created.
Contribution Checklist