Make deployment template more robust#616
Merged
glahaye merged 4 commits intomicrosoft:mainfrom Nov 18, 2023
glahaye:robusttemplate
Merged
Make deployment template more robust#616glahaye merged 4 commits intomicrosoft:mainfrom glahaye:robusttemplate
glahaye merged 4 commits intomicrosoft:mainfrom
glahaye:robusttemplate
Conversation
TaoChenOSU
previously approved these changes
Nov 17, 2023
…ant we use, removing that usage
TaoChenOSU
approved these changes
Nov 18, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context The templates are currently prone to failure. ### Description - Only use virtual nets when using Qdrant (it seems _something_ with the virtual nets is causing deployments to often fail) - Automatically populate azureAdTenantId - Force user to provide an API key and client IDs (instead of allowing unusable deployments to be created) ### Contribution Checklist - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
### Motivation and Context The templates are currently prone to failure. ### Description - Only use virtual nets when using Qdrant (it seems _something_ with the virtual nets is causing deployments to often fail) - Automatically populate azureAdTenantId - Force user to provide an API key and client IDs (instead of allowing unusable deployments to be created) ### Contribution Checklist - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The templates are currently prone to failure.
Description
Contribution Checklist