Skip to content

Changed default build platform to win-x64 even in Linux scripts#606

Merged
glahaye merged 1 commit intomicrosoft:mainfrom
glahaye:win-x64
Nov 13, 2023
Merged

Changed default build platform to win-x64 even in Linux scripts#606
glahaye merged 1 commit intomicrosoft:mainfrom
glahaye:win-x64

Conversation

@glahaye
Copy link
Contributor

@glahaye glahaye commented Nov 13, 2023

Motivation and Context

Building for Linux makes packages incompatible with our deployed resources.

Description

Build for win-x64 by default instead of of linux-x64.

Users can override if they want to build linux-x64 version.

Contribution Checklist

@github-actions github-actions bot added the deployment Issues related to deploying Chat-Copilot label Nov 13, 2023
@glahaye glahaye linked an issue Nov 13, 2023 that may be closed by this pull request
@glahaye glahaye added this pull request to the merge queue Nov 13, 2023
Merged via the queue into microsoft:main with commit d3e3bfd Nov 13, 2023
@glahaye glahaye deleted the win-x64 branch November 13, 2023 21:27
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
…osoft#606)

### Motivation and Context
Building for Linux makes packages incompatible with our deployed
resources.

### Description
Build for win-x64 by default instead of of linux-x64.

Users can override if they want to build linux-x64 version.

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
kb0039 pushed a commit to aaronba/chat-copilot that referenced this pull request Jan 8, 2025
…osoft#606)

### Motivation and Context
Building for Linux makes packages incompatible with our deployed
resources.

### Description
Build for win-x64 by default instead of of linux-x64.

Users can override if they want to build linux-x64 version.

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment Issues related to deploying Chat-Copilot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong default value for RUNTIME in package-webapi.sh

2 participants