Skip to content

Fix condition to skip building frontend#561

Merged
glahaye merged 5 commits intomicrosoft:mainfrom
glahaye:fix_condition
Oct 31, 2023
Merged

Fix condition to skip building frontend#561
glahaye merged 5 commits intomicrosoft:mainfrom
glahaye:fix_condition

Conversation

@glahaye
Copy link
Contributor

@glahaye glahaye commented Oct 30, 2023

and replace "Copilot Chat" with "Chat Copilot" to test it

Motivation and Context

Save time by not building the frontend files when we only are doing a PR for backend files

Description

Remove the "=" that was messing up the boolean evaluation.

Replace a bunch of "Copilot Chat" strings with "Chat Copilot" to verify fix.

Contribution Checklist

@github-actions github-actions bot added documentation Improvements or additions to documentation webapi Pull requests that update .net code github actions Pull requests that update GitHub Actions code labels Oct 30, 2023
@glahaye glahaye marked this pull request as draft October 30, 2023 18:50
@glahaye glahaye marked this pull request as ready for review October 30, 2023 19:04
@glahaye glahaye added this pull request to the merge queue Oct 31, 2023
Merged via the queue into microsoft:main with commit b45db51 Oct 31, 2023
@glahaye glahaye deleted the fix_condition branch October 31, 2023 16:39
teamleader-dev pushed a commit to vlink-group/chat-copilot that referenced this pull request Oct 7, 2024
and replace "Copilot Chat" with "Chat Copilot" to test it

### Motivation and Context
Save time by not building the frontend files when we only are doing a PR
for backend files

### Description
Remove the "=" that was messing up the boolean evaluation.

Replace a bunch of "Copilot Chat" strings with "Chat Copilot" to verify
fix.

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
kb0039 pushed a commit to aaronba/chat-copilot that referenced this pull request Jan 8, 2025
and replace "Copilot Chat" with "Chat Copilot" to test it

### Motivation and Context
Save time by not building the frontend files when we only are doing a PR
for backend files

### Description
Remove the "=" that was messing up the boolean evaluation.

Replace a bunch of "Copilot Chat" strings with "Chat Copilot" to verify
fix.

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation github actions Pull requests that update GitHub Actions code webapi Pull requests that update .net code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants