Make deploying the web searcher plugin optional#517
Merged
glahaye merged 3 commits intomicrosoft:mainfrom Oct 17, 2023
Merged
Conversation
glahaye
reviewed
Oct 17, 2023
glahaye
reviewed
Oct 17, 2023
glahaye
reviewed
Oct 17, 2023
glahaye
reviewed
Oct 17, 2023
glahaye
reviewed
Oct 17, 2023
alliscode
previously approved these changes
Oct 17, 2023
glahaye
approved these changes
Oct 17, 2023
|
following #517 deploy-azure.ps1 still errors w/ |
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context <!-- Thank you for your contribution to the chat-copilot repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> The Web Searcher plugin requires a Bing resource, which may require elevated permission. This will fail the whole deployment, blocking developers from deploying the latest CC. Issues: microsoft#498 ### Description This PR makes deploying the Web Searcher plugin optional. And by default, it's NOT deployed. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
### Motivation and Context <!-- Thank you for your contribution to the chat-copilot repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> The Web Searcher plugin requires a Bing resource, which may require elevated permission. This will fail the whole deployment, blocking developers from deploying the latest CC. Issues: microsoft#498 ### Description This PR makes deploying the Web Searcher plugin optional. And by default, it's NOT deployed. <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [ ] The code builds clean without any errors or warnings - [ ] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [ ] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The Web Searcher plugin requires a Bing resource, which may require elevated permission. This will fail the whole deployment, blocking developers from deploying the latest CC.
Issues:
#498
Description
This PR makes deploying the Web Searcher plugin optional. And by default, it's NOT deployed.
Contribution Checklist