Skip to content

Fix: App component UseEffect infinite loop#1199

Merged
alliscode merged 1 commit intomainfrom
taochen/fix-app-use-effect-inifinite-loop
Oct 31, 2024
Merged

Fix: App component UseEffect infinite loop#1199
alliscode merged 1 commit intomainfrom
taochen/fix-app-use-effect-inifinite-loop

Conversation

@TaoChenOSU
Copy link
Contributor

Motivation and Context

The useEffect hook in the App component is causing an infinite rendering loop. Remove the dependencies that are causing the loop.

Description

Contribution Checklist

@github-actions github-actions bot added the webapp Pull requests that update Typescript code label Oct 31, 2024
@alliscode alliscode added this pull request to the merge queue Oct 31, 2024
Merged via the queue into main with commit f2f4a32 Oct 31, 2024
@alliscode alliscode deleted the taochen/fix-app-use-effect-inifinite-loop branch October 31, 2024 21:01
kb0039 pushed a commit to aaronba/chat-copilot that referenced this pull request Jan 8, 2025
### Motivation and Context

<!-- Thank you for your contribution to the chat-copilot repo!
Please help reviewers and future users, providing the following
information:
  1. Why is this change required?
  2. What problem does it solve?
  3. What scenario does it contribute to?
  4. If it fixes an open issue, please link to the issue here.
-->
The useEffect hook in the App component is causing an infinite rendering
loop. Remove the dependencies that are causing the loop.


### Description

<!-- Describe your changes, the overall approach, the underlying design.
These notes will help understanding how your code works. Thanks! -->

### Contribution Checklist

<!-- Before submitting this PR, please make sure: -->

- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
- [ ] I didn't break anyone 😄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

webapp Pull requests that update Typescript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants