move Chat component logic to separate file#1000
Merged
glahaye merged 1 commit intomicrosoft:mainfrom Jun 12, 2024
Merged
Conversation
Contributor
Author
@microsoft-github-policy-service agree |
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context <!-- Thank you for your contribution to the chat-copilot repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> 1. Why is this change required? - This change is required to improve the modularity and readability. 2. What problem does it solve? - This change reduces the complexity of the app.tsx file by isolating the `<Chat />` component into its own file. 3. What scenario does it contribute to? - This contributes to scenarios where developers need to work on or debug the `<Chat/>` component independently of the main app logic. It also makes it easier for new developers to understand the structure of the application. 4. If it fixes an open issue, please link to the issue here. - Not applicable/This PR does not address a specific open issue. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> In this PR, I have created a new file named `Chat.tsx` and moved the relevant JSX and TypeScript code from app.tsx into this new component file. The main goals were to enhance modularity and readability. Here are some specifics: - File Creation: A new file Chat.tsx was created. - Code Migration: Logic specific to `<Chat />` was moved from app.tsx to the new file. - Testing: Ensured that the application behaves as expected after the component migration. No functionality has been altered, only restructured. - Imports/Exports: Updated import statements in app.tsx to reflect the change. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
kb0039
pushed a commit
to aaronba/chat-copilot
that referenced
this pull request
Jan 8, 2025
### Motivation and Context <!-- Thank you for your contribution to the chat-copilot repo! Please help reviewers and future users, providing the following information: 1. Why is this change required? 2. What problem does it solve? 3. What scenario does it contribute to? 4. If it fixes an open issue, please link to the issue here. --> 1. Why is this change required? - This change is required to improve the modularity and readability. 2. What problem does it solve? - This change reduces the complexity of the app.tsx file by isolating the `<Chat />` component into its own file. 3. What scenario does it contribute to? - This contributes to scenarios where developers need to work on or debug the `<Chat/>` component independently of the main app logic. It also makes it easier for new developers to understand the structure of the application. 4. If it fixes an open issue, please link to the issue here. - Not applicable/This PR does not address a specific open issue. ### Description <!-- Describe your changes, the overall approach, the underlying design. These notes will help understanding how your code works. Thanks! --> In this PR, I have created a new file named `Chat.tsx` and moved the relevant JSX and TypeScript code from app.tsx into this new component file. The main goals were to enhance modularity and readability. Here are some specifics: - File Creation: A new file Chat.tsx was created. - Code Migration: Logic specific to `<Chat />` was moved from app.tsx to the new file. - Testing: Ensured that the application behaves as expected after the component migration. No functionality has been altered, only restructured. - Imports/Exports: Updated import statements in app.tsx to reflect the change. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [ ] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Why is this change required?
What problem does it solve?
<Chat />component into its own file.What scenario does it contribute to?
<Chat/>component independently of the main app logic. It also makes it easier for new developers to understand the structure of the application.If it fixes an open issue, please link to the issue here.
Description
In this PR, I have created a new file named
Chat.tsxand moved the relevant JSX and TypeScript code from app.tsx into this new component file. The main goals were to enhance modularity and readability. Here are some specifics:<Chat />was moved from app.tsx to the new file.Contribution Checklist