Skip to content

Conversation

@aaronbell
Copy link
Collaborator

@aaronbell aaronbell commented Jun 2, 2021

Summary of the Pull Request

  • Fixing a bug in the ccmp feature file
  • Deleting the (unused) liga feature file
  • Adding ccmp to the feature set in the build script.
  • /f, /l, /s, /r have been updated to follow more 'generic' forms.
  • previous versions have been moved to ss01 / salt OT features.
  • all related glyphs have been similarly adjusted.

PR Checklist

##Before / after

Old Italic:
Screen Shot 2021-06-03 at 2 38 29 PM

New italic forms:
Screen Shot 2021-06-03 at 2 35 13 PM

aaronbell and others added 14 commits May 25, 2021 16:37
…ances

For whatever reason glyphslib sets the familyName of the font to include the "Italic" name. I had corrected the variable font instance, but not the static instances.
Double-checked to make sure that the hinting didn't break in fixing these.
I was there. I updated it.
Still need to hint, but moving along?
- resolving more interpolation fun
- updating hints
- Fixing a bug in the ccmp feature file
- Deleting the (unused) liga feature file
- Adding ccmp to the feature set in the build script.
- /f, /l, /s, /r have been updated to follow more 'generic' forms.
- previous versions have been moved to ss01 / salt OT features.
- all related glyphs have been similarly adjusted.
@aaronbell aaronbell changed the title Fixing regression in OT features Fixing regression in OT features and updating Cascadia Code Italic Jun 3, 2021
aaronbell added 2 commits June 3, 2021 15:21
Useful for when the day is <10!
Showing off the alternate style.
@aaronbell
Copy link
Collaborator Author

Closing, as will be superseded by another PR soon. :)

@aaronbell aaronbell closed this Jun 16, 2021
DHowett pushed a commit that referenced this pull request Jun 18, 2021
Major update! 

This update includes the brand new Arabic and Hebrew language coverage,
along with a variety of bug fixes to the upright and italic fonts. There
has also been a major overhaul of the Cascadia Code Italic lowercase to
make the forms align better with our vision for the font. Enjoy :). 

Supersedes #491

Cascadia Code
* [x] Closes #84 - Arabic language support added!
* [x] Closes #465 - Hebrew language support added!
* [x] Closes #499 - Adjusted base mark positions / set others to be
  ignored in propagateAnchors

Cascadia Code Italic
* [x] Closes #470 - Adjusted slant on cursive forms to feel a bit better
* [x] Closes #468 - Moved cursive forms to `ss01` / `salt` feature 
* [x] Closes #507 - Changed bar / broken bar to be upright for better
  clarity. All ligature forms adjusted.

Both
* [x] Closes #494 - Adjusted `ƒ` in both upright and italic

- Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
  Arabic features PDF] for the exciting new Arabic ligature
  functionality used in Cascadia Code that gives the font greatly
  improved readability and feel more more akin to a text typeface. Don't
  want all that? Don't worry, Cascadia Mono will house a normal version
  of Arabic. 

- Hebrew support added (design by Liron Lavi Turkenich)
- Fixing a bug in the ccmp feature file and added ccmp to the feature
  set in the build script.
- Deleting the (unused) liga feature file
- Vika has reviewed and improved some forms in Cascadia Code upright. 
- /f, /l, /s, /r (and related forms) have been updated to follow more
  'generic' forms. Previous versions have been moved to ss01 / salt OT
  features.

- Changed design of `ƒ` in upright to align better with the standard
  `f`. In the italic, the `ƒ` has been changed to follow the cursive
  version. When `ss01` is applied, the design of the `f` and `ƒ` are
  swapped, and if the `locl` EWE language setting is applied, the 'f'
  swaps for a straight descender version (with cursive `ƒ`).
  Complicated, but achieves supporting everything.

- Entry and exit strokes across the italic lowercase have been rounded
  to better achieve the fun / playful design language that we intended
  for the italic. Other skeletons have been modified as necessary.
  Cyrillic has also been updated for better consistency with the new
  design. 

- Greek lowercase has been updated per feedback from Gerry Leonidas to
  be more cohesive (No longer a mix between a Monday and Friday font.
  All Friday, all the time)

## Validation Steps Performed
All updated reviewed, hinted, and reviewed again :)

[the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell added a commit to aaronbell/cascadia-code that referenced this pull request Jun 21, 2021
commit e9aa335
Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com>
Date:   Sat Jun 19 00:42:28 2021 +0600

    Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385)

    Co-authored-by: Aaron <aaronbell@users.noreply.github.com>

commit fb0bce6
Author: Aaron <aaronbell@users.noreply.github.com>
Date:   Fri Jun 18 10:37:03 2021 -0700

    Add Hebrew and Arabic; rework Italic (microsoft#511)

    Major update!

    This update includes the brand new Arabic and Hebrew language coverage,
    along with a variety of bug fixes to the upright and italic fonts. There
    has also been a major overhaul of the Cascadia Code Italic lowercase to
    make the forms align better with our vision for the font. Enjoy :).

    Supersedes microsoft#491

    Cascadia Code
    * [x] Closes microsoft#84 - Arabic language support added!
    * [x] Closes microsoft#465 - Hebrew language support added!
    * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be
      ignored in propagateAnchors

    Cascadia Code Italic
    * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better
    * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature
    * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better
      clarity. All ligature forms adjusted.

    Both
    * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic

    - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
      Arabic features PDF] for the exciting new Arabic ligature
      functionality used in Cascadia Code that gives the font greatly
      improved readability and feel more more akin to a text typeface. Don't
      want all that? Don't worry, Cascadia Mono will house a normal version
      of Arabic.

    - Hebrew support added (design by Liron Lavi Turkenich)
    - Fixing a bug in the ccmp feature file and added ccmp to the feature
      set in the build script.
    - Deleting the (unused) liga feature file
    - Vika has reviewed and improved some forms in Cascadia Code upright.
    - /f, /l, /s, /r (and related forms) have been updated to follow more
      'generic' forms. Previous versions have been moved to ss01 / salt OT
      features.

    - Changed design of `ƒ` in upright to align better with the standard
      `f`. In the italic, the `ƒ` has been changed to follow the cursive
      version. When `ss01` is applied, the design of the `f` and `ƒ` are
      swapped, and if the `locl` EWE language setting is applied, the 'f'
      swaps for a straight descender version (with cursive `ƒ`).
      Complicated, but achieves supporting everything.

    - Entry and exit strokes across the italic lowercase have been rounded
      to better achieve the fun / playful design language that we intended
      for the italic. Other skeletons have been modified as necessary.
      Cyrillic has also been updated for better consistency with the new
      design.

    - Greek lowercase has been updated per feedback from Gerry Leonidas to
      be more cohesive (No longer a mix between a Monday and Friday font.
      All Friday, all the time)

    ## Validation Steps Performed
    All updated reviewed, hinted, and reviewed again :)

    [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell added a commit to aaronbell/cascadia-code that referenced this pull request Jun 23, 2021
commit e9aa335
Author: Sayed Arif Uddin Pallab <47639147+sayedarifuddin@users.noreply.github.com>
Date:   Sat Jun 19 00:42:28 2021 +0600

    Replaced Hypen (-) with Dash (–) to maintain symmetric view (microsoft#385)

    Co-authored-by: Aaron <aaronbell@users.noreply.github.com>

commit fb0bce6
Author: Aaron <aaronbell@users.noreply.github.com>
Date:   Fri Jun 18 10:37:03 2021 -0700

    Add Hebrew and Arabic; rework Italic (microsoft#511)

    Major update!

    This update includes the brand new Arabic and Hebrew language coverage,
    along with a variety of bug fixes to the upright and italic fonts. There
    has also been a major overhaul of the Cascadia Code Italic lowercase to
    make the forms align better with our vision for the font. Enjoy :).

    Supersedes microsoft#491

    Cascadia Code
    * [x] Closes microsoft#84 - Arabic language support added!
    * [x] Closes microsoft#465 - Hebrew language support added!
    * [x] Closes microsoft#499 - Adjusted base mark positions / set others to be
      ignored in propagateAnchors

    Cascadia Code Italic
    * [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better
    * [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature
    * [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better
      clarity. All ligature forms adjusted.

    Both
    * [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic

    - Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
      Arabic features PDF] for the exciting new Arabic ligature
      functionality used in Cascadia Code that gives the font greatly
      improved readability and feel more more akin to a text typeface. Don't
      want all that? Don't worry, Cascadia Mono will house a normal version
      of Arabic.

    - Hebrew support added (design by Liron Lavi Turkenich)
    - Fixing a bug in the ccmp feature file and added ccmp to the feature
      set in the build script.
    - Deleting the (unused) liga feature file
    - Vika has reviewed and improved some forms in Cascadia Code upright.
    - /f, /l, /s, /r (and related forms) have been updated to follow more
      'generic' forms. Previous versions have been moved to ss01 / salt OT
      features.

    - Changed design of `ƒ` in upright to align better with the standard
      `f`. In the italic, the `ƒ` has been changed to follow the cursive
      version. When `ss01` is applied, the design of the `f` and `ƒ` are
      swapped, and if the `locl` EWE language setting is applied, the 'f'
      swaps for a straight descender version (with cursive `ƒ`).
      Complicated, but achieves supporting everything.

    - Entry and exit strokes across the italic lowercase have been rounded
      to better achieve the fun / playful design language that we intended
      for the italic. Other skeletons have been modified as necessary.
      Cyrillic has also been updated for better consistency with the new
      design.

    - Greek lowercase has been updated per feedback from Gerry Leonidas to
      be more cohesive (No longer a mix between a Monday and Friday font.
      All Friday, all the time)

    ## Validation Steps Performed
    All updated reviewed, hinted, and reviewed again :)

    [the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
aaronbell added a commit to aaronbell/cascadia-code that referenced this pull request Jun 23, 2021
Major update!

This update includes the brand new Arabic and Hebrew language coverage,
along with a variety of bug fixes to the upright and italic fonts. There
has also been a major overhaul of the Cascadia Code Italic lowercase to
make the forms align better with our vision for the font. Enjoy :).

Supersedes microsoft#491

Cascadia Code
* [x] Closes microsoft#84 - Arabic language support added!
* [x] Closes microsoft#465 - Hebrew language support added!
* [x] Closes microsoft#499 - Adjusted base mark positions / set others to be
  ignored in propagateAnchors

Cascadia Code Italic
* [x] Closes microsoft#470 - Adjusted slant on cursive forms to feel a bit better
* [x] Closes microsoft#468 - Moved cursive forms to `ss01` / `salt` feature
* [x] Closes microsoft#507 - Changed bar / broken bar to be upright for better
  clarity. All ligature forms adjusted.

Both
* [x] Closes microsoft#494 - Adjusted `ƒ` in both upright and italic

- Arabic (and Urdu) support added (design by Mohamad Dakak). See [the
  Arabic features PDF] for the exciting new Arabic ligature
  functionality used in Cascadia Code that gives the font greatly
  improved readability and feel more more akin to a text typeface. Don't
  want all that? Don't worry, Cascadia Mono will house a normal version
  of Arabic.

- Hebrew support added (design by Liron Lavi Turkenich)
- Fixing a bug in the ccmp feature file and added ccmp to the feature
  set in the build script.
- Deleting the (unused) liga feature file
- Vika has reviewed and improved some forms in Cascadia Code upright.
- /f, /l, /s, /r (and related forms) have been updated to follow more
  'generic' forms. Previous versions have been moved to ss01 / salt OT
  features.

- Changed design of `ƒ` in upright to align better with the standard
  `f`. In the italic, the `ƒ` has been changed to follow the cursive
  version. When `ss01` is applied, the design of the `f` and `ƒ` are
  swapped, and if the `locl` EWE language setting is applied, the 'f'
  swaps for a straight descender version (with cursive `ƒ`).
  Complicated, but achieves supporting everything.

- Entry and exit strokes across the italic lowercase have been rounded
  to better achieve the fun / playful design language that we intended
  for the italic. Other skeletons have been modified as necessary.
  Cyrillic has also been updated for better consistency with the new
  design.

- Greek lowercase has been updated per feedback from Gerry Leonidas to
  be more cohesive (No longer a mix between a Monday and Friday font.
  All Friday, all the time)

All updated reviewed, hinted, and reviewed again :)

[the Arabic features PDF]: https://github.com/microsoft/cascadia-code/blob/main/doc/Arabic_KeyFeatures.pdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants