-
Notifications
You must be signed in to change notification settings - Fork 842
Set the names of the static instances properly #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixing so static instances build properly.
Previous commit wasn't quite working. Took a different approach.
|
@madig - I wonder if when you updated the requirements.txt file in our last PR that something changed in the way instances are generated from the designspace file. Because we've never modified the instance naming before and it always worked OK. |
|
I'll take a look later, gotta run now. If you haven't, try changing the static fonts compilation function to also change the family names for all instances in the designspace before instantiating the instantiator and then remove the single name setter after it. |
:) |
It's like you read my mind. |
reverting line 221
I think this is a case of setting things in a different order. Font naming is annoying as is and maybe the Designspace ergonomics aren't the best here... you could probably get rid of the |
Right, but the point I was making before was that the code had worked fine with just setting names in the sources and then suddenly stopped working. That’s why I was wondering. |
|
Something I just thought of. Previously we were setting the font family name in the source font files (eg, source.info.familyname) but I don’t believe that actually changed anything in the designspace document. Potentially, the designspace document is now being given greater priority over the source fonts info for instance generation, for whatever reason, requiring modification of the designspace naming. |
re-aligning with microsoft#370
|
I have been a poor steward of this repository, and I should have produced a build in the interim to make it easier for folks who want to use Cascadia. I've been off the ball for quite a while, and it is time to get back on it. Sorry for any delay/for disappearing. |
|
It's ok, we're all open-source here. |
Summary of the Pull Request
Now builds static instances correctly.
PR Checklist
Detailed Description of the Pull Request / Additional comments
As far as I can tell, what essentially happened here is that instances in the designspace were not being renamed, even though the sources were being renamed. As a result, the variable fonts would build correctly, but the static instances were not. The font naming approach has now been changed and is producing reliable results.
What's particularly vexing is that for the life of me I can't figure out how the code actually worked before, because as far as I can tell, we've never modified the instance code before.
Validation Steps Performed
Checked tables in OT Master