Skip to content
This repository was archived by the owner on Jan 5, 2026. It is now read-only.

Conversation

@JhontSouth
Copy link
Collaborator

#minor

Description

This PR disables the adaptive sampling used in the telemetry client to avoid skipping logs due to big amount of concurrent users and events.

Specific Changes

  • Set to false property EnableAdaptiveSampling of telemetry settings in ServiceCollectionExtensions classes.

Testing

The following image shows the logs saved correctly in the Application Insights resource.
image

@JhontSouth JhontSouth requested a review from a team as a code owner September 16, 2024 15:54
@JhontSouth JhontSouth added the Automation: No parity PR does not need to be applied to other languages. label Sep 16, 2024
@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll

@tracyboehrer tracyboehrer merged commit 6d584df into main Sep 17, 2024
@tracyboehrer tracyboehrer deleted the southworks/fix/telemetry-sampling branch September 17, 2024 21:17
tracyboehrer pushed a commit that referenced this pull request Sep 19, 2024
* disable adaptive sampling

* using Microsoft.ApplicationInsights.AspNetCore.Extensions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants