This repository was archived by the owner on Jan 5, 2026. It is now read-only.
[#6741] Remove .Net Core 3.1 from projects #6819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Contributor
|
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll |
tracyboehrer
approved these changes
Jul 16, 2024
tracyboehrer
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Remove netcoreapp3.1 and fix System.Text.Json issue * Fix System.Formats.Asn1 security issue * Fix remaining System.Text.Json issue
tracyboehrer
added a commit
that referenced
this pull request
Sep 10, 2024
* Fix for Skills endorsement check (#6846) Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> * FederatedAppCredentials and factory * add token credential authentication to BlobsTranscriptStore (#6813) * [#6741] Remove .Net Core 3.1 from projects (#6819) * Remove netcoreapp3.1 and fix System.Text.Json issue * Fix System.Formats.Asn1 security issue * Fix remaining System.Text.Json issue * Removed unused argument from FederatedAuthenticator.CreateClientApplication * Fix Microsoft.Bcl.AsyncInterfaces warning (#6837) # Conflicts: # libraries/Microsoft.Bot.Builder.Azure/Microsoft.Bot.Builder.Azure.csproj * add code ql comment about TypeNameHandling.None (#6843) --------- Co-authored-by: Tracy Boehrer <trboehre@microsoft.com> Co-authored-by: Jhonatan Sandoval Velasco <122501764+JhontSouth@users.noreply.github.com> Co-authored-by: Joel Mut <62260472+sw-joelmut@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #6741
#minor
Description
This PR removes
netcoreapp3.1from the projects and pipelines, and fixes System.Text.Json https://github.com/microsoft/botbuilder-dotnet/security/dependabot/41 (CVE-2024-30105) and System.Formats.Asn1 security issues.Specific Changes
netcoreapp3.1configurations from all projects.netcoreapp3.1from CI pipelines.netcoreapp3.1conditionals in the code.System.Text.JsonandSystem.Text.Encodings.Webpackages fromAzure.Blobs,Adaptive.Runtime,Connector.Streaming.System.Text.Jsonto latest8.0.4version.System.Formats.Asn1to latest8.0.1version due to vulnerability issue.Testing
The following image shows the pipeline tests passing, and no errors/warnings for System.Text.Json.
